Github messages for voidlinux
 help / color / mirror / Atom feed
From: heliocat <heliocat@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Omnibus lint pass for SPDX errors, most packages starting with I
Date: Sun, 04 Jul 2021 20:19:48 +0200	[thread overview]
Message-ID: <20210704181948.KV2L_DXRVWfgrvKsJvZTYs8Vjccl4iFzVMwDfZ9-tck@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30573@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages lint_i
https://github.com/void-linux/void-packages/pull/30573

Omnibus lint pass for SPDX errors, most packages starting with I
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/30573.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lint_i-30573.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From 4ba799e924ea5acdcf7fb0bc5a58dbff82393236 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Wed, 14 Apr 2021 11:02:42 -0700
Subject: [PATCH] iat: fix license, short desc

The license is a bit out of the norm for this. The software claims to be
GPL 2, the license file that the bundle with it is the GPL 3 license,
and it has the BSD-2-Clause license bundling requirements and
disclaimer. I'm giving it a custom license to cover all of the angles
but there is a chance that one half or the other entirely supersedes the
rest.
---
 srcpkgs/iat/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/iat/template b/srcpkgs/iat/template
index f7921c53bf14..2bd0c6e84cf2 100644
--- a/srcpkgs/iat/template
+++ b/srcpkgs/iat/template
@@ -1,15 +1,17 @@
 # Template file for 'iat'
 pkgname=iat
 version=0.1.7
-revision=3
+revision=4
 build_style=gnu-configure
-short_desc="A tool for detecting the structure of many types of CD/DVD image"
+short_desc="Tool for detecting the structure of many types of CD/DVD image"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-3"
+license="custom:GPL-2.0-or-later-with-BSD-attribution-requirement"
 homepage="http://sourceforge.net/projects/iat.berlios/"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}.berlios/${pkgname}-${version}.tar.gz"
 checksum=b25d57fde28a02b2d87cd49fd1478b039adbd836351879a654fea14c27764b21
 
 post_install() {
+	sed '2,34p;d' src/main.c > LICENSE
+	vlicense LICENSE
 	rm -rf ${DESTDIR}/usr/include
 }

  parent reply	other threads:[~2021-07-04 18:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  4:54 [PR PATCH] " heliocat
2021-05-05  6:16 ` [PR PATCH] [Updated] " heliocat
2021-06-10  7:49 ` heliocat
2021-06-29  2:06 ` heliocat
2021-07-04 18:19 ` heliocat [this message]
2021-09-01 12:18 ` dkwo
2021-09-01 13:40 ` sgn
2021-09-01 13:40 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210704181948.KV2L_DXRVWfgrvKsJvZTYs8Vjccl4iFzVMwDfZ9-tck@z \
    --to=heliocat@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).