Github messages for voidlinux
 help / color / mirror / Atom feed
From: st3r4g <st3r4g@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] pipewire: update to 0.3.31.
Date: Fri, 09 Jul 2021 12:40:34 +0200	[thread overview]
Message-ID: <20210709104034.F-5ewv38OIZLLdPgUAseHDwLl74aodofGKzuoyjuKbU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31549@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666851308

Comment:
I think there's no reason to make it configurable, because that is the default system socket path (the clients would need an env var with the custom location otherwise). It's the same in [upstream's systemd unit](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/src/daemon/systemd/system/pipewire.service.in) (`%t` expands to /run)

  parent reply	other threads:[~2021-07-09 10:40 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 21:52 [PR PATCH] pipewire: update to 0.3.30 paper42
2021-06-18  2:55 ` ericonr
2021-06-18 10:46 ` st3r4g
2021-06-18 10:47 ` st3r4g
2021-06-18 10:49 ` st3r4g
2021-06-18 12:57 ` ericonr
2021-06-20 16:23 ` [PR PATCH] [Updated] " paper42
2021-06-20 16:28 ` paper42
2021-06-20 16:29 ` paper42
2021-06-20 16:30 ` paper42
2021-06-20 17:17 ` [PR REVIEW] " st3r4g
2021-06-20 17:17 ` st3r4g
2021-06-20 17:17 ` st3r4g
2021-06-20 17:17 ` st3r4g
2021-06-20 17:21 ` st3r4g
2021-06-20 17:21 ` st3r4g
2021-06-20 17:42 ` st3r4g
2021-06-20 17:44 ` cinerea0
2021-06-20 18:11 ` heliocat
2021-06-20 18:13 ` heliocat
2021-06-20 18:30 ` st3r4g
2021-06-20 20:57 ` [PR PATCH] [Updated] " paper42
2021-06-20 20:57 ` paper42
2021-06-20 20:57 ` paper42
2021-06-20 20:59 ` [PR REVIEW] " paper42
2021-06-20 21:03 ` paper42
2021-06-20 21:23 ` st3r4g
2021-06-20 21:31 ` [PR REVIEW] " st3r4g
2021-06-20 21:35 ` st3r4g
2021-06-20 23:38 ` ericonr
2021-06-21 20:33 ` st3r4g
2021-06-21 21:46 ` st3r4g
2021-06-21 21:47 ` st3r4g
2021-06-21 21:48 ` st3r4g
2021-06-21 21:50 ` st3r4g
2021-06-25 20:55 ` [PR REVIEW] " st3r4g
2021-06-25 21:05 ` st3r4g
2021-06-25 22:38 ` st3r4g
2021-06-26 14:34 ` st3r4g
2021-06-26 14:35 ` st3r4g
2021-07-01 22:34 ` [PR PATCH] [Updated] " paper42
2021-07-01 22:36 ` [PR REVIEW] " paper42
2021-07-01 22:41 ` paper42
2021-07-02  9:37 ` [PR REVIEW] pipewire: update to 0.3.31 st3r4g
2021-07-02 11:43 ` st3r4g
2021-07-02 12:12 ` st3r4g
2021-07-02 12:14 ` st3r4g
2021-07-02 12:23 ` st3r4g
2021-07-02 12:39 ` st3r4g
2021-07-02 12:40 ` st3r4g
2021-07-02 13:03 ` st3r4g
2021-07-02 13:04 ` st3r4g
2021-07-02 13:28 ` st3r4g
2021-07-02 13:28 ` st3r4g
2021-07-02 15:00 ` [PR REVIEW] " st3r4g
2021-07-02 22:33 ` [PR PATCH] [Updated] " paper42
2021-07-02 22:40 ` paper42
2021-07-04  3:34 ` ericonr
2021-07-05  9:32 ` [PR PATCH] [Updated] " paper42
2021-07-05 17:13 ` st3r4g
2021-07-05 17:15 ` st3r4g
2021-07-05 17:28 ` st3r4g
2021-07-09  2:52 ` [PR REVIEW] " ericonr
2021-07-09  2:53 ` ericonr
2021-07-09 10:35 ` st3r4g
2021-07-09 10:36 ` st3r4g
2021-07-09 10:40 ` st3r4g [this message]
2021-07-09 10:44 ` st3r4g
2021-07-13 17:38 ` ericonr
2021-07-13 18:07 ` [PR PATCH] [Updated] " paper42
2021-07-13 18:07 ` [PR REVIEW] " paper42
2021-07-13 18:09 ` paper42
2021-07-14 14:11 ` [PR PATCH] [Merged]: " ericonr
2021-07-17 16:57 ` dkwo
2021-07-17 20:13 ` ericonr
2021-07-18  9:32 ` st3r4g
2021-07-18 10:26 ` dkwo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709104034.F-5ewv38OIZLLdPgUAseHDwLl74aodofGKzuoyjuKbU@z \
    --to=st3r4g@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).