[PR PATCH] New package: shellcaster-1.0.1

[PR PATCH] New package: shellcaster-1.0.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

There is a new pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages shellcaster
https://github.com/void-linux/void-packages/pull/24525

New package: shellcaster-1.0.1
Terminal-based podcast manager built in Rust

https://github.com/jeff-hughes/shellcaster

Unfortunately nocross because ncurses-rs's build.rs tries to run a target executable on the host.

A patch file from https://github.com/void-linux/void-packages/pull/24525.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shellcaster-24525.patch --]
[-- Type: text/x-diff, Size: 1286 bytes --]

From 0dabec5d16a361c0e4a3ac104d16a6b4909f917e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sat, 15 Aug 2020 15:10:35 +0200
Subject: [PATCH] New package: shellcaster-1.0.1

---
 srcpkgs/shellcaster/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/shellcaster/template

diff --git a/srcpkgs/shellcaster/template b/srcpkgs/shellcaster/template
new file mode 100644
index 00000000000..7380ddd4999
--- /dev/null
+++ b/srcpkgs/shellcaster/template
@@ -0,0 +1,19 @@
+# Template file for 'shellcaster'
+pkgname=shellcaster
+version=1.0.1
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="libressl-devel ncurses-devel sqlite-devel"
+short_desc="Terminal-based podcast manager built in Rust"
+maintainer="Daniel Eyßer <daniel.eysser@gmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/jeff-hughes/shellcaster"
+changelog="https://github.com/jeff-hughes/shellcaster/raw/master/CHANGELOG.md"
+distfiles="https://github.com/jeff-hughes/shellcaster/archive/v${version}.tar.gz"
+checksum=323945dc84bef27d09e57b831d2c0a0d4524c69b38d85f3be2701521b89dd9d1
+nocross="ncurses-rs tries to run a target executable on the host"
+
+post_install() {
+	vsconf config.toml
+}

Re: New package: shellcaster-1.0.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683145320

Comment:
See #23972 , `ncurses-rs` is a bad dependency.

Re: New package: shellcaster-1.0.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683160053

Comment:
Exactly, not cross-friendly at all. That's why I eventually went for nocross.

Re: New package: shellcaster-1.0.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683166777

Comment:
It's also arch restricted, due to their incorrect usage of signed/unsigned chars.

Re: New package: shellcaster-1.0.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683183747

Comment:
So basically `archs="i686* x86_64*"`?

Re: [WIP] New package: shellcaster-1.0.1

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683347547

Comment:
A better construct here is:

```
case "${XBPS_TARGET_ARCH}" in
    somearch) broken="blah" ;;
    *) ;;
esac
```
because archs is meant to be used for packages that explicitly only support particular archs, this is unintended breakage.

Re: [WIP] New package: shellcaster-1.0.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683364134

Comment:
I'm not sure I agree, because `ncurses-rs` is supposedly kinda dead iirc, so it won't ever not be `broken`.

Re: [WIP] New package: shellcaster-1.0.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683364134

Comment:
I'm not sure I agree, because `ncurses-rs` is supposedly kinda dead iirc, so it won't ever not be `broken`.

There is, however, a chance that upstream changes the dependency they are using, so I guess `broken` could work just as well.

Re: [WIP] New package: shellcaster-1.0.1

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683372769

Comment:
I see it as an unintended consequence by the maintainer of shellcaster.

If we were packaging `ncurses-rs` `archs` would be the right thing to do but I don't think it is here.

Re: [WIP] New package: shellcaster-1.0.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683413914

Comment:
Well, given the fact that the dependency `ncurses-rs` is quite troublesome and their upstream seems kinda inactive, I'm probably dropping this pr.

Re: [WIP] New package: shellcaster-1.0.1

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-683483755

Comment:
Nah, keep it open, I'm working on something for `ncurses-rs`. I like this application, TBH

Re: [WIP] New package: shellcaster-1.0.1

[kotajacob]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

New comment by kotajacob on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-736062142

Comment:
Hey I also use this and would be happy to see it packaged. I opened a [ticket](https://github.com/jeff-hughes/shellcaster/issues/27) on shellcaster to make the author aware of the issue. Also it seems like shellcaster uses pancurses which uses ncurses-rs. Both projects haven't been updated since 2019 so if ncurses-rs gets forked pancurses will probably also need to be forked.

I looked into #23972 and it seems like upstream dijo switched out their pancurses dep for termion.

Re: [WIP] New package: shellcaster-1.0.1

[jeff-hughes]

[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]

New comment by jeff-hughes on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-737464650

Comment:
Hi there -- shellcaster maintainer here. I'd love to make it available for Void Linux and for ARM as well. Yes, in hindsight relying on `pancurses` and `ncurses-rs` was a bad idea; I didn't notice that the projects are not very active. Long-term I may try to move to `termion` instead to remove the ncurses dependency, but that would require a fairly large rewrite.

Forking the `ncurses-rs` library to merge the [open PR for building on arm64](https://github.com/jeaye/ncurses-rs/pull/194/commits) would be an option, and I'm happy to jump to this dependency as long as it doesn't impact building on x86. However, to publish shellcaster on crates.io (which allows for easy installation with `cargo install shellcaster`), all the deps need to be on crates.io as well. I don't feel comfortable becoming the maintainer of a forked ARM-compatible `ncurses-rs`/`pancurses` library on crates.io if I don't even have an ARM device myself to test things on. If there is someone willing to do that, that would be great, and I'd happily switch dependencies.

The other option is that I can add a [git dependency](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations) in my Cargo.toml, which will mean it will build `ncurses-rs` from the crates.io version when installing from crates.io, and build it from the Github repo when compiled from source. It's a little bit of a hack, but if I end up being the one forking those projects, that's ideal for me, as it doesn't set me up as some sort of "official" ncurses fork -- the scope is restricted to shellcaster.

Anyway, I wanted to check in here to figure out what would work best. Thanks, @kotajacob, for letting me know this existed. @fosslinux, you mention you're doing something with `ncurses-rs` -- what does that entail? If it's something I can help with in some way, I'd be happy to.

Re: [WIP] New package: shellcaster-1.0.1

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24525#issuecomment-737521528

Comment:
I haven't been able to do very much work on that yet, but it would basically involve adding a `ncurses-rs` `build_helper` so it patches `ncurses-rs`.

Re: [PR PATCH] [Closed]: [WIP] New package: shellcaster-1.0.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There's a closed pull request on the void-packages repository

[WIP] New package: shellcaster-1.0.1
https://github.com/void-linux/void-packages/pull/24525

Description:
Terminal-based podcast manager built in Rust

https://github.com/jeff-hughes/shellcaster

Unfortunately nocross because ncurses-rs's build.rs tries to run a target executable on the host.