Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-typed-ast: update to 1.4.3.
@ 2021-07-11 12:37 paper42
  2021-07-12  6:05 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: paper42 @ 2021-07-11 12:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages python3-typed-ast-1.4.3
https://github.com/void-linux/void-packages/pull/31907

python3-typed-ast: update to 1.4.3.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31907.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-typed-ast-1.4.3-31907.patch --]
[-- Type: text/x-diff, Size: 2100 bytes --]

From 13398457b1c68eb14c94eb5b6e0878d13c5f8fd4 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 14:02:11 +0200
Subject: [PATCH] python3-typed-ast: update to 1.4.3.

---
 srcpkgs/python3-typed-ast/template | 33 ++++++------------------------
 1 file changed, 6 insertions(+), 27 deletions(-)

diff --git a/srcpkgs/python3-typed-ast/template b/srcpkgs/python3-typed-ast/template
index 8461f830a8cb..1e5bbf1d855f 100644
--- a/srcpkgs/python3-typed-ast/template
+++ b/srcpkgs/python3-typed-ast/template
@@ -1,40 +1,19 @@
 # Template file for 'python3-typed-ast'
 pkgname=python3-typed-ast
-version=1.4.2
+version=1.4.3
 revision=1
 wrksrc="typed_ast-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="python3-devel"
-short_desc="Ast module with type comment support"
+checkdepends="python3-pytest"
+short_desc="AST module with type comment support"
 maintainer="whoami <whoami@systemli.org>"
 license="Apache-2.0"
 homepage="https://github.com/python/typed_ast"
 distfiles="https://github.com/python/typed_ast/archive/${version}.tar.gz"
-checksum=be4b75ea880768489e30818267cf920027ed99014001ac428aedd0b31bbfc899
+checksum=c393d5576856f50189e741c38850e529f38aeb77fd7b40d2d9b1f4340e802faa
 
-do_patch() {
-	# python3-typed-ast uses the same header name with Python
-	# Thus, we'll run to problem on cross-compile.
-	# Fix it by specify include file relative to the file.
-	# And -Iast/Include
-	local _ifile _rfile
-	local _ast27_re=""
-	local _ast3_re=""
-	cd ast27/Include
-	for _ifile in *.h; do
-		_rfile=${_ifile/./[.]}
-		_ast27_re+="s%^[[:space:]]*#[[:space:]]*include[[:space:]]*\"$_rfile\".*$%#include \"../Include/$_ifile\"%;"
-	done
-	cd ..
-	find . -type f -exec sed -i -e "$_ast27_re" {} +
-	cd ..
-	cd ast3/Include
-	for _ifile in *.h; do
-		_rfile=${_ifile/./[.]}
-		_ast3_re+="s%^[[:space:]]*#[[:space:]]*include[[:space:]]*\"$_rfile\".*$%#include \"../Include/$_ifile\"%;"
-	done
-	cd ..
-	find . -type f -exec sed -i -e "$_ast3_re" {} +
-	cd ..
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" pytest
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] python3-typed-ast: update to 1.4.3.
  2021-07-11 12:37 [PR PATCH] python3-typed-ast: update to 1.4.3 paper42
@ 2021-07-12  6:05 ` ericonr
  2021-07-12 20:37 ` paper42
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-07-12  6:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31907#discussion_r667647336

Comment:
Can you include a comment on the commit message explaining what changed that this is no longer necessary? Even understanding the function isn't exactly simple :p

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] python3-typed-ast: update to 1.4.3.
  2021-07-11 12:37 [PR PATCH] python3-typed-ast: update to 1.4.3 paper42
  2021-07-12  6:05 ` [PR REVIEW] " ericonr
@ 2021-07-12 20:37 ` paper42
  2021-07-12 20:37 ` [PR PATCH] [Updated] " paper42
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-07-12 20:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31907#discussion_r668238722

Comment:
@sgn and @CameronNemo upstreamed the changes in https://github.com/python/typed_ast/commit/43599d6dbf10c923f5fe10d9dc9c182bef9db4b9, I will mention it in the commit message.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] python3-typed-ast: update to 1.4.3.
  2021-07-11 12:37 [PR PATCH] python3-typed-ast: update to 1.4.3 paper42
  2021-07-12  6:05 ` [PR REVIEW] " ericonr
  2021-07-12 20:37 ` paper42
@ 2021-07-12 20:37 ` paper42
  2021-07-12 23:29 ` [PR REVIEW] " sgn
  2021-07-13  1:40 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-07-12 20:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages python3-typed-ast-1.4.3
https://github.com/void-linux/void-packages/pull/31907

python3-typed-ast: update to 1.4.3.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31907.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-typed-ast-1.4.3-31907.patch --]
[-- Type: text/x-diff, Size: 2269 bytes --]

From 01b6b5cdc9fb6348e1470ace207ed9cef8f0880d Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 14:02:11 +0200
Subject: [PATCH] python3-typed-ast: update to 1.4.3.

* remove do_patch(), because the changes were upstreamed
  by sgn and CameronNemo in
https://github.com/python/typed_ast/commit/43599d6dbf10c923f5fe10d9dc9c182bef9db4b9
---
 srcpkgs/python3-typed-ast/template | 33 ++++++------------------------
 1 file changed, 6 insertions(+), 27 deletions(-)

diff --git a/srcpkgs/python3-typed-ast/template b/srcpkgs/python3-typed-ast/template
index 8461f830a8cb..1e5bbf1d855f 100644
--- a/srcpkgs/python3-typed-ast/template
+++ b/srcpkgs/python3-typed-ast/template
@@ -1,40 +1,19 @@
 # Template file for 'python3-typed-ast'
 pkgname=python3-typed-ast
-version=1.4.2
+version=1.4.3
 revision=1
 wrksrc="typed_ast-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="python3-devel"
-short_desc="Ast module with type comment support"
+checkdepends="python3-pytest"
+short_desc="AST module with type comment support"
 maintainer="whoami <whoami@systemli.org>"
 license="Apache-2.0"
 homepage="https://github.com/python/typed_ast"
 distfiles="https://github.com/python/typed_ast/archive/${version}.tar.gz"
-checksum=be4b75ea880768489e30818267cf920027ed99014001ac428aedd0b31bbfc899
+checksum=c393d5576856f50189e741c38850e529f38aeb77fd7b40d2d9b1f4340e802faa
 
-do_patch() {
-	# python3-typed-ast uses the same header name with Python
-	# Thus, we'll run to problem on cross-compile.
-	# Fix it by specify include file relative to the file.
-	# And -Iast/Include
-	local _ifile _rfile
-	local _ast27_re=""
-	local _ast3_re=""
-	cd ast27/Include
-	for _ifile in *.h; do
-		_rfile=${_ifile/./[.]}
-		_ast27_re+="s%^[[:space:]]*#[[:space:]]*include[[:space:]]*\"$_rfile\".*$%#include \"../Include/$_ifile\"%;"
-	done
-	cd ..
-	find . -type f -exec sed -i -e "$_ast27_re" {} +
-	cd ..
-	cd ast3/Include
-	for _ifile in *.h; do
-		_rfile=${_ifile/./[.]}
-		_ast3_re+="s%^[[:space:]]*#[[:space:]]*include[[:space:]]*\"$_rfile\".*$%#include \"../Include/$_ifile\"%;"
-	done
-	cd ..
-	find . -type f -exec sed -i -e "$_ast3_re" {} +
-	cd ..
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" pytest
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] python3-typed-ast: update to 1.4.3.
  2021-07-11 12:37 [PR PATCH] python3-typed-ast: update to 1.4.3 paper42
                   ` (2 preceding siblings ...)
  2021-07-12 20:37 ` [PR PATCH] [Updated] " paper42
@ 2021-07-12 23:29 ` sgn
  2021-07-13  1:40 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2021-07-12 23:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31907#discussion_r668322412

Comment:
Yes, upstreamed

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: python3-typed-ast: update to 1.4.3.
  2021-07-11 12:37 [PR PATCH] python3-typed-ast: update to 1.4.3 paper42
                   ` (3 preceding siblings ...)
  2021-07-12 23:29 ` [PR REVIEW] " sgn
@ 2021-07-13  1:40 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-07-13  1:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

There's a merged pull request on the void-packages repository

python3-typed-ast: update to 1.4.3.
https://github.com/void-linux/void-packages/pull/31907

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-13  1:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-11 12:37 [PR PATCH] python3-typed-ast: update to 1.4.3 paper42
2021-07-12  6:05 ` [PR REVIEW] " ericonr
2021-07-12 20:37 ` paper42
2021-07-12 20:37 ` [PR PATCH] [Updated] " paper42
2021-07-12 23:29 ` [PR REVIEW] " sgn
2021-07-13  1:40 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).