Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: New package: dosbox-staging-0.77.0
Date: Sat, 17 Jul 2021 04:15:32 +0200	[thread overview]
Message-ID: <20210717021532.uaNKMXJvSB90sEMes02_6usdLOp7bHMBgXfL7lFnoYg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31258@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]

There's a merged pull request on the void-packages repository

New package: dosbox-staging-0.77.0
https://github.com/void-linux/void-packages/pull/31258

Description:
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

This is a draft based on a current git snapshot, because DOSBox Staging 0.77.0 has not been released yet.

@kcgen wrote (https://github.com/joshuakraemer/void-packages/commit/2d0e6a7ee8328c8210c8ed272dc38dd8317296ff#commitcomment-51084600):
> @joshuakraemer, looks good!
> 
> I realize this is using the `master` branch right now until we can wrap up 0.77. In the meantime, regarding: `-Duse_mt32emu=false`, can you try removing that? Meson should be able to build it internally based on its wrap. There should be no copyright concerns, as users must provide their own ROMs for this feature.

Thank you for your comments. I have added libmt32emu as a separate package, and successfully tested MT-32 emulation.

> Also, there might be more configuration options needed to ensure an optimized binary is built. Here's what I use:
> 
> ```shell
> -Dbuildtype=release \
> -Dc_args=-Ofast \
> -Dcpp_args=-Ofast \
> -Db_asneeded=true -Dstrip=true \
> -Ddefault_library=static \
> -Dfluidsynth:enable-floats=true \
> -Dfluidsynth:try-static-deps=true 
> ```
> 
> Perhaps the static settings could be dropped depending on what void Linux prefers.
> I personally want to ensure that FluidSynth is compiled with the same optimization level (and uses our highly stripped down FluidSynth configuration) to ensure good performance on some of my CPU-limited platforms.

Void's build options for meson packages are specified in https://github.com/void-linux/void-packages/blob/master/common/build-style/meson.sh (using -O2 from the CFLAGS environment variable). The enable-floats option could probably be added to Void's FluidSynth package (https://github.com/void-linux/void-packages/blob/master/srcpkgs/fluidsynth/template), but I do not know if it would be a suitable default outside of DosBox.

      parent reply	other threads:[~2021-07-17  2:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  9:48 [PR PATCH] " joshuakraemer
2021-06-02  9:56 ` [PR PATCH] [Updated] " joshuakraemer
2021-06-02 11:51 ` joshuakraemer
2021-06-02 20:03 ` [PR PATCH] [Updated] " joshuakraemer
2021-06-02 21:21 ` kcgen
2021-06-02 21:22 ` kcgen
2021-07-15 20:56 ` [PR PATCH] [Updated] " joshuakraemer
2021-07-15 21:05 ` joshuakraemer
2021-07-16 15:28 ` [PR REVIEW] " ericonr
2021-07-16 15:28 ` ericonr
2021-07-16 15:28 ` ericonr
2021-07-16 15:28 ` ericonr
2021-07-16 17:00 ` [PR PATCH] [Updated] " joshuakraemer
2021-07-16 17:00 ` [PR REVIEW] " joshuakraemer
2021-07-16 17:01 ` joshuakraemer
2021-07-16 17:02 ` joshuakraemer
2021-07-16 17:03 ` joshuakraemer
2021-07-16 17:58 ` ericonr
2021-07-16 18:21 ` [PR PATCH] [Updated] " joshuakraemer
2021-07-16 20:15 ` [PR REVIEW] " ericonr
2021-07-16 20:16 ` ericonr
2021-07-16 20:41 ` [PR PATCH] [Updated] " joshuakraemer
2021-07-16 20:42 ` [PR REVIEW] " joshuakraemer
2021-07-16 20:42 ` joshuakraemer
2021-07-17  2:14 ` [PR PATCH] [Updated] " ericonr
2021-07-17  2:15 ` ericonr
2021-07-17  2:15 ` ericonr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210717021532.uaNKMXJvSB90sEMes02_6usdLOp7bHMBgXfL7lFnoYg@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).