From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: connman: build with --enable-iwd, add build option "nftables", split openconnect plugin, remove runtime dependency on wpa_supplicant
Date: Sat, 17 Jul 2021 05:25:08 +0200 [thread overview]
Message-ID: <20210717032508.V2wHeM8DTtzvXhQYxH-Or9K1BcB9Vc_ARTlIyPTIMok@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31916@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/31916#issuecomment-881809066
Comment:
> > And make it a single commit with both changes too ;)
>
> They are two independent changes, so they should stay in separate commits. Squashing unrelated changes into mega commits is a horrible antipattern that makes commits hard to comprehend.
Save the "anti-pattern" critiques for the classroom. Our policy is not designed to maximize comprehension; it is designed to maximize atomicity and reversibility. If you break something, we need to be able to easily restore the prior state of the package while you figure out what went wrong, not wade through a web of commits to bisect the breakage.
If there is a lot to explain about the changes, use comments or the commit message.
next prev parent reply other threads:[~2021-07-17 3:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 22:29 [PR PATCH] connman: build with --enable-iwd jirutka
2021-07-12 5:33 ` ericonr
2021-07-12 8:31 ` jirutka
2021-07-14 13:48 ` [PR PATCH] [Updated] " jirutka
2021-07-14 13:49 ` connman: build with --enable-iwd, add build option "nftables" ericonr
2021-07-14 13:52 ` jirutka
2021-07-14 22:59 ` [PR PATCH] [Updated] " jirutka
2021-07-15 23:45 ` [PR PATCH] [Updated] connman: build with --enable-iwd, add build option "nftables", split openconnect plugin, remove runtime dependency on wpa_supplicant jirutka
2021-07-15 23:47 ` jirutka
2021-07-16 21:01 ` jirutka
2021-07-17 3:11 ` ericonr
2021-07-17 3:25 ` ahesford [this message]
2021-07-17 3:32 ` abenson
2022-05-25 2:15 ` github-actions
2022-06-09 2:11 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210717032508.V2wHeM8DTtzvXhQYxH-Or9K1BcB9Vc_ARTlIyPTIMok@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).