[PR PATCH] unbound: add logging service

[PR PATCH] unbound: add logging service

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

There is a new pull request by AluminumTank against master on the void-packages repository

https://github.com/AluminumTank/void-packages unbound
https://github.com/void-linux/void-packages/pull/31992

unbound: add logging service
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-unbound-31992.patch --]
[-- Type: text/x-diff, Size: 1103 bytes --]

From 8f054a1be85842170e403215b2ce9ba2ecdd1406 Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@beckmeyer.us>
Date: Thu, 15 Jul 2021 20:25:44 -0400
Subject: [PATCH] unbound: add logging service

---
 srcpkgs/unbound/files/unbound/log/run | 1 +
 srcpkgs/unbound/template              | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/unbound/files/unbound/log/run

diff --git a/srcpkgs/unbound/files/unbound/log/run b/srcpkgs/unbound/files/unbound/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/unbound/files/unbound/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/unbound/template b/srcpkgs/unbound/template
index 8cf9156a3c81..505e79f487ca 100644
--- a/srcpkgs/unbound/template
+++ b/srcpkgs/unbound/template
@@ -1,7 +1,7 @@
 # Template file for 'unbound'
 pkgname=unbound
 version=1.13.1
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--with-libevent --with-conf-file=/etc/unbound/unbound.conf
  --with-pidfile=/run/unbound.pid --with-ssl=${XBPS_CROSS_BASE}/usr

Re: unbound: add logging service

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881805974

Comment:
@leahneukirchen LGTM

Re: unbound: add logging service

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881886174

Comment:
no `-t unbound`?

Re: unbound: add logging service

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881886235

Comment:
ah it autodetects that, fine.

Re: unbound: add logging service

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881886386

Comment:
But `log/supervise` is missing, no?

Re: unbound: add logging service

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by AluminumTank on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881903069

Comment:
That's automatically created by `sv` at runtime. I don't think it's supposed to be included in the package.

Re: unbound: add logging service

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New comment by AluminumTank on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881903376

Comment:
If  you're trying to install and run this on your machine with unbound already installed and service enabled, you'll have to manually enable the log service, or just unlink and relink to `/var/service/unbound`

Re: unbound: add logging service

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881946914

Comment:
> That's automatically created by sv at runtime. I don't think it's supposed to be included in the package.

No `runsv` creates the directory, not the symlink. It would just create a directory in the service directory if the symlink is missing.
`vsv` in xbps-src should create both supervise symlinks,  but for some reason it does not do in the CI run.
https://github.com/void-linux/void-packages/runs/3082099002#step:9:66

Re: unbound: add logging service

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-881946914

Comment:
> That's automatically created by sv at runtime. I don't think it's supposed to be included in the package.

No `runsv` creates the directory, not the symlink. It would just create a directory in the service directory if the symlink is missing.
`vsv` in xbps-src should create both supervise symlinks,  but for some reason it does not do in the CI run.
https://github.com/void-linux/void-packages/runs/3082099002#step:9:67

Re: unbound: add logging service

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-883621997

Comment:
So, is this actually necessary? I get unbound information just fine in `svlogtail` output without a `log` service...

Re: unbound: add logging service

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

New comment by AluminumTank on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-883632182

Comment:
Huh, you're right. I think I got confused when I was trying to enable logging within unbound because I copied a config from somewhere which didn't have the `use-syslog: true` directive. I'll close then, thanks for the tip.

As an aside, the issue about `log/supervise` missing may be related to `log/run` being a symlink to `/usr/bin/vlogger` since I checked several other services in void-packages using this symlink (`bluez`, dhcp`, `caddy`) and none of them have `log/supervise` either. Not sure if this is intended behavior or not...

Re: [PR PATCH] [Closed]: unbound: add logging service

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

There's a closed pull request on the void-packages repository

unbound: add logging service
https://github.com/void-linux/void-packages/pull/31992

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: unbound: add logging service

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

New comment by AluminumTank on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-883632182

Comment:
Huh, you're right. I think I got confused when I was trying to enable logging within unbound because I copied a config from somewhere which didn't have the `use-syslog: true` directive. I'll close then, thanks for the tip.

As an aside, the issue about `log/supervise` missing may be related to `log/run` being a symlink to `/usr/bin/vlogger` since I checked several other services in void-packages using this symlink (`bluez`, `dhcp`, `caddy`) and none of them have `log/supervise` either. Not sure if this is intended behavior or not...

Re: unbound: add logging service

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31992#issuecomment-883638589

Comment:
> Not sure if this is intended behavior or not...

I don't think so. Can you open an issue so we can remember to try and fix it?