Re: [PR PATCH] [Updated] add patch to prevent libserialport from using termiox, which has been removed from recent kernels

[PoroCYon <PoroCYon@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]

There is an updated pull request by PoroCYon against master on the void-packages repository

https://github.com/PoroCYon/void-packages patch-libsigrok-notermiox
https://github.com/void-linux/void-packages/pull/32025

add patch to prevent libserialport from using termiox, which has been removed from recent kernels
Without this patch, libserialport will fail opening a tty device with an "No such ioctl for device"-error. This prevents eg. sigrok/pulseview from working with a SUMP-compatible logic analyzer.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-libsigrok-notermiox-32025.patch --]
[-- Type: text/x-diff, Size: 1959 bytes --]

From 87be8293964e372f620996929dca7b007efc159d Mon Sep 17 00:00:00 2001
From: PoroCYon <porocyon@titandemo.org>
Date: Sat, 17 Jul 2021 22:11:09 +0200
Subject: [PATCH] add patch so libserialport doesn't use termiox

termios has been removed from recent kernels, so not having this patch
causes "no such ioctl for device"-errors, preventing any use of the
library
---
 ...-as-it-has-been-removed-from-recent-ke.patch | 17 +++++++++++++++++
 srcpkgs/libserialport/template                  |  2 +-
 2 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libserialport/patches/0001-Remove-termiox-as-it-has-been-removed-from-recent-ke.patch

diff --git a/srcpkgs/libserialport/patches/0001-Remove-termiox-as-it-has-been-removed-from-recent-ke.patch b/srcpkgs/libserialport/patches/0001-Remove-termiox-as-it-has-been-removed-from-recent-ke.patch
new file mode 100644
index 000000000000..9f43ccbf57f7
--- /dev/null
+++ b/srcpkgs/libserialport/patches/0001-Remove-termiox-as-it-has-been-removed-from-recent-ke.patch
@@ -0,0 +1,17 @@
+diff --git a/libserialport_internal.h b/libserialport_internal.new.h
+index 669152b..9a57b81 100644
+--- libserialport_internal.h
++++ libserialport_internal.h
+@@ -69,11 +69,6 @@
+ #include "linux/serial.h"
+ #endif
+ #include "linux_termios.h"
+-
+-/* TCGETX/TCSETX is not available everywhere. */
+-#if defined(TCGETX) && defined(TCSETX) && defined(HAVE_STRUCT_TERMIOX)
+-#define USE_TERMIOX
+-#endif
+ #endif
+ 
+ /* TIOCINQ/TIOCOUTQ is not available everywhere. */
+
diff --git a/srcpkgs/libserialport/template b/srcpkgs/libserialport/template
index 23b6b92a42fe..7d1cdd3c7631 100644
--- a/srcpkgs/libserialport/template
+++ b/srcpkgs/libserialport/template
@@ -1,7 +1,7 @@
 # Template file for 'libserialport'
 pkgname=libserialport
 version=0.1.1
-revision=2
+revision=3
 build_style=gnu-configure
 short_desc="Cross-platform library for accessing serial ports"
 maintainer="lemmi <lemmi@nerd2nerd.org>"