Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] apparmor: add missing dependencies
@ 2021-07-20 12:47 paper42
  2021-07-20 14:16 ` paper42
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: paper42 @ 2021-07-20 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages apparmor-missing-deps
https://github.com/void-linux/void-packages/pull/32055

apparmor: add missing dependencies
* python3-dbus is needed for aa-notify, closes #32052
* ss from iproute2 is needed for aa-unconfined

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32055.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apparmor-missing-deps-32055.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]

From 4682c6d53caf94d29237da97b6658d500e423dd0 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Tue, 20 Jul 2021 14:42:26 +0200
Subject: [PATCH] apparmor: add missing dependencies

* python3-dbus is needed for aa-notify, closes #32052
* ss from iproute2 is needed for aa-unconfined
---
 srcpkgs/apparmor/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/apparmor/template b/srcpkgs/apparmor/template
index ea2611c2443d..ca93227d8909 100644
--- a/srcpkgs/apparmor/template
+++ b/srcpkgs/apparmor/template
@@ -1,7 +1,7 @@
 # Template file for 'apparmor'
 pkgname=apparmor
 version=3.0.1
-revision=5
+revision=6
 wrksrc="${pkgname}-v${version}"
 build_wrksrc=libraries/libapparmor
 build_style=gnu-configure
@@ -9,7 +9,8 @@ conf_files="/etc/apparmor.d/local/* /etc/apparmor/*"
 make_dirs="/etc/apparmor.d/disable 0755 root root"
 hostmakedepends="bison flex autoconf automake libtool gettext swig python3 which"
 makedepends="perl python3-devel"
-depends="runit-void-apparmor libapparmor-${version}_${revision} python3-notify2 python3-psutil"
+depends="runit-void-apparmor libapparmor-${version}_${revision} python3-notify2
+ python3-psutil python3-dbus iproute2"
 checkdepends="dejagnu"
 short_desc="Mandatory access control to restrict programs"
 maintainer="Olivier Mauras <olivier@mauras.ch>"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: apparmor: add missing dependencies
  2021-07-20 12:47 [PR PATCH] apparmor: add missing dependencies paper42
@ 2021-07-20 14:16 ` paper42
  2021-07-20 14:40 ` ericonr
  2021-07-20 14:40 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: paper42 @ 2021-07-20 14:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32055#issuecomment-883430839

Comment:
It seems like python3-notify2 (a different dependency of the apparmor package) should depend on python3-dbus too (#32068), but I would prefer to explicitly list the dependency here, because aa-notify imports python3-dbus (it's a direct dependency) and python3-notify2 is deprecated, so the dependency might disappear soon.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: apparmor: add missing dependencies
  2021-07-20 12:47 [PR PATCH] apparmor: add missing dependencies paper42
  2021-07-20 14:16 ` paper42
@ 2021-07-20 14:40 ` ericonr
  2021-07-20 14:40 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-07-20 14:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32055#issuecomment-883448510

Comment:
Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: apparmor: add missing dependencies
  2021-07-20 12:47 [PR PATCH] apparmor: add missing dependencies paper42
  2021-07-20 14:16 ` paper42
  2021-07-20 14:40 ` ericonr
@ 2021-07-20 14:40 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-07-20 14:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

There's a merged pull request on the void-packages repository

apparmor: add missing dependencies
https://github.com/void-linux/void-packages/pull/32055

Description:
* python3-dbus is needed for aa-notify, closes #32052
* ss from iproute2 is needed for aa-unconfined

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-20 14:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 12:47 [PR PATCH] apparmor: add missing dependencies paper42
2021-07-20 14:16 ` paper42
2021-07-20 14:40 ` ericonr
2021-07-20 14:40 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).