Github messages for voidlinux
 help / color / mirror / Atom feed
From: mobinmob <mobinmob@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: xournalpp: update to 1.1.0.
Date: Tue, 20 Jul 2021 19:07:38 +0200	[thread overview]
Message-ID: <20210720170738.3O46Xpss6946VaHn9gB06M4FLPaTbxGZP_F-4nIBYcM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32045@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/32045#issuecomment-883554081

Comment:
> Sorry, my bad for not checking before doing my PR.
> 

No problem - your changes make the package better without a doubt.

> Comments on the current PR:
> 
> * Can we enable plugins? It's just a matter of adding `lua53-devel` to `makedepends`.

The only reason that plugins are not enabled is that... I do not use any :P Ι have no problem enabling them, lua is not a problematic dependency. Thank you for the suggestion.

> * I'd really like to include the (very simple) patch I included to load user plugins, please?

I am all for it. I maintain a package that needs plugins to be in a system directory and I really hate that.

> * I understand the reasons for the change from `virtual?tex` to `texlive-latexextra`. However, I'm still using `texlive-bin` because of [texdoc doesn't work / texlive documentation missing #30340](https://github.com/void-linux/void-packages/issues/30340) which is a serious blocker for my (quite heavy) usage of TeX.

I was not aware of https://github.com/void-linux/void-packages/issues/30340 . That is a big problem indeed :(

> * OTOH, latex is not really necessary to use Xournal++ so maybe the best choice is to _not_ depend on it at all. In my box installing `xournalpp` requires 5MB of disk, while installing `texlive-latexextra` requires 500MB. I use xournalpp every day to teach and write notes and it's a nice feature but completely optional.

It is not necessary - maybe I can propose the necessary packages in the INSTALL.msg.

  parent reply	other threads:[~2021-07-20 17:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 17:57 [PR PATCH] " mobinmob
2021-07-20 14:44 ` ericonr
2021-07-20 16:53 ` tornaria
2021-07-20 17:07 ` mobinmob [this message]
2021-07-20 17:48 ` [PR PATCH] [Updated] " mobinmob
2021-07-20 17:51 ` mobinmob
2021-07-20 18:00 ` tornaria
2021-07-20 18:03 ` [PR PATCH] [Updated] " mobinmob
2021-07-20 18:12 ` [PR REVIEW] " ahesford
2021-07-20 19:08 ` [PR PATCH] [Updated] " mobinmob
2021-07-20 19:09 ` mobinmob
2021-07-20 19:09 ` [PR REVIEW] " mobinmob
2021-07-20 19:31 ` [PR PATCH] [Merged]: " ericonr
2021-07-19 23:28 [PR PATCH] " tornaria
2021-07-20 13:18 ` tornaria
2021-07-20 14:45 ` ericonr
2021-07-20 18:00 ` tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210720170738.3O46Xpss6946VaHn9gB06M4FLPaTbxGZP_F-4nIBYcM@z \
    --to=mobinmob@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).