From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: OpenRCT2: update to 0.3.4, enable tests
Date: Tue, 20 Jul 2021 21:01:27 +0200 [thread overview]
Message-ID: <20210720190127.RJ6CXYuMwIkHrQBfywCX-npR4m-A7SKiHPIyjMNCSQc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32050@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
There's a merged pull request on the void-packages repository
OpenRCT2: update to 0.3.4, enable tests
https://github.com/void-linux/void-packages/pull/32050
Description:
In the last version, a few of the tests were broken, so I hadn't put in the plumbing for the check step yet. Now the tests all pass, so that's cool.
Also, I removed `/usr/lib/libopenrct2.a`, which only exists to be linked into `openrct2` and `openrct2-cli` and shouldn't have been included in the package itself. (It can also be built as a shared object, but again it's only used to share code between the two binaries, and I'm not going to try to reconcile that with Void policy over 10M of duplicated code.)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
prev parent reply other threads:[~2021-07-20 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 4:24 [PR PATCH] " Skirmisher
2021-07-20 4:30 ` [PR PATCH] [Updated] " Skirmisher
2021-07-20 15:24 ` [PR REVIEW] " ericonr
2021-07-20 15:24 ` ericonr
2021-07-20 18:15 ` [PR PATCH] [Updated] " Skirmisher
2021-07-20 18:19 ` Skirmisher
2021-07-20 18:26 ` Skirmisher
2021-07-20 19:01 ` ericonr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720190127.RJ6CXYuMwIkHrQBfywCX-npR4m-A7SKiHPIyjMNCSQc@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).