Re: [PR REVIEW] New package: kiten-20.04.2

Re: [PR REVIEW] New package: kiten-20.04.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#discussion_r452329376

Comment:
This line is too long, please wrap at 72 characters.

Re: [PR REVIEW] New package: kiten-20.04.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#discussion_r452329117

Comment:
`khtml` should be auto-detected.

Re: [PR REVIEW] New package: kiten-20.04.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#discussion_r452329799

Comment:
indent with TAB, and move after the below `if`

Re: [PR REVIEW] New package: kiten-20.04.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#discussion_r452330184

Comment:
I'll just merge this with above `hostmakedepends` regardless of `$CROSS_BUILD`

Re: New package: kiten-20.04.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#issuecomment-656218193

Comment:
Also, the cross stuff is broken ;)

Re: [PR PATCH] [Updated] New package: kiten-20.04.2

[likrtr]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is an updated pull request by likrtr against master on the void-packages repository

https://github.com/likrtr/void-packages master
https://github.com/void-linux/void-packages/pull/23096

New package: kiten-20.04.2


A patch file from https://github.com/void-linux/void-packages/pull/23096.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23096.patch --]
[-- Type: text/x-diff, Size: 1464 bytes --]

From 381a9badfedb2dfb955d69f385501d1915af6984 Mon Sep 17 00:00:00 2001
From: basketdou <basketdou@gmail.com>
Date: Sat, 20 Jun 2020 20:53:19 +0500
Subject: [PATCH] New package: kiten-20.04.2

---
 srcpkgs/kiten/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/kiten/template

diff --git a/srcpkgs/kiten/template b/srcpkgs/kiten/template
new file mode 100644
index 00000000000..6e3adac696c
--- /dev/null
+++ b/srcpkgs/kiten/template
@@ -0,0 +1,24 @@
+# Template file for 'kiten'
+pkgname=kiten
+version=20.04.2
+revision=1
+build_style=cmake
+configure_args="-DBUILD_TESTING=OFF"
+hostmakedepends="extra-cmake-modules pkg-config gettext"
+makedepends="qt5-devel qt5-declarative qt5-declarative-devel
+khtml-devel ki18n-devel knotifications-devel kdoctools-devel kxmlgui-devel karchive-devel kcoreaddons-devel kcompletion-devel kconfig-devel kconfigwidgets-devel gettext-devel kcrash-devel"
+depends="khtml hicolor-icon-theme"
+short_desc="Japanese Reference/Study Tool"
+maintainer="basketdou <basketdou@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://kde.org/applications/education/org.kde.kiten"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum=c5d002ba2ee4a11913457808da67f9c7ee5dbcf1731fad11842a4aa338862c82
+
+pre_check() {
+export QT_QPA_PLATFORM=offscreen
+}
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" python3 qt5-host-tools qt5-qmake"
+fi

Re: [PR PATCH] [Updated] New package: kiten-20.04.2

[likrtr]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is an updated pull request by likrtr against master on the void-packages repository

https://github.com/likrtr/void-packages master
https://github.com/void-linux/void-packages/pull/23096

New package: kiten-20.04.2


A patch file from https://github.com/void-linux/void-packages/pull/23096.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23096.patch --]
[-- Type: text/x-diff, Size: 1464 bytes --]

From 381a9badfedb2dfb955d69f385501d1915af6984 Mon Sep 17 00:00:00 2001
From: basketdou <basketdou@gmail.com>
Date: Sat, 20 Jun 2020 20:53:19 +0500
Subject: [PATCH] New package: kiten-20.04.2

---
 srcpkgs/kiten/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/kiten/template

diff --git a/srcpkgs/kiten/template b/srcpkgs/kiten/template
new file mode 100644
index 00000000000..6e3adac696c
--- /dev/null
+++ b/srcpkgs/kiten/template
@@ -0,0 +1,24 @@
+# Template file for 'kiten'
+pkgname=kiten
+version=20.04.2
+revision=1
+build_style=cmake
+configure_args="-DBUILD_TESTING=OFF"
+hostmakedepends="extra-cmake-modules pkg-config gettext"
+makedepends="qt5-devel qt5-declarative qt5-declarative-devel
+khtml-devel ki18n-devel knotifications-devel kdoctools-devel kxmlgui-devel karchive-devel kcoreaddons-devel kcompletion-devel kconfig-devel kconfigwidgets-devel gettext-devel kcrash-devel"
+depends="khtml hicolor-icon-theme"
+short_desc="Japanese Reference/Study Tool"
+maintainer="basketdou <basketdou@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://kde.org/applications/education/org.kde.kiten"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum=c5d002ba2ee4a11913457808da67f9c7ee5dbcf1731fad11842a4aa338862c82
+
+pre_check() {
+export QT_QPA_PLATFORM=offscreen
+}
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" python3 qt5-host-tools qt5-qmake"
+fi

Re: [PR PATCH] [Updated] New package: kiten-20.04.2

[likrtr]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is an updated pull request by likrtr against master on the void-packages repository

https://github.com/likrtr/void-packages master
https://github.com/void-linux/void-packages/pull/23096

New package: kiten-20.04.2


A patch file from https://github.com/void-linux/void-packages/pull/23096.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23096.patch --]
[-- Type: text/x-diff, Size: 1464 bytes --]

From 381a9badfedb2dfb955d69f385501d1915af6984 Mon Sep 17 00:00:00 2001
From: basketdou <basketdou@gmail.com>
Date: Sat, 20 Jun 2020 20:53:19 +0500
Subject: [PATCH] New package: kiten-20.04.2

---
 srcpkgs/kiten/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/kiten/template

diff --git a/srcpkgs/kiten/template b/srcpkgs/kiten/template
new file mode 100644
index 00000000000..6e3adac696c
--- /dev/null
+++ b/srcpkgs/kiten/template
@@ -0,0 +1,24 @@
+# Template file for 'kiten'
+pkgname=kiten
+version=20.04.2
+revision=1
+build_style=cmake
+configure_args="-DBUILD_TESTING=OFF"
+hostmakedepends="extra-cmake-modules pkg-config gettext"
+makedepends="qt5-devel qt5-declarative qt5-declarative-devel
+khtml-devel ki18n-devel knotifications-devel kdoctools-devel kxmlgui-devel karchive-devel kcoreaddons-devel kcompletion-devel kconfig-devel kconfigwidgets-devel gettext-devel kcrash-devel"
+depends="khtml hicolor-icon-theme"
+short_desc="Japanese Reference/Study Tool"
+maintainer="basketdou <basketdou@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://kde.org/applications/education/org.kde.kiten"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum=c5d002ba2ee4a11913457808da67f9c7ee5dbcf1731fad11842a4aa338862c82
+
+pre_check() {
+export QT_QPA_PLATFORM=offscreen
+}
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" python3 qt5-host-tools qt5-qmake"
+fi

Re: New package: kiten-20.04.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#issuecomment-883653471

Comment:
Ping? I think this package could be merged, once suggestions are applied.

Re: New package: kiten-20.04.2

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/23096#issuecomment-1100787046

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: kiten-20.04.2

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

There's a closed pull request on the void-packages repository

New package: kiten-20.04.2
https://github.com/void-linux/void-packages/pull/23096

Description: