Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pipewire: update to 0.3.32
@ 2021-07-20 14:36 st3r4g
  2021-07-20 14:53 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: st3r4g @ 2021-07-20 14:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

There is a new pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.32
https://github.com/void-linux/void-packages/pull/32069

pipewire: update to 0.3.32
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32069.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.32-32069.patch --]
[-- Type: text/x-diff, Size: 1170 bytes --]

From 0a98753fb13e7954668ae2158e343dd1df1715af Mon Sep 17 00:00:00 2001
From: Stefano Ragni <stefano.ragni@outlook.com>
Date: Tue, 20 Jul 2021 16:36:10 +0200
Subject: [PATCH] pipewire: update to 0.3.32

---
 srcpkgs/pipewire/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 6bf7f6f0a914..b61c6a74e63e 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.31
+version=0.3.32
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=2fec0eb47dbfcad51fb8bb3d59c26fe57e09204d63c9d2776070dbdc08aaaaae
+checksum=8b2af6138529fd9214dd148f2a6304f13c16e0b0d3a4a98c1afa87b7e65c574f
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pipewire: update to 0.3.32
  2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
@ 2021-07-20 14:53 ` ericonr
  2021-07-20 14:54 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-07-20 14:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32069#issuecomment-883458069

Comment:
```
[353/592] Compiling C object src/modules/libpipewire-module-rtkit.so.p/module-rtkit.c.o
../src/modules/module-rtkit.c: In function '_gettid':
../src/modules/module-rtkit.c:186:17: warning: implicit declaration of function 'gettid'; did you mean '_gettid'? [-Wimplicit-function-declaration]
  186 |  return (pid_t) gettid();
      |                 ^~~~~~
      |                 _gettid
```

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pipewire: update to 0.3.32
  2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
  2021-07-20 14:53 ` ericonr
@ 2021-07-20 14:54 ` ericonr
  2021-07-20 14:55 ` ericonr
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-07-20 14:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32069#issuecomment-883458813

Comment:
Breaks build on musl; we could do `inline int gettid() { return syscall(SYS_gettid);}`

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pipewire: update to 0.3.32
  2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
  2021-07-20 14:53 ` ericonr
  2021-07-20 14:54 ` ericonr
@ 2021-07-20 14:55 ` ericonr
  2021-07-20 22:09 ` [PR PATCH] [Updated] " st3r4g
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-07-20 14:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32069#issuecomment-883460205

Comment:
Or just the patch in https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1422

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] pipewire: update to 0.3.32
  2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
                   ` (2 preceding siblings ...)
  2021-07-20 14:55 ` ericonr
@ 2021-07-20 22:09 ` st3r4g
  2021-07-20 22:19 ` st3r4g
  2021-07-21  4:12 ` [PR PATCH] [Merged]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: st3r4g @ 2021-07-20 22:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.32
https://github.com/void-linux/void-packages/pull/32069

pipewire: update to 0.3.32
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32069.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.32-32069.patch --]
[-- Type: text/x-diff, Size: 3740 bytes --]

From 09f8ca020e2b301a1d52cbdb09915862d0d87d6c Mon Sep 17 00:00:00 2001
From: Stefano Ragni <stefano.ragni@outlook.com>
Date: Tue, 20 Jul 2021 16:36:10 +0200
Subject: [PATCH] pipewire: update to 0.3.32

---
 srcpkgs/pipewire/patches/gettid.patch | 64 +++++++++++++++++++++++++++
 srcpkgs/pipewire/template             |  4 +-
 2 files changed, 66 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/pipewire/patches/gettid.patch

diff --git a/srcpkgs/pipewire/patches/gettid.patch b/srcpkgs/pipewire/patches/gettid.patch
new file mode 100644
index 000000000000..0911051e1a0c
--- /dev/null
+++ b/srcpkgs/pipewire/patches/gettid.patch
@@ -0,0 +1,64 @@
+From master, will be in 0.3.33
+diff --git a/meson.build b/meson.build
+index 838fb66be8ca0e2d66009696f6c00c2ff7580b6e..977ce9ba1f22a2785efcb1b5a5bee08cf2e4bec3 100644
+--- a/meson.build
++++ b/meson.build
+@@ -254,6 +254,9 @@ endif
+ if cc.has_function('getpagesize', prefix : '#include<unistd.h>')
+   cdata.set('HAVE_GETPAGESIZE', 1)
+ endif
++if cc.has_function('gettid', prefix : '#include<unistd.h>', args: [ '-D_GNU_SOURCE' ])
++  cdata.set('HAVE_GETTID', 1)
++endif
+ if cc.has_function('clock_gettime', prefix : '#include <time.h>')
+   cdata.set('HAVE_CLOCK_GETTIME', 1)
+ endif
+diff --git a/src/modules/module-rtkit.c b/src/modules/module-rtkit.c
+index 1f13aa371192bee738c4e10b45917473d2f9856d..7d55fb758cdc0a3073e3e3f2536949e824ffa223 100644
+--- a/src/modules/module-rtkit.c
++++ b/src/modules/module-rtkit.c
+@@ -182,12 +182,16 @@ void pw_rtkit_bus_free(struct pw_rtkit_bus *system_bus)
+ 
+ static pid_t _gettid(void)
+ {
+-#ifndef __FreeBSD__
++#if defined(HAVE_GETTID)
+ 	return (pid_t) gettid();
+-#else
++#elif defined(__linux__)
++	return syscall(SYS_gettid);
++#elif defined(__FreeBSD__)
+ 	long pid;
+ 	thr_self(&pid);
+ 	return (pid_t)pid;
++#else
++#error "No gettid impl"
+ #endif
+ }
+ 
+diff --git a/src/modules/module-rtkit.c b/src/modules/module-rtkit.c
+index de30f4123cf017f8be2eb7d4cd3bababb51da6fc..419e4be815a46d0f466969a02813f481d48ee5a1 100644
+--- a/src/modules/module-rtkit.c
++++ b/src/modules/module-rtkit.c
+@@ -518,7 +518,7 @@ static void *custom_start(void *data)
+ 	struct impl *impl = this->impl;
+ 
+ 	pthread_mutex_lock(&impl->lock);
+-	this->pid = gettid();
++	this->pid = _gettid();
+ 	pthread_cond_broadcast(&impl->cond);
+ 	pthread_mutex_unlock(&impl->lock);
+ 
+diff --git a/src/modules/module-rtkit.c b/src/modules/module-rtkit.c
+index 419e4be815a46d0f466969a02813f481d48ee5a1..1f13aa371192bee738c4e10b45917473d2f9856d 100644
+--- a/src/modules/module-rtkit.c
++++ b/src/modules/module-rtkit.c
+@@ -592,7 +592,7 @@ static pid_t impl_gettid(struct impl *impl, pthread_t pt)
+ 	if ((thr = find_thread_by_pt(impl, pt)) != NULL)
+ 		pid = thr->pid;
+ 	else
+-		pid = getpid();
++		pid = _gettid();
+ 	pthread_mutex_unlock(&impl->lock);
+ 
+ 	return pid;
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 6bf7f6f0a914..b61c6a74e63e 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.31
+version=0.3.32
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=2fec0eb47dbfcad51fb8bb3d59c26fe57e09204d63c9d2776070dbdc08aaaaae
+checksum=8b2af6138529fd9214dd148f2a6304f13c16e0b0d3a4a98c1afa87b7e65c574f
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pipewire: update to 0.3.32
  2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
                   ` (3 preceding siblings ...)
  2021-07-20 22:09 ` [PR PATCH] [Updated] " st3r4g
@ 2021-07-20 22:19 ` st3r4g
  2021-07-21  4:12 ` [PR PATCH] [Merged]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: st3r4g @ 2021-07-20 22:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/32069#issuecomment-883743931

Comment:
Added your patches, thanks

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: pipewire: update to 0.3.32
  2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
                   ` (4 preceding siblings ...)
  2021-07-20 22:19 ` st3r4g
@ 2021-07-21  4:12 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-07-21  4:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a merged pull request on the void-packages repository

pipewire: update to 0.3.32
https://github.com/void-linux/void-packages/pull/32069

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-07-21  4:12 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 14:36 [PR PATCH] pipewire: update to 0.3.32 st3r4g
2021-07-20 14:53 ` ericonr
2021-07-20 14:54 ` ericonr
2021-07-20 14:55 ` ericonr
2021-07-20 22:09 ` [PR PATCH] [Updated] " st3r4g
2021-07-20 22:19 ` st3r4g
2021-07-21  4:12 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).