Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] explicitly allow setuid and setgid permissions in templates
Date: Fri, 23 Jul 2021 16:35:53 +0200	[thread overview]
Message-ID: <20210723143553.MiuK6MAOvrHRog4M66p17Udk9N7N0u5Gixmv1q16YlE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32156@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/32156#issuecomment-885684104

Comment:
> a) setugid=yes allows both setuid and setgid permissions in all files in the package

I don't think we need/should ship something with a gazillion `s[ug]id` binaries, so I think we should always list them explicitly. And what this allows us to do is also statically check that the permission bits are correct: if something like sudo's `make install` regresses for cross targets (wild example), it will be caught at package build time.

Statically checking `setgid` in Void is not really possible (it has to happen in `INSTALL`), because of how we (at least currently) manage groups. Most of the group usage is `chown root:<group>` then set perms to `4750`. However, again because it happens in `INSTALL`, this breaks static checking.

  reply	other threads:[~2021-07-23 14:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 14:03 [ISSUE] " paper42
2021-07-23 14:35 ` ericonr [this message]
2021-07-26 12:10 ` fosslinux
2021-07-26 13:33 ` paper42
2021-07-26 13:33 ` paper42
2021-07-26 13:33 ` paper42
2021-07-27 16:13 ` Duncaen
2021-07-27 16:13 ` Duncaen
2021-07-27 17:42 ` ericonr
2022-05-30  2:15 ` github-actions
2022-08-17  1:48 ` CameronNemo
2022-08-17  2:43 ` ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723143553.MiuK6MAOvrHRog4M66p17Udk9N7N0u5Gixmv1q16YlE@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).