[PR PATCH] screen: fix launch.

[PR PATCH] screen: fix launch.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages screen
https://github.com/void-linux/void-packages/pull/32159

screen: fix launch.
When screen isn't suid, it can't create the directory under /run/screens
for sessions to sit in. We went with this approach instead of removing
--with-socket-dir so screen would default to using ~/.screen, becaise it
would require users with currently running screen sessions to launch the
screen client with SCREENDIR set correctly.

Since that approach would be more complicated for users and require
leaving an INSTALL.msg in the package for some time, we went with a
simpler one of always creating the directory at build time.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32159.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-screen-32159.patch --]
[-- Type: text/x-diff, Size: 1778 bytes --]

From 4c754cf80e3cd82cdc4aa3844888bb6fd661d292 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Fri, 23 Jul 2021 14:29:30 -0300
Subject: [PATCH] screen: fix launch.

When screen isn't suid, it can't create the directory under /run/screens
for sessions to sit in. We went with this approach instead of removing
--with-socket-dir so screen would default to using ~/.screen, becaise it
would require users with currently running screen sessions to launch the
screen client with SCREENDIR set correctly.

Since that approach would be more complicated for users and require
leaving an INSTALL.msg in the package for some time, we went with a
simpler one of always creating the directory at build time.
---
 srcpkgs/screen/files/20-screen.sh | 1 +
 srcpkgs/screen/template           | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/screen/files/20-screen.sh

diff --git a/srcpkgs/screen/files/20-screen.sh b/srcpkgs/screen/files/20-screen.sh
new file mode 100644
index 000000000000..291db0fbe766
--- /dev/null
+++ b/srcpkgs/screen/files/20-screen.sh
@@ -0,0 +1 @@
+install -dm 1777 /run/screens
diff --git a/srcpkgs/screen/template b/srcpkgs/screen/template
index 4fcf97e83e91..2c25c9c77729 100644
--- a/srcpkgs/screen/template
+++ b/srcpkgs/screen/template
@@ -1,7 +1,7 @@
 # Template file for 'screen'
 pkgname=screen
 version=4.8.0
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-sys-screenrc=/etc/screenrc --enable-pam
  --enable-colors256 --enable-rxvt_osc --enable-telnet
@@ -25,4 +25,6 @@ post_install() {
 	if [ "$build_option_multiuser" ]; then
 		chmod 4755 ${DESTDIR}/usr/bin/screen-${version}
 	fi
+
+	vinstall $FILESDIR/20-screen.sh 644 etc/runit/core-services
 }

Re: [PR PATCH] [Updated] screen: fix launch.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages screen
https://github.com/void-linux/void-packages/pull/32159

screen: fix launch.
When screen isn't suid, it can't create the directory under /run/screens
for sessions to sit in. We went with this approach instead of removing
--with-socket-dir so screen would default to using ~/.screen, becaise it
would require users with currently running screen sessions to launch the
screen client with SCREENDIR set correctly.

Since that approach would be more complicated for users and require
leaving an INSTALL.msg in the package for some time, we went with a
simpler one of always creating the directory at build time.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32159.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-screen-32159.patch --]
[-- Type: text/x-diff, Size: 1653 bytes --]

From 351bbab173b362290a62d4300ed7a074d58bebd9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Fri, 23 Jul 2021 14:29:30 -0300
Subject: [PATCH] screen: fix launch.

When screen isn't suid, it can't create the directory under /run/screens
for sessions to sit in. We went with the approach of creating the
directory at boot time instead of removing --with-socket-dir so screen
would default to using ~/.screen, because it would require users with
currently running screen sessions to launch the screen client with
SCREENDIR set correctly, and an INSTALL.msg to warn users.
---
 srcpkgs/screen/files/20-screen.sh | 1 +
 srcpkgs/screen/template           | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/screen/files/20-screen.sh

diff --git a/srcpkgs/screen/files/20-screen.sh b/srcpkgs/screen/files/20-screen.sh
new file mode 100644
index 000000000000..291db0fbe766
--- /dev/null
+++ b/srcpkgs/screen/files/20-screen.sh
@@ -0,0 +1 @@
+install -dm 1777 /run/screens
diff --git a/srcpkgs/screen/template b/srcpkgs/screen/template
index 4fcf97e83e91..2c25c9c77729 100644
--- a/srcpkgs/screen/template
+++ b/srcpkgs/screen/template
@@ -1,7 +1,7 @@
 # Template file for 'screen'
 pkgname=screen
 version=4.8.0
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-sys-screenrc=/etc/screenrc --enable-pam
  --enable-colors256 --enable-rxvt_osc --enable-telnet
@@ -25,4 +25,6 @@ post_install() {
 	if [ "$build_option_multiuser" ]; then
 		chmod 4755 ${DESTDIR}/usr/bin/screen-${version}
 	fi
+
+	vinstall $FILESDIR/20-screen.sh 644 etc/runit/core-services
 }

Re: [PR PATCH] [Merged]: screen: fix launch.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]

There's a merged pull request on the void-packages repository

screen: fix launch.
https://github.com/void-linux/void-packages/pull/32159

Description:
When screen isn't suid, it can't create the directory under /run/screens
for sessions to sit in. We went with this approach instead of removing
--with-socket-dir so screen would default to using ~/.screen, becaise it
would require users with currently running screen sessions to launch the
screen client with SCREENDIR set correctly.

Since that approach would be more complicated for users and require
leaving an INSTALL.msg in the package for some time, we went with a
simpler one of always creating the directory at build time.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: screen: fix launch.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/32159#issuecomment-885908748

Comment:
Looks good to me. Maybe it should also create `/run/screens` at install time?

Re: screen: fix launch.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32159#issuecomment-885993070

Comment:
You're not wrong, but I'm dreading having to fix the package *again*. Would you be interested in making a PR?

Re: screen: fix launch.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/32159#issuecomment-886274154

Comment:
See #32201