Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: pass-import: update to version 3.2
Date: Mon, 26 Jul 2021 20:13:16 +0200	[thread overview]
Message-ID: <20210726181316.HiqycMwechwxeKO9dqTAapvpnt0dWwitWAQJ_iNKTT0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32091@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32091#issuecomment-886919583

Comment:
> I did think of including an update to `python3-pykeepass` into this pr but I thought it would be more simple to make the check work with the old version as it builds OK then update later.

you are not making check work with the old version you are ignoring the keepass part of the checks, because they fail. This is suspicious, especially if newer pykeepass fixes it.

The current pass-import version in the repositories (before this PR) doesn't work with pykeepass 4 and it sounds like pass-import 3.2 doesn't work with the older version either, so both packages should be in the same PR to avoid merging one before the other and breaking pass-import until the other PR is merged.

> I have noticed all the automatic checks have failed. Would rebasing this branch against a newer version of master help?

yes, a rebase on top of master will fix it



  parent reply	other threads:[~2021-07-26 18:13 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 12:44 [PR PATCH] " adbrown101
2021-07-21 19:22 ` ericonr
2021-07-22 21:11 ` [PR PATCH] [Updated] " adbrown101
2021-07-22 21:16 ` adbrown101
2021-07-23  1:43 ` [PR REVIEW] " sgn
2021-07-24  8:02 ` adbrown101
2021-07-24 10:14 ` paper42
2021-07-25 10:21 ` [PR PATCH] [Updated] " adbrown101
2021-07-25 15:34 ` adbrown101
2021-07-25 15:37 ` [PR REVIEW] " adbrown101
2021-07-25 16:29 ` paper42
2021-07-25 16:30 ` [PR REVIEW] " paper42
2021-07-26 16:56 ` [PR PATCH] [Updated] " adbrown101
2021-07-26 16:59 ` adbrown101
2021-07-26 17:03 ` [PR REVIEW] " adbrown101
2021-07-26 17:07 ` adbrown101
2021-07-26 18:13 ` paper42 [this message]
2021-07-26 18:15 ` [PR REVIEW] " paper42
2021-07-26 18:18 ` paper42
2021-07-26 18:18 ` paper42
2021-07-27 12:34 ` [PR REVIEW] " adbrown101
2021-07-27 12:36 ` adbrown101
2021-07-27 12:37 ` adbrown101
2021-07-27 12:41 ` paper42
2021-07-27 17:00 ` [PR PATCH] [Updated] " adbrown101
2021-07-27 17:05 ` adbrown101
2021-07-27 18:02 ` paper42
2021-07-28 16:53 ` adbrown101
2021-07-28 20:12 ` paper42
2021-11-10  0:19 ` paper42
2021-11-11 12:03 ` adbrown101
2021-11-12 17:35 ` [PR PATCH] [Updated] " adbrown101
2021-11-12 18:08 ` [PR REVIEW] " paper42
2021-11-12 18:16 ` paper42
2021-11-12 18:16 ` paper42
2021-11-13 12:16 ` [PR PATCH] [Updated] " adbrown101
2021-11-13 12:17 ` adbrown101
2021-11-13 15:07 ` [PR PATCH] [Updated] " adbrown101
2021-11-13 21:59 ` [PR PATCH] [Merged]: " paper42
2021-11-16 13:09 ` adbrown101
2021-11-16 13:40 ` paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726181316.HiqycMwechwxeKO9dqTAapvpnt0dWwitWAQJ_iNKTT0@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).