Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] screen: create /run/screens also at install time
Date: Mon, 26 Jul 2021 21:55:25 +0200	[thread overview]
Message-ID: <20210726195525.xYvQ1OHMJ1N_nIiimlT3NP6Rzbq3xCXYDkWz7wgmq1c@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32201@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages screen
https://github.com/void-linux/void-packages/pull/32201

screen: create /run/screens also at install time
After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-screen-32201.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]

From b0452c4cfda7e5df47ea862def5c05be32f85439 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 25 Jul 2021 20:12:49 -0300
Subject: [PATCH] screen: create /run/screens also at install time

After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).
---
 srcpkgs/screen/INSTALL  | 5 +++++
 srcpkgs/screen/template | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/screen/INSTALL

diff --git a/srcpkgs/screen/INSTALL b/srcpkgs/screen/INSTALL
new file mode 100644
index 000000000000..08c7bf69bc28
--- /dev/null
+++ b/srcpkgs/screen/INSTALL
@@ -0,0 +1,5 @@
+case "${ACTION}" in
+post)
+	install -dm 1777 run/screens
+	;;
+esac
diff --git a/srcpkgs/screen/template b/srcpkgs/screen/template
index 2c25c9c77729..2b99cdc2771c 100644
--- a/srcpkgs/screen/template
+++ b/srcpkgs/screen/template
@@ -1,7 +1,7 @@
 # Template file for 'screen'
 pkgname=screen
 version=4.8.0
-revision=4
+revision=5
 build_style=gnu-configure
 configure_args="--with-sys-screenrc=/etc/screenrc --enable-pam
  --enable-colors256 --enable-rxvt_osc --enable-telnet

  parent reply	other threads:[~2021-07-26 19:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25 23:24 [PR PATCH] " tornaria
2021-07-26  5:31 ` [PR REVIEW] " ericonr
2021-07-26  5:31 ` ericonr
2021-07-26 19:55 ` tornaria [this message]
2021-07-26 19:56 ` tornaria
2021-07-26 20:15 ` [PR PATCH] [Merged]: " ericonr
2021-07-27  6:47 ` redasamik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726195525.xYvQ1OHMJ1N_nIiimlT3NP6Rzbq3xCXYDkWz7wgmq1c@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).