[PR PATCH] screen: create /run/screens also at install time

[PR PATCH] screen: create /run/screens also at install time

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages screen
https://github.com/void-linux/void-packages/pull/32201

screen: create /run/screens also at install time
After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-screen-32201.patch --]
[-- Type: text/x-diff, Size: 1367 bytes --]

From 7d15f71b0b6d0ad5def1ad3ddeb5211646c5ae28 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 25 Jul 2021 20:12:49 -0300
Subject: [PATCH] screen: create /run/screens also at install time

After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).
---
 srcpkgs/screen/INSTALL  | 5 +++++
 srcpkgs/screen/template | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/screen/INSTALL

diff --git a/srcpkgs/screen/INSTALL b/srcpkgs/screen/INSTALL
new file mode 100644
index 000000000000..c6324b87b729
--- /dev/null
+++ b/srcpkgs/screen/INSTALL
@@ -0,0 +1,5 @@
+case "${ACTION}" in
+post)
+	. /etc/runit/core-services/20-screen.sh
+	;;
+esac
diff --git a/srcpkgs/screen/template b/srcpkgs/screen/template
index 2c25c9c77729..2b99cdc2771c 100644
--- a/srcpkgs/screen/template
+++ b/srcpkgs/screen/template
@@ -1,7 +1,7 @@
 # Template file for 'screen'
 pkgname=screen
 version=4.8.0
-revision=4
+revision=5
 build_style=gnu-configure
 configure_args="--with-sys-screenrc=/etc/screenrc --enable-pam
  --enable-colors256 --enable-rxvt_osc --enable-telnet

Re: [PR REVIEW] screen: create /run/screens also at install time

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32201#discussion_r676301421

Comment:
Not sure if this is fine, most `INSTALL` actions would deal with `run/screen` so they affect the target root... Might be better to just copy the `install` command, IMO.

Re: [PR REVIEW] screen: create /run/screens also at install time

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32201#discussion_r676301557

Comment:
(but use `run/` instead of `/run/`

Re: [PR PATCH] [Updated] screen: create /run/screens also at install time

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages screen
https://github.com/void-linux/void-packages/pull/32201

screen: create /run/screens also at install time
After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-screen-32201.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]

From b0452c4cfda7e5df47ea862def5c05be32f85439 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 25 Jul 2021 20:12:49 -0300
Subject: [PATCH] screen: create /run/screens also at install time

After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).
---
 srcpkgs/screen/INSTALL  | 5 +++++
 srcpkgs/screen/template | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/screen/INSTALL

diff --git a/srcpkgs/screen/INSTALL b/srcpkgs/screen/INSTALL
new file mode 100644
index 000000000000..08c7bf69bc28
--- /dev/null
+++ b/srcpkgs/screen/INSTALL
@@ -0,0 +1,5 @@
+case "${ACTION}" in
+post)
+	install -dm 1777 run/screens
+	;;
+esac
diff --git a/srcpkgs/screen/template b/srcpkgs/screen/template
index 2c25c9c77729..2b99cdc2771c 100644
--- a/srcpkgs/screen/template
+++ b/srcpkgs/screen/template
@@ -1,7 +1,7 @@
 # Template file for 'screen'
 pkgname=screen
 version=4.8.0
-revision=4
+revision=5
 build_style=gnu-configure
 configure_args="--with-sys-screenrc=/etc/screenrc --enable-pam
  --enable-colors256 --enable-rxvt_osc --enable-telnet

Re: [PR REVIEW] screen: create /run/screens also at install time

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New review comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/32201#discussion_r676900409

Comment:
done

Re: [PR PATCH] [Merged]: screen: create /run/screens also at install time

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]

There's a merged pull request on the void-packages repository

screen: create /run/screens also at install time
https://github.com/void-linux/void-packages/pull/32201

Description:
After 56db43e, the directory is created at boot time.
This means if one installs screen it won't work until
after the first reboot.

This commit fixes that by creating the directory also
at install time. Note that we still need to create the
directory at boot time, since /run is cleared (tmpfs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: screen: create /run/screens also at install time

[redasamik]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

New comment by redasamik on void-packages repository

https://github.com/void-linux/void-packages/pull/32201#issuecomment-887256828

Comment:
2021-07-26 8:31 غرينتش+03:00, Érico Nogueira Rolim ***@***.***>:
> @ericonr commented on this pull request.
>
>
>
>> @@ -0,0 +1,5 @@
> +case "${ACTION}" in
> +post)
> +	. /etc/runit/core-services/20-screen.sh
>
> (but use `run/` instead of `/run/`
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/void-linux/void-packages/pull/32201#discussion_r676301557