Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] lollypop: update to 1.4.22 and fix runtime deps
@ 2021-07-27 15:38 sug0
  2021-07-27 15:40 ` sug0
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: sug0 @ 2021-07-27 15:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

There is a new pull request by sug0 against master on the void-packages repository

https://github.com/sug0/void-packages lollypop-update
https://github.com/void-linux/void-packages/pull/32220

lollypop: update to 1.4.22 and fix runtime deps
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lollypop-update-32220.patch --]
[-- Type: text/x-diff, Size: 1440 bytes --]

From e28ee61c2e1a393d98ea29f2197041fbb82b02fb Mon Sep 17 00:00:00 2001
From: Tiago Carvalho <sugoiuguu@tfwno.gf>
Date: Tue, 27 Jul 2021 16:37:01 +0100
Subject: [PATCH] lollypop: update to 1.4.22 and fix runtime deps

---
 srcpkgs/lollypop/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/lollypop/template b/srcpkgs/lollypop/template
index a294bdb652a2..99da6e1cf126 100644
--- a/srcpkgs/lollypop/template
+++ b/srcpkgs/lollypop/template
@@ -1,16 +1,17 @@
 # Template file for 'lollypop'
 pkgname=lollypop
-version=1.4.19
+version=1.4.22
 revision=1
 build_style=meson
 hostmakedepends="cmake git glib-devel gobject-introspection intltool itstool pkg-config"
 makedepends="gtk+3-devel libsoup-devel python3-gobject-devel python3-devel"
 depends="dconf gst-libav gst-plugins-good1 libnotify libsecret
  python3-dbus python3-gobject python3-pylast python3-youtube-dl
- python3-Pillow totem-pl-parser python3-BeautifulSoup4 libhandy1"
+ python3-Pillow totem-pl-parser python3-BeautifulSoup4 libhandy1
+ gnome-keyring"
 short_desc="Music player for GNOME"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://wiki.gnome.org/Apps/Lollypop"
 distfiles="https://adishatz.org/lollypop/${pkgname}-${version}.tar.xz"
-checksum=38bc38181e93ad989cb42d8efb2b8dc96223486eb200863d81f3a0b7573e3830
+checksum=cda6b6da1adf242a9be9b6b9d7be0d9732d12a0cdde3aa81d8e8a5761eff9b9d

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: lollypop: update to 1.4.22 and fix runtime deps
  2021-07-27 15:38 [PR PATCH] lollypop: update to 1.4.22 and fix runtime deps sug0
@ 2021-07-27 15:40 ` sug0
  2021-07-27 15:40 ` sug0
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sug0 @ 2021-07-27 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by sug0 on void-packages repository

https://github.com/void-linux/void-packages/pull/32220#issuecomment-887619874

Comment:
To clarify: the new runtime dependency added fixes scrobbling not working, as we had to stored credentials in the gnome keyring.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: lollypop: update to 1.4.22 and fix runtime deps
  2021-07-27 15:38 [PR PATCH] lollypop: update to 1.4.22 and fix runtime deps sug0
  2021-07-27 15:40 ` sug0
@ 2021-07-27 15:40 ` sug0
  2021-07-28  4:13 ` [PR PATCH] [Merged]: " ericonr
  2021-07-28  4:13 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: sug0 @ 2021-07-27 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by sug0 on void-packages repository

https://github.com/void-linux/void-packages/pull/32220#issuecomment-887619874

Comment:
To clarify: the new runtime dependency added fixes scrobbling not working, as we had to store credentials in the gnome keyring.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: lollypop: update to 1.4.22 and fix runtime deps
  2021-07-27 15:38 [PR PATCH] lollypop: update to 1.4.22 and fix runtime deps sug0
  2021-07-27 15:40 ` sug0
  2021-07-27 15:40 ` sug0
@ 2021-07-28  4:13 ` ericonr
  2021-07-28  4:13 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-07-28  4:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

There's a merged pull request on the void-packages repository

lollypop: update to 1.4.22 and fix runtime deps
https://github.com/void-linux/void-packages/pull/32220

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: lollypop: update to 1.4.22 and fix runtime deps
  2021-07-27 15:38 [PR PATCH] lollypop: update to 1.4.22 and fix runtime deps sug0
                   ` (2 preceding siblings ...)
  2021-07-28  4:13 ` [PR PATCH] [Merged]: " ericonr
@ 2021-07-28  4:13 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-07-28  4:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32220#issuecomment-887994939

Comment:
Thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-28  4:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 15:38 [PR PATCH] lollypop: update to 1.4.22 and fix runtime deps sug0
2021-07-27 15:40 ` sug0
2021-07-27 15:40 ` sug0
2021-07-28  4:13 ` [PR PATCH] [Merged]: " ericonr
2021-07-28  4:13 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).