Re: [PR PATCH] [Updated] linux-firmware: subpackage for Qualcomm SoCs.

[JamiKettunen <JamiKettunen@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

There is an updated pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages qcom-fw-subpkg
https://github.com/void-linux/void-packages/pull/32146

linux-firmware: subpackage for Qualcomm SoCs.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Split from #31435 (`Qualcomm updates`) as suggested, also contains some discussion already about this subpackage.

A patch file from https://github.com/void-linux/void-packages/pull/32146.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qcom-fw-subpkg-32146.patch --]
[-- Type: text/x-diff, Size: 2418 bytes --]

From e6c4c7798b1955e3a453288b7d887ac8c7f47240 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sun, 6 Jun 2021 04:18:15 +0300
Subject: [PATCH] linux-firmware: subpackage for Qualcomm SoCs.

Split out the 20 MB of QCOM SoC blobs into it's own subpackage which can
be installed as needed on these ARM platforms.

As the modem remoteprocessor needs this FW for WLAN to work on e.g.
SDM845 also bring this in with linux-firmware-network for armv7/aarch64
targets.
---
 srcpkgs/linux-firmware-qualcomm |  1 +
 srcpkgs/linux-firmware/template | 18 ++++++++++++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/linux-firmware-qualcomm

diff --git a/srcpkgs/linux-firmware-qualcomm b/srcpkgs/linux-firmware-qualcomm
new file mode 120000
index 000000000000..9a0010a89de1
--- /dev/null
+++ b/srcpkgs/linux-firmware-qualcomm
@@ -0,0 +1 @@
+linux-firmware
\ No newline at end of file
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..6a296e863a1b 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'linux-firmware'
 pkgname=linux-firmware
 version=20210511
-revision=1
+revision=2
 depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
 short_desc="Binary firmware blobs for the Linux kernel"
 maintainer="Érico Nogueira <ericonr@disroot.org>"
@@ -13,7 +13,8 @@ python_version=3
 nostrip=yes
 
 subpackages="linux-firmware-amd linux-firmware-broadcom
- linux-firmware-intel linux-firmware-nvidia linux-firmware-network"
+ linux-firmware-intel linux-firmware-nvidia linux-firmware-network
+ linux-firmware-qualcomm"
 
 do_install() {
 	make install FIRMWAREDIR=/usr/lib/firmware DESTDIR=$DESTDIR
@@ -72,6 +73,11 @@ linux-firmware-nvidia_package() {
 linux-firmware-network_package() {
 	short_desc+=" - network"
 	depends="linux-firmware-broadcom>=${version}_${revision}"
+	case "$XBPS_TARGET_MACHINE" in
+		armv7*|aarch64*)
+			depends+=" linux-firmware-qualcomm>=${version}_${revision}"
+			;;
+	esac
 	nostrip=yes
 	pkg_install() {
 		vmove usr/lib/firmware/3com
@@ -94,3 +100,11 @@ linux-firmware-network_package() {
 		vmove usr/lib/firmware/qca
 	}
 }
+
+linux-firmware-qualcomm_package() {
+	short_desc+=" - Qualcomm SoC blobs"
+	nostrip=yes
+	pkg_install() {
+		vmove usr/lib/firmware/qcom
+	}
+}