[PR PATCH] pulseaudio: update to 15.0.

[PR PATCH] pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages pulseaudio
https://github.com/void-linux/void-packages/pull/32232

pulseaudio: update to 15.0.
* Enabled elogind functionality, so needs testing without elogind.
* Build on arm fails due to some long unsigned int vs. size_t issues which I would need help with.
* core-util-test still fails on CI

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32232.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseaudio-32232.patch --]
[-- Type: text/x-diff, Size: 2877 bytes --]

From 5a354032b3e78b1491f0144a5de31389276632c3 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Wed, 28 Jul 2021 16:35:07 +0200
Subject: [PATCH] pulseaudio: update to 15.0.

---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 13 ++++++-------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 7f0560d2bad3..d20c24ff3856 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -726,8 +726,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-14.2_2
 libpulse-mainloop-glib.so.0 libpulseaudio-14.2_2
 libpulse-simple.so.0 libpulseaudio-14.2_2
-libpulsecommon-14.2.so libpulseaudio-14.2_2
-libpulsecore-14.2.so libpulseaudio-14.2_2
+libpulsecommon-15.0.so libpulseaudio-15.0_1
+libpulsecore-15.0.so libpulseaudio-15.0_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index ebd8d86f63a7..eb53568c4a5e 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,20 +1,19 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.2
-revision=4
+version=15.0
+revision=1
 build_style=meson
-# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
- -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
- -Dudevrulesdir=/usr/lib/udev/rules.d
+ -Dbluez5=enabled -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
+ -Delogind=enabled -Dudevrulesdir=/usr/lib/udev/rules.d
  -Dbashcompletiondir=/usr/share/bash-completion/completions"
 hostmakedepends="cmake m4 gettext libtool orc-devel perl-XML-Parser pkg-config"
 makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel jack-devel
  libSM-devel libXtst-devel libasyncns-devel libbluetooth-devel
  libcap-devel libcap-progs libglib-devel libltdl-devel openssl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
- webrtc-audio-processing-devel xcb-util-devel check-devel"
+ webrtc-audio-processing-devel xcb-util-devel check-devel elogind-devel"
 depends="pulseaudio-utils>=${version}_${revision} rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
@@ -22,7 +21,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
+checksum=a40b887a3ba98cc26976eb11bdb6613988f145b19024d1b6555c6a03c9cba1a0
 python_version=3
 # FIXME: core-util-test fails
 make_check=yes

Re: pulseaudio: update to 15.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888456187

Comment:
The actual error is

```
../src/pulsecore/remap_neon.c: In function 'remap_ch4_s16ne_neon':
../src/pulsecore/remap_neon.c:234:9: error: inconsistent operand constraints in an 'asm'
  234 |         __asm__ __volatile__ (
      |         ^
../src/pulsecore/remap_neon.c:256: confused by earlier errors, bailing out
lto-wrapper: fatal error: /usr/bin/armv7l-linux-gnueabihf-gcc returned 1 exit status
```

Maybe try disabling lto? 

Re: pulseaudio: update to 15.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888456187

Comment:
The actual error is

```
../src/pulsecore/remap_neon.c: In function 'remap_ch4_s16ne_neon':
../src/pulsecore/remap_neon.c:234:9: error: inconsistent operand constraints in an 'asm'
  234 |         __asm__ __volatile__ (
      |         ^
../src/pulsecore/remap_neon.c:256: confused by earlier errors, bailing out
lto-wrapper: fatal error: /usr/bin/armv7l-linux-gnueabihf-gcc returned 1 exit status
```

Maybe try disabling lto? Unlikely to actually fix it, just a first step in debugging.

Re: pulseaudio: update to 15.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888471012

Comment:
What does the elogind functionality bring? Just to have an idea if enabling it is really worth it.

Re: [PR PATCH] [Updated] pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]

There is an updated pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages pulseaudio
https://github.com/void-linux/void-packages/pull/32232

pulseaudio: update to 15.0.
* Enabled elogind functionality, so needs testing without elogind.
* Build on arm fails due to some long unsigned int vs. size_t issues which I would need help with.
* core-util-test still fails on CI

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32232.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseaudio-32232.patch --]
[-- Type: text/x-diff, Size: 3154 bytes --]

From 11d4425956cf92e98d07ae2c93b5526d17f5b0b2 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Wed, 28 Jul 2021 16:35:07 +0200
Subject: [PATCH] pulseaudio: update to 15.0.

---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 17 ++++++++++-------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 7f0560d2bad3..d20c24ff3856 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -726,8 +726,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-14.2_2
 libpulse-mainloop-glib.so.0 libpulseaudio-14.2_2
 libpulse-simple.so.0 libpulseaudio-14.2_2
-libpulsecommon-14.2.so libpulseaudio-14.2_2
-libpulsecore-14.2.so libpulseaudio-14.2_2
+libpulsecommon-15.0.so libpulseaudio-15.0_1
+libpulsecore-15.0.so libpulseaudio-15.0_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index ebd8d86f63a7..eadb90827b2f 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,20 +1,19 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.2
-revision=4
+version=15.0
+revision=1
 build_style=meson
-# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
- -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
- -Dudevrulesdir=/usr/lib/udev/rules.d
+ -Dbluez5=enabled -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
+ -Delogind=enabled -Dudevrulesdir=/usr/lib/udev/rules.d
  -Dbashcompletiondir=/usr/share/bash-completion/completions"
 hostmakedepends="cmake m4 gettext libtool orc-devel perl-XML-Parser pkg-config"
 makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel jack-devel
  libSM-devel libXtst-devel libasyncns-devel libbluetooth-devel
  libcap-devel libcap-progs libglib-devel libltdl-devel openssl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
- webrtc-audio-processing-devel xcb-util-devel check-devel"
+ webrtc-audio-processing-devel xcb-util-devel check-devel elogind-devel"
 depends="pulseaudio-utils>=${version}_${revision} rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
@@ -22,7 +21,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
+checksum=a40b887a3ba98cc26976eb11bdb6613988f145b19024d1b6555c6a03c9cba1a0
 python_version=3
 # FIXME: core-util-test fails
 make_check=yes
@@ -39,6 +38,10 @@ if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" glib"
 fi
 
+case "$XBPS_TARGET_MACHINE" in
+	arm*) configure_args+=" -Db_lto=false"
+esac
+
 pre_configure() {
 	case "$XBPS_TARGET_MACHINE" in
 		# Disable neon optimizations for the arm* architectures

Re: pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888484469

Comment:
> Maybe try disabling lto? Unlikely to actually fix it, just a first step in debugging.

That actually fixed it. I disabled LTO for `arm*` now.

> What does the elogind functionality bring? Just to have an idea if enabling it is really worth it.

It gives each login session a PA client. I'm not sure what that actually means or what it's good for, however you added this comment in the last update: "`XXX: new version should be able to enable systemd functionality using elogind`".

I would be fine to leave it disabled.

Re: pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888486328

Comment:
I just got told from upstream what this does is it prevents pulseaudio from auto-exiting during a login session. Normally PA exits if there are no clients in a while.

Re: pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888486328

Comment:
I just got told from upstream what this does is it prevents pulseaudio from auto-exiting during a login session. Normally PA exits if there are no clients in a while.

This means it's fine to have elogind support compiled in when elogind is not present, it will just not spawn a client and PA will auto-exit just as before (also confirmed by upstream).

Re: pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888484469

Comment:
> Maybe try disabling lto? Unlikely to actually fix it, just a first step in debugging.

That actually fixed it. I disabled LTO for `arm*` now.

> What does the elogind functionality bring? Just to have an idea if enabling it is really worth it.

It gives each login session a PA client. I'm not sure what that actually means or what it's good for, however you added this comment in the last update: "`XXX: new version should be able to enable systemd functionality using elogind`".

Re: pulseaudio: update to 15.0.

[steinex]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#issuecomment-888486328

Comment:
I just got told from upstream what this does is it prevents pulseaudio from auto-exiting during a login session. Normally PA exits if there are no clients in a while.

This means it's fine to have elogind support compiled in when elogind is not present, it will just not spawn a client and PA will auto-exit just as before (also confirmed by upstream) - so I'd prefer to keep this functionality enabled.

Re: [PR REVIEW] pulseaudio: update to 15.0.

[abenson]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/32232#discussion_r695277293

Comment:
Test build failed for me, needs `doxygen`?

Re: [PR PATCH] [Closed]: pulseaudio: update to 15.0.

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

There's a closed pull request on the void-packages repository

pulseaudio: update to 15.0.
https://github.com/void-linux/void-packages/pull/32232

Description:
* Enabled elogind functionality, ~so needs testing without elogind.~
* ~Build on arm fails due to some long unsigned int vs. size_t issues which I would need help with.~
* core-util-test still fails on CI

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->