From: Naia-love <Naia-love@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: session-desktop-1.6.9
Date: Fri, 30 Jul 2021 19:42:12 +0200 [thread overview]
Message-ID: <20210730174212.iQ8NwPWYwJ4KWjym1t_qu2_-bR7Lg_Gzur2MGhZLuJY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32252@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New review comment by Naia-love on void-packages repository
https://github.com/void-linux/void-packages/pull/32252#discussion_r680029580
Comment:
> They use Electron 8.2.0, which is over 1y old...
> ( https://github.com/oxen-io/session-desktop/blob/v1.6.9/yarn.lock#L3351
> https://github.com/electron/electron/releases/tag/v8.2.0 )
>
> So using system electron isn't a option right now (We do not, and never will ship electron 8, it is long EOL and I would rather not add a package which depends on it.
The app seems to run fine using electron 12 from what i'm testing rn ^^
next prev parent reply other threads:[~2021-07-30 17:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 0:33 [PR PATCH] " Naia-love
2021-07-30 0:38 ` [PR PATCH] [Updated] " Naia-love
2021-07-30 9:46 ` [PR REVIEW] " paper42
2021-07-30 11:13 ` Naia-love
2021-07-30 11:21 ` Naia-love
2021-07-30 11:21 ` Naia-love
2021-07-30 11:22 ` Naia-love
2021-07-30 12:30 ` [PR PATCH] [Updated] " Naia-love
2021-07-30 12:32 ` Naia-love
2021-07-30 12:37 ` Naia-love
2021-07-30 13:01 ` [PR REVIEW] " paper42
2021-07-30 13:05 ` Naia-love
2021-07-30 13:21 ` FollieHiyuki
2021-07-30 13:25 ` paper42
2021-07-30 13:29 ` FollieHiyuki
2021-07-30 13:54 ` Naia-love
2021-07-30 14:06 ` [PR PATCH] [Updated] " Naia-love
2021-07-30 14:12 ` [PR REVIEW] " FollieHiyuki
2021-07-30 15:33 ` Johnnynator
2021-07-30 15:50 ` Naia-love
2021-07-30 17:42 ` Naia-love [this message]
2021-07-30 18:03 ` [PR PATCH] [Updated] " Naia-love
2021-07-30 18:09 ` [PR REVIEW] " Naia-love
2021-10-08 20:20 ` HadetTheUndying
2021-10-08 20:25 ` Naia-love
2022-05-31 2:13 ` github-actions
2022-06-14 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730174212.iQ8NwPWYwJ4KWjym1t_qu2_-bR7Lg_Gzur2MGhZLuJY@z \
--to=naia-love@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).