From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] geary: update to 40.0.
Date: Fri, 30 Jul 2021 22:13:40 +0200 [thread overview]
Message-ID: <20210730201340.Ttdwaq8dMgtzG7GHCiu3Bv0WAmlHDRsR1ddY2GQhE6s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30685@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/30685#discussion_r680194975
Comment:
> @paper42, please document that other distros are doing this, so the library is being treated as shared by downstreams. I'd appreciate links in the commit to the packaging done by other distros too.
>
> IMO this should have a big `# XXX` comment.
done
> Why are you against statically linking it? Kinda sucks for size, but we won't be caught by any unexpected upstream breakage, at least.
If you think it would be a better idea, I can do it, but no other distribution I looked at does this and it would require extra care in each package that depends on libstemmer (I expect there will be more dependants than just geary and calibre in the future).
next prev parent reply other threads:[~2021-07-30 20:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 22:24 [PR PATCH] " paper42
2021-05-05 2:16 ` [PR REVIEW] " ericonr
2021-05-05 10:28 ` [PR PATCH] [Updated] " paper42
2021-05-05 10:29 ` [PR REVIEW] " paper42
2021-05-05 14:30 ` ericonr
2021-05-20 8:30 ` [PR PATCH] [Updated] " paper42
2021-05-25 5:41 ` [PR REVIEW] " CameronNemo
2021-05-25 7:48 ` paper42
2021-06-11 21:00 ` paper42
2021-07-03 19:16 ` kkga
2021-07-28 4:54 ` [PR REVIEW] " ericonr
2021-07-28 4:55 ` ericonr
2021-07-30 20:07 ` [PR PATCH] [Updated] " paper42
2021-07-30 20:10 ` paper42
2021-07-30 20:13 ` paper42 [this message]
2021-07-30 20:16 ` paper42
2021-07-30 20:21 ` [PR PATCH] [Updated] " paper42
2021-07-30 21:55 ` paper42
2021-08-03 2:50 ` [PR REVIEW] " ericonr
2021-08-03 2:50 ` ericonr
2021-08-03 2:50 ` ericonr
2021-08-03 2:50 ` ericonr
2021-08-06 19:00 ` paper42
2021-08-06 19:09 ` [PR PATCH] [Updated] " paper42
2021-08-06 19:52 ` [PR REVIEW] " ericonr
2021-08-06 19:53 ` ericonr
2021-08-06 20:05 ` paper42
2021-08-06 20:06 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730201340.Ttdwaq8dMgtzG7GHCiu3Bv0WAmlHDRsR1ddY2GQhE6s@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).