Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs.
@ 2021-07-22 16:10 JamiKettunen
  2021-07-22 17:57 ` [PR REVIEW] " ericonr
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-22 16:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

There is a new pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages qcom-fw-subpkg
https://github.com/void-linux/void-packages/pull/32146

linux-firmware: subpackage for Qualcomm SoCs.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Split from #31435 (`Qualcomm updates`) as suggested, also contains some discussion already about this subpackage.

A patch file from https://github.com/void-linux/void-packages/pull/32146.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qcom-fw-subpkg-32146.patch --]
[-- Type: text/x-diff, Size: 1772 bytes --]

From 34c1dbda6f212c5115ca9bb0d23d2e19faea40e8 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sun, 6 Jun 2021 04:18:15 +0300
Subject: [PATCH] linux-firmware: subpackage for Qualcomm SoCs.

---
 srcpkgs/linux-firmware-qualcomm |  1 +
 srcpkgs/linux-firmware/template | 13 +++++++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/linux-firmware-qualcomm

diff --git a/srcpkgs/linux-firmware-qualcomm b/srcpkgs/linux-firmware-qualcomm
new file mode 120000
index 000000000000..9a0010a89de1
--- /dev/null
+++ b/srcpkgs/linux-firmware-qualcomm
@@ -0,0 +1 @@
+linux-firmware
\ No newline at end of file
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..0cc5f6af1e15 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'linux-firmware'
 pkgname=linux-firmware
 version=20210511
-revision=1
+revision=2
 depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
 short_desc="Binary firmware blobs for the Linux kernel"
 maintainer="Érico Nogueira <ericonr@disroot.org>"
@@ -13,7 +13,8 @@ python_version=3
 nostrip=yes
 
 subpackages="linux-firmware-amd linux-firmware-broadcom
- linux-firmware-intel linux-firmware-nvidia linux-firmware-network"
+ linux-firmware-intel linux-firmware-nvidia linux-firmware-network
+ linux-firmware-qualcomm"
 
 do_install() {
 	make install FIRMWAREDIR=/usr/lib/firmware DESTDIR=$DESTDIR
@@ -94,3 +95,11 @@ linux-firmware-network_package() {
 		vmove usr/lib/firmware/qca
 	}
 }
+
+linux-firmware-qualcomm_package() {
+	short_desc+=" - Qualcomm SoC blobs"
+	nostrip=yes
+	pkg_install() {
+		vmove usr/lib/firmware/qcom
+	}
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
@ 2021-07-22 17:57 ` ericonr
  2021-07-22 19:04 ` JamiKettunen
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-22 17:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r675044863

Comment:
I think network should depend on these?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
  2021-07-22 17:57 ` [PR REVIEW] " ericonr
@ 2021-07-22 19:04 ` JamiKettunen
  2021-07-28  4:31 ` ericonr
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-22 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r675089271

Comment:
Technically yes as it contains the modem remoteprocessor firmware for at least SDM845 (which is obligatory for WLAN), but otherwise no; `qca` is the one containing Qualcomm Atheros FW and is already a part of that subpackage.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
  2021-07-22 17:57 ` [PR REVIEW] " ericonr
  2021-07-22 19:04 ` JamiKettunen
@ 2021-07-28  4:31 ` ericonr
  2021-07-28 11:56 ` JamiKettunen
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-28  4:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r677964255

Comment:
> Technically yes as it contains the modem remoteprocessor firmware for at least SDM845 (which is obligatory for WLAN), but otherwise no

That would still make it a final "yes", wouldn't it?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (2 preceding siblings ...)
  2021-07-28  4:31 ` ericonr
@ 2021-07-28 11:56 ` JamiKettunen
  2021-07-28 12:02 ` JamiKettunen
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-28 11:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r678231519

Comment:
Let's compromise: would you accept adding `-qualcomm` as a dep for `-network` under `aarch64*|armv*` only? these blobs are only meant to be run under ARM platforms so it doesn't make sense to bring them in on e.g. x86 platforms.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (3 preceding siblings ...)
  2021-07-28 11:56 ` JamiKettunen
@ 2021-07-28 12:02 ` JamiKettunen
  2021-07-28 12:13 ` ericonr
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-28 12:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r678231519

Comment:
Let's compromise: would you accept adding `-qualcomm` as a dep for `-network` under `armv7*|aarch64*` only? these blobs are only meant to be run under ARM platforms so it doesn't make sense to bring them in on e.g. `x86_64`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (4 preceding siblings ...)
  2021-07-28 12:02 ` JamiKettunen
@ 2021-07-28 12:13 ` ericonr
  2021-07-28 12:18 ` JamiKettunen
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-28 12:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r678242675

Comment:
That sounds reasonable. Why not `arm*` instead of only v7?

I hope the extra separation doesn't come to bite us :p 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (5 preceding siblings ...)
  2021-07-28 12:13 ` ericonr
@ 2021-07-28 12:18 ` JamiKettunen
  2021-07-28 12:34 ` [PR PATCH] [Updated] " JamiKettunen
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-28 12:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r678245670

Comment:
According to [the Qualcomm SoC wikipedia list](https://en.wikipedia.org/wiki/List_of_Qualcomm_Snapdragon_processors) there are only a few `armv6` SoCs from circa 2008 (which don't have anything in `linux-firmware/qcom` and I doubt the situation will change considering how low performance these chips are these days) and the rest are `armv7` or `aarch64`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (6 preceding siblings ...)
  2021-07-28 12:18 ` JamiKettunen
@ 2021-07-28 12:34 ` JamiKettunen
  2021-07-28 14:30 ` [PR REVIEW] " ericonr
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-28 12:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

There is an updated pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages qcom-fw-subpkg
https://github.com/void-linux/void-packages/pull/32146

linux-firmware: subpackage for Qualcomm SoCs.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Split from #31435 (`Qualcomm updates`) as suggested, also contains some discussion already about this subpackage.

A patch file from https://github.com/void-linux/void-packages/pull/32146.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qcom-fw-subpkg-32146.patch --]
[-- Type: text/x-diff, Size: 2148 bytes --]

From a3291eb9baa181afd479167550d8f9948c3e01b8 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sun, 6 Jun 2021 04:18:15 +0300
Subject: [PATCH] linux-firmware: subpackage for Qualcomm SoCs.

---
 srcpkgs/linux-firmware-qualcomm |  1 +
 srcpkgs/linux-firmware/template | 18 ++++++++++++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/linux-firmware-qualcomm

diff --git a/srcpkgs/linux-firmware-qualcomm b/srcpkgs/linux-firmware-qualcomm
new file mode 120000
index 000000000000..9a0010a89de1
--- /dev/null
+++ b/srcpkgs/linux-firmware-qualcomm
@@ -0,0 +1 @@
+linux-firmware
\ No newline at end of file
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..6a296e863a1b 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'linux-firmware'
 pkgname=linux-firmware
 version=20210511
-revision=1
+revision=2
 depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
 short_desc="Binary firmware blobs for the Linux kernel"
 maintainer="Érico Nogueira <ericonr@disroot.org>"
@@ -13,7 +13,8 @@ python_version=3
 nostrip=yes
 
 subpackages="linux-firmware-amd linux-firmware-broadcom
- linux-firmware-intel linux-firmware-nvidia linux-firmware-network"
+ linux-firmware-intel linux-firmware-nvidia linux-firmware-network
+ linux-firmware-qualcomm"
 
 do_install() {
 	make install FIRMWAREDIR=/usr/lib/firmware DESTDIR=$DESTDIR
@@ -72,6 +73,11 @@ linux-firmware-nvidia_package() {
 linux-firmware-network_package() {
 	short_desc+=" - network"
 	depends="linux-firmware-broadcom>=${version}_${revision}"
+	case "$XBPS_TARGET_MACHINE" in
+		armv7*|aarch64*)
+			depends+=" linux-firmware-qualcomm>=${version}_${revision}"
+			;;
+	esac
 	nostrip=yes
 	pkg_install() {
 		vmove usr/lib/firmware/3com
@@ -94,3 +100,11 @@ linux-firmware-network_package() {
 		vmove usr/lib/firmware/qca
 	}
 }
+
+linux-firmware-qualcomm_package() {
+	short_desc+=" - Qualcomm SoC blobs"
+	nostrip=yes
+	pkg_install() {
+		vmove usr/lib/firmware/qcom
+	}
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (7 preceding siblings ...)
  2021-07-28 12:34 ` [PR PATCH] [Updated] " JamiKettunen
@ 2021-07-28 14:30 ` ericonr
  2021-07-28 14:55 ` [PR PATCH] [Updated] " JamiKettunen
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-28 14:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r678358461

Comment:
Ok. Since a lot of consideration went into the split, please explain why things are being done this way in the commit message (basically just repeat what you wrote in previous comments)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (8 preceding siblings ...)
  2021-07-28 14:30 ` [PR REVIEW] " ericonr
@ 2021-07-28 14:55 ` JamiKettunen
  2021-07-28 15:04 ` [PR REVIEW] " JamiKettunen
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-28 14:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

There is an updated pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages qcom-fw-subpkg
https://github.com/void-linux/void-packages/pull/32146

linux-firmware: subpackage for Qualcomm SoCs.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Split from #31435 (`Qualcomm updates`) as suggested, also contains some discussion already about this subpackage.

A patch file from https://github.com/void-linux/void-packages/pull/32146.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qcom-fw-subpkg-32146.patch --]
[-- Type: text/x-diff, Size: 2418 bytes --]

From e6c4c7798b1955e3a453288b7d887ac8c7f47240 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sun, 6 Jun 2021 04:18:15 +0300
Subject: [PATCH] linux-firmware: subpackage for Qualcomm SoCs.

Split out the 20 MB of QCOM SoC blobs into it's own subpackage which can
be installed as needed on these ARM platforms.

As the modem remoteprocessor needs this FW for WLAN to work on e.g.
SDM845 also bring this in with linux-firmware-network for armv7/aarch64
targets.
---
 srcpkgs/linux-firmware-qualcomm |  1 +
 srcpkgs/linux-firmware/template | 18 ++++++++++++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/linux-firmware-qualcomm

diff --git a/srcpkgs/linux-firmware-qualcomm b/srcpkgs/linux-firmware-qualcomm
new file mode 120000
index 000000000000..9a0010a89de1
--- /dev/null
+++ b/srcpkgs/linux-firmware-qualcomm
@@ -0,0 +1 @@
+linux-firmware
\ No newline at end of file
diff --git a/srcpkgs/linux-firmware/template b/srcpkgs/linux-firmware/template
index 66358c052182..6a296e863a1b 100644
--- a/srcpkgs/linux-firmware/template
+++ b/srcpkgs/linux-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'linux-firmware'
 pkgname=linux-firmware
 version=20210511
-revision=1
+revision=2
 depends="${pkgname}-amd>=${version}_${revision} ${pkgname}-network>=${version}_${revision}"
 short_desc="Binary firmware blobs for the Linux kernel"
 maintainer="Érico Nogueira <ericonr@disroot.org>"
@@ -13,7 +13,8 @@ python_version=3
 nostrip=yes
 
 subpackages="linux-firmware-amd linux-firmware-broadcom
- linux-firmware-intel linux-firmware-nvidia linux-firmware-network"
+ linux-firmware-intel linux-firmware-nvidia linux-firmware-network
+ linux-firmware-qualcomm"
 
 do_install() {
 	make install FIRMWAREDIR=/usr/lib/firmware DESTDIR=$DESTDIR
@@ -72,6 +73,11 @@ linux-firmware-nvidia_package() {
 linux-firmware-network_package() {
 	short_desc+=" - network"
 	depends="linux-firmware-broadcom>=${version}_${revision}"
+	case "$XBPS_TARGET_MACHINE" in
+		armv7*|aarch64*)
+			depends+=" linux-firmware-qualcomm>=${version}_${revision}"
+			;;
+	esac
 	nostrip=yes
 	pkg_install() {
 		vmove usr/lib/firmware/3com
@@ -94,3 +100,11 @@ linux-firmware-network_package() {
 		vmove usr/lib/firmware/qca
 	}
 }
+
+linux-firmware-qualcomm_package() {
+	short_desc+=" - Qualcomm SoC blobs"
+	nostrip=yes
+	pkg_install() {
+		vmove usr/lib/firmware/qcom
+	}
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (9 preceding siblings ...)
  2021-07-28 14:55 ` [PR PATCH] [Updated] " JamiKettunen
@ 2021-07-28 15:04 ` JamiKettunen
  2021-07-31  2:15 ` ericonr
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2021-07-28 15:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r678391663

Comment:
Done, do tell me if I missed something important :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (10 preceding siblings ...)
  2021-07-28 15:04 ` [PR REVIEW] " JamiKettunen
@ 2021-07-31  2:15 ` ericonr
  2021-07-31  2:16 ` ericonr
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-31  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#discussion_r680291117

Comment:
Great, thanks :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (11 preceding siblings ...)
  2021-07-31  2:15 ` ericonr
@ 2021-07-31  2:16 ` ericonr
  2021-07-31  2:17 ` ericonr
  2021-08-30 20:07 ` [PR PATCH] [Merged]: " ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-31  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#issuecomment-890277666

Comment:
@Duncaen are you ok with this now?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (12 preceding siblings ...)
  2021-07-31  2:16 ` ericonr
@ 2021-07-31  2:17 ` ericonr
  2021-08-30 20:07 ` [PR PATCH] [Merged]: " ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-07-31  2:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32146#issuecomment-890277666

Comment:
@Duncaen are you ok with this now? `linux-firmware` will bring the qualcomm package as a dependency on arm platforms.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Merged]: linux-firmware: subpackage for Qualcomm SoCs.
  2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
                   ` (13 preceding siblings ...)
  2021-07-31  2:17 ` ericonr
@ 2021-08-30 20:07 ` ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-08-30 20:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

There's a merged pull request on the void-packages repository

linux-firmware: subpackage for Qualcomm SoCs.
https://github.com/void-linux/void-packages/pull/32146

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Split from #31435 (`Qualcomm updates`) as suggested, also contains some discussion already about this subpackage.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-08-30 20:07 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 16:10 [PR PATCH] linux-firmware: subpackage for Qualcomm SoCs JamiKettunen
2021-07-22 17:57 ` [PR REVIEW] " ericonr
2021-07-22 19:04 ` JamiKettunen
2021-07-28  4:31 ` ericonr
2021-07-28 11:56 ` JamiKettunen
2021-07-28 12:02 ` JamiKettunen
2021-07-28 12:13 ` ericonr
2021-07-28 12:18 ` JamiKettunen
2021-07-28 12:34 ` [PR PATCH] [Updated] " JamiKettunen
2021-07-28 14:30 ` [PR REVIEW] " ericonr
2021-07-28 14:55 ` [PR PATCH] [Updated] " JamiKettunen
2021-07-28 15:04 ` [PR REVIEW] " JamiKettunen
2021-07-31  2:15 ` ericonr
2021-07-31  2:16 ` ericonr
2021-07-31  2:17 ` ericonr
2021-08-30 20:07 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).