Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: sublime-text4-4107
@ 2021-05-21 12:31 DirectorX
  2021-05-21 12:32 ` [PR REVIEW] " DirectorX
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: DirectorX @ 2021-05-21 12:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

There is a new pull request by DirectorX against master on the void-packages repository

https://github.com/DirectorX/void-packages sublime-text4
https://github.com/void-linux/void-packages/pull/31036

New package: sublime-text4-4107
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sublime-text4-31036.patch --]
[-- Type: text/x-diff, Size: 1984 bytes --]

From 8ab4de1a3e49a17650657ef2f5f0d2e6ad709808 Mon Sep 17 00:00:00 2001
From: DirectorX <DirectorX@users.noreply.github.com>
Date: Fri, 21 May 2021 15:28:47 +0300
Subject: [PATCH] New package: sublime-text4-4107

---
 srcpkgs/sublime-text4/template | 41 ++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 srcpkgs/sublime-text4/template

diff --git a/srcpkgs/sublime-text4/template b/srcpkgs/sublime-text4/template
new file mode 100644
index 000000000000..8d436ff21120
--- /dev/null
+++ b/srcpkgs/sublime-text4/template
@@ -0,0 +1,41 @@
+# Template file for 'sublime-text4'
+pkgname=sublime-text4
+version=4107
+revision=1
+depends="libpng gtk+ hicolor-icon-theme desktop-file-utils"
+short_desc="Sophisticated text editor for code, markup and prose"
+maintainer="DirectorX <void.directorx@protonmail.com>"
+license="custom:Proprietary"
+homepage="https://www.sublimetext.com/"
+replaces="sublime-text3>=0"
+
+
+case "$XBPS_TARGET_MACHINE" in
+		x86_64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_x64.tar.xz"
+		checksum=c7d9e7520ea91c2db6c026d1f48e9067457d55158393be042100a1161a3e5915
+		;;
+		aarch64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_arm64.tar.xz"
+		checksum=e0ccf0859d7b73a718b65c0f03e48189ecba1a256bb800d738b24078994cae03
+		;;
+esac
+
+repository="nonfree"
+archs="x86_64 aarch64"
+wrksrc="sublime_text"
+nopie=yes
+
+do_install() {
+	vmkdir "usr/bin"
+	vmkdir "usr/lib/sublime_text"
+	cp --preserve=mode -r ./* "${DESTDIR}/usr/lib/sublime_text"
+	vinstall "sublime_text.desktop" 644 "usr/share/applications/"
+	for size in 128 16 256 32 48; do
+		vinstall "Icon/${size}x${size}/sublime-text.png" 644 \
+		 "usr/share/icons/hicolor/${size}x${size}/apps/"
+	done
+	ln -s /usr/lib/sublime_text/sublime_text ${DESTDIR}/usr/bin/subl4
+	vsed -e 's:Exec=/opt/sublime_text/:Exec=/usr/lib/sublime_text/:' \
+	 -i ${DESTDIR}/usr/share/applications/sublime_text.desktop
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
@ 2021-05-21 12:32 ` DirectorX
  2021-05-21 13:51 ` marmeladema
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-05-21 12:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by DirectorX on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#discussion_r636881105

Comment:
I don't thought about how to deal with subl3 yet.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
  2021-05-21 12:32 ` [PR REVIEW] " DirectorX
@ 2021-05-21 13:51 ` marmeladema
  2021-05-21 13:57 ` DirectorX
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: marmeladema @ 2021-05-21 13:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#discussion_r636936746

Comment:
I think you can just mark it as:
```
conflicts="sublime-text3"
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
  2021-05-21 12:32 ` [PR REVIEW] " DirectorX
  2021-05-21 13:51 ` marmeladema
@ 2021-05-21 13:57 ` DirectorX
  2021-05-21 13:58 ` DirectorX
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-05-21 13:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by DirectorX on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#discussion_r636881105

Comment:
I didn't thought about how to deal with subl3 yet.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (2 preceding siblings ...)
  2021-05-21 13:57 ` DirectorX
@ 2021-05-21 13:58 ` DirectorX
  2021-05-21 17:12 ` [PR PATCH] [Updated] " DirectorX
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-05-21 13:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by DirectorX on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-845969451

Comment:
aarch64 not tested

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (3 preceding siblings ...)
  2021-05-21 13:58 ` DirectorX
@ 2021-05-21 17:12 ` DirectorX
  2021-05-22 23:27 ` ericonr
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-05-21 17:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There is an updated pull request by DirectorX against master on the void-packages repository

https://github.com/DirectorX/void-packages sublime-text4
https://github.com/void-linux/void-packages/pull/31036

New package: sublime-text4-4107
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sublime-text4-31036.patch --]
[-- Type: text/x-diff, Size: 1982 bytes --]

From f0cba47eacd002e3f21a4920874e997d525d3746 Mon Sep 17 00:00:00 2001
From: DirectorX <DirectorX@users.noreply.github.com>
Date: Fri, 21 May 2021 15:28:47 +0300
Subject: [PATCH] New package: sublime-text4-4107

---
 srcpkgs/sublime-text4/template | 41 ++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 srcpkgs/sublime-text4/template

diff --git a/srcpkgs/sublime-text4/template b/srcpkgs/sublime-text4/template
new file mode 100644
index 000000000000..8f9e9d86e737
--- /dev/null
+++ b/srcpkgs/sublime-text4/template
@@ -0,0 +1,41 @@
+# Template file for 'sublime-text4'
+pkgname=sublime-text4
+version=4107
+revision=1
+depends="libpng gtk+ hicolor-icon-theme desktop-file-utils"
+short_desc="Sophisticated text editor for code, markup and prose"
+maintainer="DirectorX <void.directorx@protonmail.com>"
+license="custom:Proprietary"
+homepage="https://www.sublimetext.com/"
+conflicts="sublime-text3"
+
+
+case "$XBPS_TARGET_MACHINE" in
+		x86_64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_x64.tar.xz"
+		checksum=c7d9e7520ea91c2db6c026d1f48e9067457d55158393be042100a1161a3e5915
+		;;
+		aarch64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_arm64.tar.xz"
+		checksum=e0ccf0859d7b73a718b65c0f03e48189ecba1a256bb800d738b24078994cae03
+		;;
+esac
+
+repository="nonfree"
+archs="x86_64 aarch64"
+wrksrc="sublime_text"
+nopie=yes
+
+do_install() {
+	vmkdir "usr/bin"
+	vmkdir "usr/lib/sublime_text"
+	cp --preserve=mode -r ./* "${DESTDIR}/usr/lib/sublime_text"
+	vinstall "sublime_text.desktop" 644 "usr/share/applications/"
+	for size in 128 16 256 32 48; do
+		vinstall "Icon/${size}x${size}/sublime-text.png" 644 \
+		 "usr/share/icons/hicolor/${size}x${size}/apps/"
+	done
+	ln -s /usr/lib/sublime_text/sublime_text ${DESTDIR}/usr/bin/subl4
+	vsed -e 's:Exec=/opt/sublime_text/:Exec=/usr/lib/sublime_text/:' \
+	 -i ${DESTDIR}/usr/share/applications/sublime_text.desktop
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (4 preceding siblings ...)
  2021-05-21 17:12 ` [PR PATCH] [Updated] " DirectorX
@ 2021-05-22 23:27 ` ericonr
  2021-07-13 14:55 ` jchook
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2021-05-22 23:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-846475843

Comment:
Ideally should fix lint.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (5 preceding siblings ...)
  2021-05-22 23:27 ` ericonr
@ 2021-07-13 14:55 ` jchook
  2021-07-13 15:00 ` Nairou
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: jchook @ 2021-07-13 14:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New comment by jchook on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-879159364

Comment:
Would love to see this merged. From what I can see, the source tarball doesn't contain a license file, so I'm not sure how to resolve the lint error.

> srcpkgs/sublime-text4/template:8: license 'custom', but no use of vlicense

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (6 preceding siblings ...)
  2021-07-13 14:55 ` jchook
@ 2021-07-13 15:00 ` Nairou
  2021-07-13 16:32 ` jchook
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: Nairou @ 2021-07-13 15:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by Nairou on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-879163461

Comment:
Would it be sufficient to remove the license line in the template?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (7 preceding siblings ...)
  2021-07-13 15:00 ` Nairou
@ 2021-07-13 16:32 ` jchook
  2021-07-13 17:04 ` [PR REVIEW] " paper42
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: jchook @ 2021-07-13 16:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by jchook on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-879233221

Comment:
Apparently not.

> srcpkgs/sublime-text4/template: 'license' missing!

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (8 preceding siblings ...)
  2021-07-13 16:32 ` jchook
@ 2021-07-13 17:04 ` paper42
  2021-07-13 17:17 ` paper42
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-07-13 17:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#discussion_r668954325

Comment:
sublime-text should depend on GTK 3

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (9 preceding siblings ...)
  2021-07-13 17:04 ` [PR REVIEW] " paper42
@ 2021-07-13 17:17 ` paper42
  2021-07-13 17:18 ` paper42
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-07-13 17:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#discussion_r668963700

Comment:
why are these lines separate from the first block?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (10 preceding siblings ...)
  2021-07-13 17:17 ` paper42
@ 2021-07-13 17:18 ` paper42
  2021-07-31 11:33 ` lopqto
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-07-13 17:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#discussion_r668964245

Comment:
it would be nice to indent this line when it's a continuation of the previous one

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (11 preceding siblings ...)
  2021-07-13 17:18 ` paper42
@ 2021-07-31 11:33 ` lopqto
  2021-07-31 12:58 ` [PR PATCH] [Updated] " DirectorX
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: lopqto @ 2021-07-31 11:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by lopqto on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-890334630

Comment:
Hey folks,
any updates on this one?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (12 preceding siblings ...)
  2021-07-31 11:33 ` lopqto
@ 2021-07-31 12:58 ` DirectorX
  2021-07-31 19:11 ` Chocimier
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-07-31 12:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There is an updated pull request by DirectorX against master on the void-packages repository

https://github.com/DirectorX/void-packages sublime-text4
https://github.com/void-linux/void-packages/pull/31036

New package: sublime-text4-4107
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sublime-text4-31036.patch --]
[-- Type: text/x-diff, Size: 1983 bytes --]

From c05369d5762c6897822d84bbd7341572679de69c Mon Sep 17 00:00:00 2001
From: DirectorX <DirectorX@users.noreply.github.com>
Date: Fri, 21 May 2021 15:28:47 +0300
Subject: [PATCH] New package: sublime-text4-4107

---
 srcpkgs/sublime-text4/template | 39 ++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/sublime-text4/template

diff --git a/srcpkgs/sublime-text4/template b/srcpkgs/sublime-text4/template
new file mode 100644
index 000000000000..0449c2287625
--- /dev/null
+++ b/srcpkgs/sublime-text4/template
@@ -0,0 +1,39 @@
+# Template file for 'sublime-text4'
+pkgname=sublime-text4
+version=4113
+revision=1
+depends="libpng gtk+3 hicolor-icon-theme desktop-file-utils"
+short_desc="Sophisticated text editor for code, markup and prose"
+maintainer="DirectorX <void.directorx@protonmail.com>"
+license="custom:Proprietary"
+homepage="https://www.sublimetext.com/"
+conflicts="sublime-text3"
+repository="nonfree"
+archs="x86_64 aarch64"
+wrksrc="sublime_text"
+nopie=yes
+
+case "$XBPS_TARGET_MACHINE" in
+		x86_64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_x64.tar.xz"
+		checksum=900ef90fc6453efc4c2b36132a5f16a4db67a226fa9732e4d3c1bf586d4dc78c
+		;;
+		aarch64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_arm64.tar.xz"
+		checksum=63d536e4c1ff8ca13bbf19fdfacbdeedd6af783f759824500faa4216d978e641
+		;;
+esac
+
+do_install() {
+	vmkdir "usr/bin"
+	vmkdir "usr/lib/sublime_text"
+	cp --preserve=mode -r ./* "${DESTDIR}/usr/lib/sublime_text"
+	vinstall "sublime_text.desktop" 644 "usr/share/applications/"
+	for size in 128 16 256 32 48; do
+		vinstall "Icon/${size}x${size}/sublime-text.png" 644 \
+		 "usr/share/icons/hicolor/${size}x${size}/apps/"
+	done
+	ln -s /usr/lib/sublime_text/sublime_text ${DESTDIR}/usr/bin/subl4
+	vsed -e 's:Exec=/opt/sublime_text/:Exec=/usr/lib/sublime_text/:' \
+	     -i ${DESTDIR}/usr/share/applications/sublime_text.desktop
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (13 preceding siblings ...)
  2021-07-31 12:58 ` [PR PATCH] [Updated] " DirectorX
@ 2021-07-31 19:11 ` Chocimier
  2021-09-02 16:15 ` [PR PATCH] [Updated] " DirectorX
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: Chocimier @ 2021-07-31 19:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-890392440

Comment:
For vlicense, look at sublime-merge-bin.
Please sort lines as xlint says: https://github.com/leahneukirchen/xtools/blob/e778aefbcfd0e059f84540dfb90cdf64b4b1316b/xlint#L43

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (14 preceding siblings ...)
  2021-07-31 19:11 ` Chocimier
@ 2021-09-02 16:15 ` DirectorX
  2021-09-02 16:16 ` DirectorX
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-09-02 16:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There is an updated pull request by DirectorX against master on the void-packages repository

https://github.com/DirectorX/void-packages sublime-text4
https://github.com/void-linux/void-packages/pull/31036

New package: sublime-text4-4107
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sublime-text4-31036.patch --]
[-- Type: text/x-diff, Size: 2448 bytes --]

From 9fc86f4769f6baeca3ae443c49310f6b72664312 Mon Sep 17 00:00:00 2001
From: DirectorX <DirectorX@users.noreply.github.com>
Date: Fri, 21 May 2021 15:28:47 +0300
Subject: [PATCH] New package: sublime-text4-4113

---
 srcpkgs/sublime-text4/template | 56 ++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 srcpkgs/sublime-text4/template

diff --git a/srcpkgs/sublime-text4/template b/srcpkgs/sublime-text4/template
new file mode 100644
index 000000000000..832d9a8c7559
--- /dev/null
+++ b/srcpkgs/sublime-text4/template
@@ -0,0 +1,56 @@
+# Template file for 'sublime-text4'
+pkgname=sublime-text4
+version=4113
+revision=1
+archs="x86_64 aarch64"
+wrksrc="sublime_text"
+hostmakedepends="w3m"
+depends="libpng gtk+3 hicolor-icon-theme desktop-file-utils"
+short_desc="Sophisticated text editor for code, markup and prose"
+maintainer="DirectorX <void.directorx@protonmail.com>"
+license="custom:EULA"
+homepage="https://www.sublimetext.com/"
+conflicts="sublime-text3"
+repository="nonfree"
+nopie=yes
+_license_checksum=33929b71625d13dacf2a0a5853171b9c04058f71e2955ee660b8d0f8dda45ed1
+
+case "$XBPS_TARGET_MACHINE" in
+		x86_64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_x64.tar.xz"
+		checksum=900ef90fc6453efc4c2b36132a5f16a4db67a226fa9732e4d3c1bf586d4dc78c
+		;;
+		aarch64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_arm64.tar.xz"
+		checksum=63d536e4c1ff8ca13bbf19fdfacbdeedd6af783f759824500faa4216d978e641
+		;;
+esac
+
+post_extract() {
+	$XBPS_FETCH_CMD https://www.sublimehq.com/eula
+	sed -n '
+		/is licensed.*not sold/p
+		/<ol>/,${ /<\/ol>/{x;p;d}; H }
+		$a </ol>
+	' <eula | w3m -dump -I utf-8 -T text/html >EULA
+
+	filesum="$(xbps-digest EULA)"
+	if [ "$filesum" != "$_license_checksum" ]; then
+		msg_error "SHA256 mismatch for EULA:\n$filesum\n"
+	fi
+}
+
+do_install() {
+	vmkdir "usr/bin"
+	vmkdir "usr/lib/sublime_text"
+	cp --preserve=mode -r ./* "${DESTDIR}/usr/lib/sublime_text"
+	vinstall "sublime_text.desktop" 644 "usr/share/applications/"
+	for size in 128 16 256 32 48; do
+		vinstall "Icon/${size}x${size}/sublime-text.png" 644 \
+		 "usr/share/icons/hicolor/${size}x${size}/apps/"
+	done
+	ln -s /usr/lib/sublime_text/sublime_text ${DESTDIR}/usr/bin/subl4
+	vsed -e 's:Exec=/opt/sublime_text/:Exec=/usr/lib/sublime_text/:' \
+	     -i ${DESTDIR}/usr/share/applications/sublime_text.desktop
+	vlicense EULA
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (15 preceding siblings ...)
  2021-09-02 16:15 ` [PR PATCH] [Updated] " DirectorX
@ 2021-09-02 16:16 ` DirectorX
  2021-09-02 19:59 ` Chocimier
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-09-02 16:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

New comment by DirectorX on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-911849138

Comment:
> For vlicense, look at sublime-merge-bin.
> Please sort lines as xlint says: https://github.com/leahneukirchen/xtools/blob/e778aefbcfd0e059f84540dfb90cdf64b4b1316b/xlint#L43

xlint says its A-OK

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (16 preceding siblings ...)
  2021-09-02 16:16 ` DirectorX
@ 2021-09-02 19:59 ` Chocimier
  2021-09-02 21:05 ` ashpooljh
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: Chocimier @ 2021-09-02 19:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-912010902

Comment:
Pretty good. Needs to be `restricted` however.
How is it working when installed?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (17 preceding siblings ...)
  2021-09-02 19:59 ` Chocimier
@ 2021-09-02 21:05 ` ashpooljh
  2021-09-07 16:21 ` [PR PATCH] [Updated] " DirectorX
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ashpooljh @ 2021-09-02 21:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-912056241

Comment:
I've been using the package from this PR for a few weeks now on x86_64. Works for me.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (18 preceding siblings ...)
  2021-09-02 21:05 ` ashpooljh
@ 2021-09-07 16:21 ` DirectorX
  2021-09-07 16:23 ` DirectorX
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-09-07 16:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There is an updated pull request by DirectorX against master on the void-packages repository

https://github.com/DirectorX/void-packages sublime-text4
https://github.com/void-linux/void-packages/pull/31036

New package: sublime-text4-4107
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sublime-text4-31036.patch --]
[-- Type: text/x-diff, Size: 2464 bytes --]

From 5afe4b39babe4e84f77277b8536d2dafda9e13b1 Mon Sep 17 00:00:00 2001
From: DirectorX <DirectorX@users.noreply.github.com>
Date: Fri, 21 May 2021 15:28:47 +0300
Subject: [PATCH] New package: sublime-text4-4113

---
 srcpkgs/sublime-text4/template | 57 ++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 srcpkgs/sublime-text4/template

diff --git a/srcpkgs/sublime-text4/template b/srcpkgs/sublime-text4/template
new file mode 100644
index 000000000000..1cda3af1dd75
--- /dev/null
+++ b/srcpkgs/sublime-text4/template
@@ -0,0 +1,57 @@
+# Template file for 'sublime-text4'
+pkgname=sublime-text4
+version=4113
+revision=1
+archs="x86_64 aarch64"
+wrksrc="sublime_text"
+hostmakedepends="w3m"
+depends="libpng gtk+3 hicolor-icon-theme desktop-file-utils"
+short_desc="Sophisticated text editor for code, markup and prose"
+maintainer="DirectorX <void.directorx@protonmail.com>"
+license="custom:EULA"
+homepage="https://www.sublimetext.com/"
+conflicts="sublime-text3"
+repository="nonfree"
+restricted=yes
+nopie=yes
+_license_checksum=33929b71625d13dacf2a0a5853171b9c04058f71e2955ee660b8d0f8dda45ed1
+
+case "$XBPS_TARGET_MACHINE" in
+		x86_64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_x64.tar.xz"
+		checksum=900ef90fc6453efc4c2b36132a5f16a4db67a226fa9732e4d3c1bf586d4dc78c
+		;;
+		aarch64)
+		distfiles="https://download.sublimetext.com/sublime_text_build_${version}_arm64.tar.xz"
+		checksum=63d536e4c1ff8ca13bbf19fdfacbdeedd6af783f759824500faa4216d978e641
+		;;
+esac
+
+post_extract() {
+	$XBPS_FETCH_CMD https://www.sublimehq.com/eula
+	sed -n '
+		/is licensed.*not sold/p
+		/<ol>/,${ /<\/ol>/{x;p;d}; H }
+		$a </ol>
+	' <eula | w3m -dump -I utf-8 -T text/html >EULA
+
+	filesum="$(xbps-digest EULA)"
+	if [ "$filesum" != "$_license_checksum" ]; then
+		msg_error "SHA256 mismatch for EULA:\n$filesum\n"
+	fi
+}
+
+do_install() {
+	vmkdir "usr/bin"
+	vmkdir "usr/lib/sublime_text"
+	cp --preserve=mode -r ./* "${DESTDIR}/usr/lib/sublime_text"
+	vinstall "sublime_text.desktop" 644 "usr/share/applications/"
+	for size in 128 16 256 32 48; do
+		vinstall "Icon/${size}x${size}/sublime-text.png" 644 \
+		 "usr/share/icons/hicolor/${size}x${size}/apps/"
+	done
+	ln -s /usr/lib/sublime_text/sublime_text ${DESTDIR}/usr/bin/subl4
+	vsed -e 's:Exec=/opt/sublime_text/:Exec=/usr/lib/sublime_text/:' \
+	     -i ${DESTDIR}/usr/share/applications/sublime_text.desktop
+	vlicense EULA
+}

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (19 preceding siblings ...)
  2021-09-07 16:21 ` [PR PATCH] [Updated] " DirectorX
@ 2021-09-07 16:23 ` DirectorX
  2021-09-07 18:48 ` Chocimier
  2021-09-07 18:48 ` [PR PATCH] [Merged]: " Chocimier
  22 siblings, 0 replies; 24+ messages in thread
From: DirectorX @ 2021-09-07 16:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by DirectorX on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-914448368

Comment:
@Chocimier @ericonr I think I've done it

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (20 preceding siblings ...)
  2021-09-07 16:23 ` DirectorX
@ 2021-09-07 18:48 ` Chocimier
  2021-09-07 18:48 ` [PR PATCH] [Merged]: " Chocimier
  22 siblings, 0 replies; 24+ messages in thread
From: Chocimier @ 2021-09-07 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31036#issuecomment-914541967

Comment:
Thanks!

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Merged]: New package: sublime-text4-4107
  2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
                   ` (21 preceding siblings ...)
  2021-09-07 18:48 ` Chocimier
@ 2021-09-07 18:48 ` Chocimier
  22 siblings, 0 replies; 24+ messages in thread
From: Chocimier @ 2021-09-07 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

There's a merged pull request on the void-packages repository

New package: sublime-text4-4107
https://github.com/void-linux/void-packages/pull/31036

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2021-09-07 18:48 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 12:31 [PR PATCH] New package: sublime-text4-4107 DirectorX
2021-05-21 12:32 ` [PR REVIEW] " DirectorX
2021-05-21 13:51 ` marmeladema
2021-05-21 13:57 ` DirectorX
2021-05-21 13:58 ` DirectorX
2021-05-21 17:12 ` [PR PATCH] [Updated] " DirectorX
2021-05-22 23:27 ` ericonr
2021-07-13 14:55 ` jchook
2021-07-13 15:00 ` Nairou
2021-07-13 16:32 ` jchook
2021-07-13 17:04 ` [PR REVIEW] " paper42
2021-07-13 17:17 ` paper42
2021-07-13 17:18 ` paper42
2021-07-31 11:33 ` lopqto
2021-07-31 12:58 ` [PR PATCH] [Updated] " DirectorX
2021-07-31 19:11 ` Chocimier
2021-09-02 16:15 ` [PR PATCH] [Updated] " DirectorX
2021-09-02 16:16 ` DirectorX
2021-09-02 19:59 ` Chocimier
2021-09-02 21:05 ` ashpooljh
2021-09-07 16:21 ` [PR PATCH] [Updated] " DirectorX
2021-09-07 16:23 ` DirectorX
2021-09-07 18:48 ` Chocimier
2021-09-07 18:48 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).