Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] shotcut: remove qt5-webkit-devel dep
@ 2021-08-05 15:14 Hello71
  2021-08-05 15:33 ` ericonr
  2021-08-05 16:48 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 2 replies; 3+ messages in thread
From: Hello71 @ 2021-08-05 15:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

There is a new pull request by Hello71 against master on the void-packages repository

https://github.com/Hello71/void-packages shotcut-no-webkit-dep
https://github.com/void-linux/void-packages/pull/32337

shotcut: remove qt5-webkit-devel dep
shotcut does not use webkit since
https://github.com/mltframework/shotcut/commit/a44fe75a4dc7410668935cd0d3470994f5997571.
no revbump because this is purely build-time change.

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

I have not tested this, but it should result in exactly the same package, which should be shown by CI. Not sure if no-revbump will still trigger CI though.

A patch file from https://github.com/void-linux/void-packages/pull/32337.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shotcut-no-webkit-dep-32337.patch --]
[-- Type: text/x-diff, Size: 1289 bytes --]

From 9445e651266cde4745618e2c0b5f809c5cc53aee Mon Sep 17 00:00:00 2001
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Date: Thu, 5 Aug 2021 11:10:15 -0400
Subject: [PATCH] shotcut: remove qt5-webkit-devel dep

shotcut does not use webkit since
https://github.com/mltframework/shotcut/commit/a44fe75a4dc7410668935cd0d3470994f5997571.
no revbump because this is purely build-time change.
---
 srcpkgs/shotcut/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/shotcut/template b/srcpkgs/shotcut/template
index 5ad51345b231..d0e7d67586f9 100644
--- a/srcpkgs/shotcut/template
+++ b/srcpkgs/shotcut/template
@@ -7,8 +7,8 @@ configure_args="SHOTCUT_VERSION=VOID-$version DEFINES+=SHOTCUT_NOUPGRADE"
 hostmakedepends="pkg-config qt5-tools qt5-qmake qt5-host-tools"
 makedepends="gstreamer1-devel lame-devel libvpx-devel mlt7-devel mlt7-python3
  qt5-declarative-devel qt5-graphicaleffects qt5-multimedia-devel
- qt5-quickcontrols2-devel qt5-webkit-devel qt5-websockets-devel
- qt5-x11extras-devel x264-devel"
+ qt5-quickcontrols2-devel qt5-websockets-devel qt5-x11extras-devel
+ x264-devel"
 depends="frei0r-plugins qt5-graphicaleffects qt5-quickcontrols"
 short_desc="Free, open source, cross-platform video editor"
 maintainer="John <me@johnnynator.dev>"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: shotcut: remove qt5-webkit-devel dep
  2021-08-05 15:14 [PR PATCH] shotcut: remove qt5-webkit-devel dep Hello71
@ 2021-08-05 15:33 ` ericonr
  2021-08-05 16:48 ` [PR PATCH] [Merged]: " ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-08-05 15:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32337#issuecomment-893555938

Comment:
It would trigger CI, but GH is having issues. Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: shotcut: remove qt5-webkit-devel dep
  2021-08-05 15:14 [PR PATCH] shotcut: remove qt5-webkit-devel dep Hello71
  2021-08-05 15:33 ` ericonr
@ 2021-08-05 16:48 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-08-05 16:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

There's a merged pull request on the void-packages repository

shotcut: remove qt5-webkit-devel dep
https://github.com/void-linux/void-packages/pull/32337

Description:
shotcut does not use webkit since
https://github.com/mltframework/shotcut/commit/a44fe75a4dc7410668935cd0d3470994f5997571.
no revbump because this is purely build-time change.

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

I have not tested this, but it should result in exactly the same package, which should be shown by CI. Not sure if no-revbump will still trigger CI though.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-05 16:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 15:14 [PR PATCH] shotcut: remove qt5-webkit-devel dep Hello71
2021-08-05 15:33 ` ericonr
2021-08-05 16:48 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).