Github messages for voidlinux
 help / color / mirror / Atom feed
From: raindev <raindev@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] cronie: prevent from failing without sendmail
Date: Thu, 05 Aug 2021 20:04:20 +0200	[thread overview]
Message-ID: <20210805180420.JnZWwO02JPhMQgoXWnkDg8P63a0uWdq_jpPbmYXcLx8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32341@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

There is an updated pull request by raindev against master on the void-packages repository

https://github.com/raindev/void-packages cronie-syslog
https://github.com/void-linux/void-packages/pull/32341

cronie: prevent from failing without sendmail
If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32341.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-syslog-32341.patch --]
[-- Type: text/x-diff, Size: 1392 bytes --]

From ee86afea159cb60924d31626e8a44eb5581648d9 Mon Sep 17 00:00:00 2001
From: Andrew Barchuk <andrew@raindev.io>
Date: Thu, 5 Aug 2021 19:19:10 +0200
Subject: [PATCH] cronie: prevent from failing without sendmail.

If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.
---
 srcpkgs/cronie/files/cronie/run | 2 +-
 srcpkgs/cronie/template         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index d3045c363c6d..a47453848cb6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-exec cronie-crond -n $OPTS 2>&1
+exec cronie-crond -ns $OPTS 2>&1
diff --git a/srcpkgs/cronie/template b/srcpkgs/cronie/template
index 6c1c7adb523d..b3789c510f8a 100644
--- a/srcpkgs/cronie/template
+++ b/srcpkgs/cronie/template
@@ -1,7 +1,7 @@
 # Template file for 'cronie'
 pkgname=cronie
 version=1.5.7
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-inotify --without-selinux --with-pam
  --enable-anacron --enable-pie --enable-relro"

  parent reply	other threads:[~2021-08-05 18:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 17:31 [PR PATCH] " raindev
2021-08-05 17:45 ` [PR PATCH] [Updated] " raindev
2021-08-05 17:46 ` ericonr
2021-08-05 17:54 ` paper42
2021-08-05 18:02 ` [PR PATCH] [Updated] " raindev
2021-08-05 18:04 ` raindev [this message]
2021-08-05 18:32 ` raindev
2021-08-05 18:32 ` [PR PATCH] [Closed]: " raindev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805180420.JnZWwO02JPhMQgoXWnkDg8P63a0uWdq_jpPbmYXcLx8@z \
    --to=raindev@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).