Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] cronie: prevent from failing without sendmail
@ 2021-08-05 17:31 raindev
  2021-08-05 17:45 ` [PR PATCH] [Updated] " raindev
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: raindev @ 2021-08-05 17:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

There is a new pull request by raindev against master on the void-packages repository

https://github.com/raindev/void-packages cronie-syslog
https://github.com/void-linux/void-packages/pull/32341

cronie: prevent from failing without sendmail
If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32341.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-syslog-32341.patch --]
[-- Type: text/x-diff, Size: 948 bytes --]

From 7257a9268bcc22ca4537bd95a403ac358ff783b0 Mon Sep 17 00:00:00 2001
From: Andrew Barchuk <andrew@raindev.io>
Date: Thu, 5 Aug 2021 19:19:10 +0200
Subject: [PATCH] cronie: prevent from failing without sendmail

If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.
---
 srcpkgs/cronie/files/cronie/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index d3045c363c6d..a47453848cb6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-exec cronie-crond -n $OPTS 2>&1
+exec cronie-crond -ns $OPTS 2>&1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
@ 2021-08-05 17:45 ` raindev
  2021-08-05 17:46 ` ericonr
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: raindev @ 2021-08-05 17:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

There is an updated pull request by raindev against master on the void-packages repository

https://github.com/raindev/void-packages cronie-syslog
https://github.com/void-linux/void-packages/pull/32341

cronie: prevent from failing without sendmail
If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32341.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-syslog-32341.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]

From 8e3dd75224d949b360c101c9ef28d73747b6f9a5 Mon Sep 17 00:00:00 2001
From: Andrew Barchuk <andrew@raindev.io>
Date: Thu, 5 Aug 2021 19:19:10 +0200
Subject: [PATCH] cronie: prevent from failing without sendmail.

If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.
---
 srcpkgs/cronie/files/cronie/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index d3045c363c6d..a47453848cb6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-exec cronie-crond -n $OPTS 2>&1
+exec cronie-crond -ns $OPTS 2>&1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
  2021-08-05 17:45 ` [PR PATCH] [Updated] " raindev
@ 2021-08-05 17:46 ` ericonr
  2021-08-05 17:54 ` paper42
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-08-05 17:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32341#issuecomment-893660300

Comment:
Missing revbump ;)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
  2021-08-05 17:45 ` [PR PATCH] [Updated] " raindev
  2021-08-05 17:46 ` ericonr
@ 2021-08-05 17:54 ` paper42
  2021-08-05 18:02 ` [PR PATCH] [Updated] " raindev
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2021-08-05 17:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32341#issuecomment-893665232

Comment:
`-s` makes cronie log to syslog instead of sendmail even if sendmail is installed, that's probably not what users expect and it would be a breaking change. A proper fix would be to either add sendmail to dependencies or make a patch which fixes this and submit it upstream. but:

Fedora removed sendmail from dependencies in 2010 and they still don't have it:
> remove sendmail from requirements. If it's not installed, it will log into (r)syslog.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
                   ` (2 preceding siblings ...)
  2021-08-05 17:54 ` paper42
@ 2021-08-05 18:02 ` raindev
  2021-08-05 18:04 ` raindev
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: raindev @ 2021-08-05 18:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

There is an updated pull request by raindev against master on the void-packages repository

https://github.com/raindev/void-packages cronie-syslog
https://github.com/void-linux/void-packages/pull/32341

cronie: prevent from failing without sendmail
If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32341.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-syslog-32341.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]

From 792b6e77e1cc5bed3ababf18237b08f5809d6f22 Mon Sep 17 00:00:00 2001
From: Andrew Barchuk <andrew@raindev.io>
Date: Thu, 5 Aug 2021 19:19:10 +0200
Subject: [PATCH] cronie: prevent from failing without sendmail.

If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.
---
 srcpkgs/cronie/files/cronie/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index d3045c363c6d..a47453848cb6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-exec cronie-crond -n $OPTS 2>&1
+exec cronie-crond -ns $OPTS 2>&1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
                   ` (3 preceding siblings ...)
  2021-08-05 18:02 ` [PR PATCH] [Updated] " raindev
@ 2021-08-05 18:04 ` raindev
  2021-08-05 18:32 ` raindev
  2021-08-05 18:32 ` [PR PATCH] [Closed]: " raindev
  6 siblings, 0 replies; 8+ messages in thread
From: raindev @ 2021-08-05 18:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

There is an updated pull request by raindev against master on the void-packages repository

https://github.com/raindev/void-packages cronie-syslog
https://github.com/void-linux/void-packages/pull/32341

cronie: prevent from failing without sendmail
If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32341.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cronie-syslog-32341.patch --]
[-- Type: text/x-diff, Size: 1392 bytes --]

From ee86afea159cb60924d31626e8a44eb5581648d9 Mon Sep 17 00:00:00 2001
From: Andrew Barchuk <andrew@raindev.io>
Date: Thu, 5 Aug 2021 19:19:10 +0200
Subject: [PATCH] cronie: prevent from failing without sendmail.

If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.
---
 srcpkgs/cronie/files/cronie/run | 2 +-
 srcpkgs/cronie/template         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cronie/files/cronie/run b/srcpkgs/cronie/files/cronie/run
index d3045c363c6d..a47453848cb6 100755
--- a/srcpkgs/cronie/files/cronie/run
+++ b/srcpkgs/cronie/files/cronie/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-exec cronie-crond -n $OPTS 2>&1
+exec cronie-crond -ns $OPTS 2>&1
diff --git a/srcpkgs/cronie/template b/srcpkgs/cronie/template
index 6c1c7adb523d..b3789c510f8a 100644
--- a/srcpkgs/cronie/template
+++ b/srcpkgs/cronie/template
@@ -1,7 +1,7 @@
 # Template file for 'cronie'
 pkgname=cronie
 version=1.5.7
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-inotify --without-selinux --with-pam
  --enable-anacron --enable-pie --enable-relro"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
                   ` (4 preceding siblings ...)
  2021-08-05 18:04 ` raindev
@ 2021-08-05 18:32 ` raindev
  2021-08-05 18:32 ` [PR PATCH] [Closed]: " raindev
  6 siblings, 0 replies; 8+ messages in thread
From: raindev @ 2021-08-05 18:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

New comment by raindev on void-packages repository

https://github.com/void-linux/void-packages/pull/32341#issuecomment-893688429

Comment:
Ah, so cronie _does_ handle missing sendmail gracefully. I wrongly assumed the reason one of the jobs is not run was sendmail but it turned out to be the fact that cronie uses `run-parts` to start job scripts, which silently ignores scripts with a `.` in the file name. From `run-parts(8)`:

> the names must consist entirely of ASCII upper- and lower-case letters, ASCII digits, ASCII underscores, and ASCII minus-hyphens.

> Other files and directories are silently ignored.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: cronie: prevent from failing without sendmail
  2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
                   ` (5 preceding siblings ...)
  2021-08-05 18:32 ` raindev
@ 2021-08-05 18:32 ` raindev
  6 siblings, 0 replies; 8+ messages in thread
From: raindev @ 2021-08-05 18:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

There's a closed pull request on the void-packages repository

cronie: prevent from failing without sendmail
https://github.com/void-linux/void-packages/pull/32341

Description:
If a job produces output cronie will attempt to send it's output with
sendmail, failing if the command doesn't exist. sendmail failures are
not handled gracefully and will result in remaining cron scripts to not
be executed. The change makes cronie service use syslog so cron jobs
that produce output are working out of the box.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64, glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-08-05 18:32 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 17:31 [PR PATCH] cronie: prevent from failing without sendmail raindev
2021-08-05 17:45 ` [PR PATCH] [Updated] " raindev
2021-08-05 17:46 ` ericonr
2021-08-05 17:54 ` paper42
2021-08-05 18:02 ` [PR PATCH] [Updated] " raindev
2021-08-05 18:04 ` raindev
2021-08-05 18:32 ` raindev
2021-08-05 18:32 ` [PR PATCH] [Closed]: " raindev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).