Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: k3d-4.4.7
@ 2021-08-05 19:28 klardotsh
  2021-08-05 19:36 ` [PR REVIEW] " ericonr
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: klardotsh @ 2021-08-05 19:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

There is a new pull request by klardotsh against master on the void-packages repository

https://github.com/klardotsh/void-packages klardotsh/k3d
https://github.com/void-linux/void-packages/pull/32349

New package: k3d-4.4.7
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

I'm not a master of k3d by any means - I'm using it as a cheap playground to test out [Tilt](https://tilt.dev) at work (which I might also package today). That said, I successfully created a simple cluster with `k3d cluster create myclusternamehere` using this package, so it seems alright.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32349.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/k3d-32349.patch --]
[-- Type: text/x-diff, Size: 1310 bytes --]

From 509aa947adb50e7d507734672bb0abe1d36dadfc Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Thu, 5 Aug 2021 12:22:21 -0700
Subject: [PATCH] New package: k3d-4.4.7

---
 srcpkgs/k3d/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/k3d/template

diff --git a/srcpkgs/k3d/template b/srcpkgs/k3d/template
new file mode 100644
index 000000000000..9d0d61269680
--- /dev/null
+++ b/srcpkgs/k3d/template
@@ -0,0 +1,23 @@
+# Template file for 'k3d'
+pkgname=k3d
+version=4.4.7
+revision=1
+build_style=go
+go_import_path="github.com/rancher/k3d/v4"
+# explicitly must be v${version} and not just ${version} because k3d uses this
+# to determine which Docker image tag
+# (https://hub.docker.com/r/rancher/k3d-proxy/tags?page=1&ordering=last_updated)
+# to pull. incorrect strings here result in cluster creation
+# failures+rollbacks.
+go_ldflags="-X github.com/rancher/k3d/v4/version.Version=v${version}"
+depends="docker"
+short_desc="Wrapper to run k3s in Docker"
+maintainer="klardotsh <josh@klar.sh>"
+license="MIT"
+homepage="https://github.com/rancher/k3d"
+distfiles="https://github.com/rancher/k3d/archive/v${version}.tar.gz"
+checksum=036685d39397c89c946057ac2e333f157ac460f5251413f1db8629cb7462b58a
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
@ 2021-08-05 19:36 ` ericonr
  2021-08-05 19:39 ` klardotsh
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-08-05 19:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#discussion_r683735284

Comment:
Could it work with podman?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
  2021-08-05 19:36 ` [PR REVIEW] " ericonr
@ 2021-08-05 19:39 ` klardotsh
  2021-08-05 19:40 ` ericonr
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: klardotsh @ 2021-08-05 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by klardotsh on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#discussion_r683736965

Comment:
No: https://github.com/rancher/k3d/issues/84

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
  2021-08-05 19:36 ` [PR REVIEW] " ericonr
  2021-08-05 19:39 ` klardotsh
@ 2021-08-05 19:40 ` ericonr
  2021-08-05 22:03 ` klardotsh
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-08-05 19:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#discussion_r683737763

Comment:
If it will possibly arrive, I'd rather this not depend on `docker`.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
                   ` (2 preceding siblings ...)
  2021-08-05 19:40 ` ericonr
@ 2021-08-05 22:03 ` klardotsh
  2021-08-05 22:59 ` ericonr
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: klardotsh @ 2021-08-05 22:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

New review comment by klardotsh on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#discussion_r683815806

Comment:
From what I can tell in the thread, this isn't being actively worked on, there's no ETA of when or if it may ever get worked on, and for that matter, got punted from a milestone to generic "backlog".

It looks safe to assume that at least for the near term (I'd guess at least 6mo), this is a Docker-only tool, and thus should depend on `docker`.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
                   ` (3 preceding siblings ...)
  2021-08-05 22:03 ` klardotsh
@ 2021-08-05 22:59 ` ericonr
  2021-08-26 20:32 ` klardotsh
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-08-05 22:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#discussion_r683837966

Comment:
Mostly I want to keep flexibility. We shouldn't have this tool be responsible for bringing in docker to people's system, otherwise if anything changes we'll have to figure out a fix, since `docker` will become an orphan package (in some situations).

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
                   ` (4 preceding siblings ...)
  2021-08-05 22:59 ` ericonr
@ 2021-08-26 20:32 ` klardotsh
  2021-08-26 20:34 ` ericonr
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: klardotsh @ 2021-08-26 20:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by klardotsh on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#issuecomment-906723128

Comment:
k3d wound up not working for what I needed, and I moved over to `kind` for running Kubernetes in a Docker world. I'm open to still submitting this package (with `docker` removed as a dependency) if you'd like, or I'm happy to close the PR - whatever you think is best for a package I don't personally use anymore.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
                   ` (5 preceding siblings ...)
  2021-08-26 20:32 ` klardotsh
@ 2021-08-26 20:34 ` ericonr
  2021-08-26 20:39 ` klardotsh
  2021-08-26 20:39 ` [PR PATCH] [Closed]: " klardotsh
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-08-26 20:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#issuecomment-906724354

Comment:
Since no one's else expressed interest, and maintaining a package you don't use can be tiring and harder than it needs to be, i think it's ok to close this.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
                   ` (6 preceding siblings ...)
  2021-08-26 20:34 ` ericonr
@ 2021-08-26 20:39 ` klardotsh
  2021-08-26 20:39 ` [PR PATCH] [Closed]: " klardotsh
  8 siblings, 0 replies; 10+ messages in thread
From: klardotsh @ 2021-08-26 20:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by klardotsh on void-packages repository

https://github.com/void-linux/void-packages/pull/32349#issuecomment-906727012

Comment:
Works for me. Thanks for the feedback on this regardless!

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: k3d-4.4.7
  2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
                   ` (7 preceding siblings ...)
  2021-08-26 20:39 ` klardotsh
@ 2021-08-26 20:39 ` klardotsh
  8 siblings, 0 replies; 10+ messages in thread
From: klardotsh @ 2021-08-26 20:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

There's a closed pull request on the void-packages repository

New package: k3d-4.4.7
https://github.com/void-linux/void-packages/pull/32349

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

I'm not a master of k3d by any means - I'm using it as a cheap playground to test out [Tilt](https://tilt.dev) at work (which I might also package today). That said, I successfully created a simple cluster with `k3d cluster create myclusternamehere` using this package, so it seems alright.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-08-26 20:39 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 19:28 [PR PATCH] New package: k3d-4.4.7 klardotsh
2021-08-05 19:36 ` [PR REVIEW] " ericonr
2021-08-05 19:39 ` klardotsh
2021-08-05 19:40 ` ericonr
2021-08-05 22:03 ` klardotsh
2021-08-05 22:59 ` ericonr
2021-08-26 20:32 ` klardotsh
2021-08-26 20:34 ` ericonr
2021-08-26 20:39 ` klardotsh
2021-08-26 20:39 ` [PR PATCH] [Closed]: " klardotsh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).