[PR PATCH] volctl: update to 0.9.0.

[PR PATCH] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

There is a new pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387

volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1328 bytes --]

From e878660cca05544c727737fdca5d83214070a418 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.

---
 srcpkgs/volctl/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..60e24f017283 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,17 +1,17 @@
 # Template file for 'volctl'
 pkgname=volctl
-version=0.8.2
+version=0.9.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
+checkdepends="${depends} dbus pulseaudio xvfb-run python3-wheel python3-pip"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"
 homepage="https://buzz.github.io/volctl/"
 distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
 
 # There are no tests definded. If they ever add tests, we'll be ready to run them
 do_check() {

Re: [PR REVIEW] volctl: update to 0.9.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684658701

Comment:
they don't have tests, why is this here? can we also remove do_check, because it doesn't do anything?

Re: [PR REVIEW] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684672699

Comment:
https://github.com/void-linux/void-packages/pull/28806#discussion_r578131916
This is the reason.
I am open to delete it.
Ping @ericonr 

Re: [PR REVIEW] volctl: update to 0.9.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684827577

Comment:
Feel free to remove, ahesford's complained about me recommending adding checkdepends when tests aren't defined too.

Re: [PR PATCH] [Updated] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387

volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1357 bytes --]

From c547ee42f739773d08c9a7928b8c1a40a655a7ad Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.

---
 srcpkgs/volctl/template | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..b8e4f0ee3689 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
 # Template file for 'volctl'
 pkgname=volctl
-version=0.8.2
+version=0.9.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"
 homepage="https://buzz.github.io/volctl/"
 distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
-	xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=extended
\ No newline at end of file

Re: [PR PATCH] [Updated] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387

volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1329 bytes --]

From 84fa6d81ac043a09dcf69755b2d8d2917f9c10d0 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.

---
 srcpkgs/volctl/template | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..de3da69c7d30 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
 # Template file for 'volctl'
 pkgname=volctl
-version=0.8.2
+version=0.9.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"
 homepage="https://buzz.github.io/volctl/"
 distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
-	xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=extended

Re: [PR REVIEW] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684832097

Comment:
If make_check=extended is correct, this can be marked as resolved. If I should use make_check=no, let me know.

Re: [PR REVIEW] volctl: update to 0.9.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684832250

Comment:
I suppose it'd be `make_check=no`, since there aren't any to be run.

Re: [PR PATCH] [Updated] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387

volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1323 bytes --]

From cb3775efa00403cc3bac4d55a874467ce8f0e85a Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.

---
 srcpkgs/volctl/template | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..6e952096dad1 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
 # Template file for 'volctl'
 pkgname=volctl
-version=0.8.2
+version=0.9.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"
 homepage="https://buzz.github.io/volctl/"
 distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
-	xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=no

Re: [PR REVIEW] volctl: update to 0.9.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684832384

Comment:
You should use `make_check=no # no tests, but check fails with a non-zero return code` or something similar

Re: [PR REVIEW] volctl: update to 0.9.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684832612

Comment:
oops, I was a few seconds late. Anyway, a comment with the reason would be nice.

Re: [PR PATCH] [Updated] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages update-volctl
https://github.com/void-linux/void-packages/pull/32387

volctl: update to 0.9.0.
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32387.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-volctl-32387.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]

From ddef1c3ef73f6cddddd9b9372b8f2186a0b67b77 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 7 Aug 2021 10:29:30 +0200
Subject: [PATCH] volctl: update to 0.9.0.

---
 srcpkgs/volctl/template | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 294de567a6fb..73e735257f72 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,19 +1,14 @@
 # Template file for 'volctl'
 pkgname=volctl
-version=0.8.2
+version=0.9.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
-checkdepends="${depends} dbus pulseaudio xvfb-run"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"
 homepage="https://buzz.github.io/volctl/"
 distfiles="https://github.com/buzz/volctl/archive/v${version}.tar.gz"
-checksum=8e744fe0e92f00451983e4fffa079d4d5354a8f96f6bcf8d15da44a18dc556f5
-
-# There are no tests definded. If they ever add tests, we'll be ready to run them
-do_check() {
-	xvfb-run dbus-run-session python setup.py test
-}
+checksum=2995653bc506e7af061bec88fdeee973f468c1599f82e2773c0e488a33bb101a
+make_check=no # no tests, but check fails with a non-zero return code

Re: [PR REVIEW] volctl: update to 0.9.0.

[teldra]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/32387#discussion_r684832860

Comment:
@paper42 your are right about a comment. Added.

Re: [PR PATCH] [Merged]: volctl: update to 0.9.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

There's a merged pull request on the void-packages repository

volctl: update to 0.9.0.
https://github.com/void-linux/void-packages/pull/32387

Description:
#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl