Github messages for voidlinux
 help / color / mirror / Atom feed
From: UsernameRandomlyGenerated <UsernameRandomlyGenerated@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] noise-repellent: update to 0.1.5.
Date: Sun, 08 Aug 2021 14:13:30 +0200	[thread overview]
Message-ID: <20210808121330.aZkhXVgQ8ksE_XuhcUuritnoil7Pgj7gcyI_oSg5sqM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31538@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages nre015
https://github.com/void-linux/void-packages/pull/31538

noise-repellent: update to 0.1.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nre015-31538.patch --]
[-- Type: text/x-diff, Size: 4670 bytes --]

From 4bb2c4de14cf38ea7daa0b8913de2c0132e15239 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 17 Jun 2021 11:06:52 +0200
Subject: [PATCH] noise-repellent: update to 0.1.5.

Add patch made by ericonr to fix cross compilation.
---
 .../noise-repellent/patches/fix-cross.patch   | 78 +++++++++++++++++++
 srcpkgs/noise-repellent/template              |  6 +-
 2 files changed, 81 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/noise-repellent/patches/fix-cross.patch

diff --git a/srcpkgs/noise-repellent/patches/fix-cross.patch b/srcpkgs/noise-repellent/patches/fix-cross.patch
new file mode 100644
index 000000000000..183ea572748f
--- /dev/null
+++ b/srcpkgs/noise-repellent/patches/fix-cross.patch
@@ -0,0 +1,78 @@
+From c37f95aa74bc7a4d20548d6475a66190b28fc1ec Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
+Date: Mon, 21 Jun 2021 10:02:12 -0300
+Subject: [PATCH 1/2] Fix cross building and archs other than x86_64/aarch64
+
+- for defining compilation flags and any other information, it's the
+  host machine (where the resulting binary will run) that matters, not
+  the build machine
+- x86_64 optimizations should be enabled only for x86_64; there are many
+  archs other than x86_64 and aarch64
+---
+ meson.build | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 7203bfe..bbf0e67 100755
+--- a/meson.build
++++ b/meson.build
+@@ -20,13 +20,13 @@ add_global_arguments('-ffast-math','-fomit-frame-pointer','-fno-finite-math-only
+ #install folder
+ install_folder = join_paths(get_option('libdir'), 'lv2', meson.project_name())
+ 
+-#get the build operating system and configure install path and shared object extension
+-current_os = build_machine.system()
+-current_arch = build_machine.cpu_family()
++#get the host operating system and configure install path and shared object extension
++current_os = host_machine.system()
++current_arch = host_machine.cpu_family()
+ cflags = []
+ 
+-# Add x86_64 optimization where appropriate (not for ARM)
+-if current_arch != 'aarch64'
++# Add x86_64 optimization
++if current_arch == 'x86_64'
+     cflags += ['-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+@@ -82,4 +82,4 @@ nrepel_ttl = custom_target('nrepel_ttl',
+ if sord_validate.found()
+ 	test('LV2 validation', sord_validate,
+ 		args : [run_command('find','./lv2 -name "*.ttl"').stdout(), run_command('find','. -name "*.ttl"').stdout()])
+-endif
+\ No newline at end of file
++endif
+
+From d0c2939de244a0b9912be02b43ad8d09d6b392bd Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
+Date: Mon, 21 Jun 2021 10:09:49 -0300
+Subject: [PATCH 2/2] Only use -ffast-math for x86_64
+
+This compiler optimization is heavily tested only on x86_64 and can lead
+to issues on other archs, including hangs or wrong behavior.
+---
+ meson.build | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index bbf0e67..4022997 100755
+--- a/meson.build
++++ b/meson.build
+@@ -15,7 +15,7 @@ lv2_dep = dependency('lv2', required : true)
+ nr_dep = [m_dep,fftw_dep,lv2_dep]
+ 
+ #compiler default flags
+-add_global_arguments('-ffast-math','-fomit-frame-pointer','-fno-finite-math-only','-Wno-unused-function',language : 'c')
++add_global_arguments('-fomit-frame-pointer','-fno-finite-math-only','-Wno-unused-function',language : 'c')
+ 
+ #install folder
+ install_folder = join_paths(get_option('libdir'), 'lv2', meson.project_name())
+@@ -27,7 +27,7 @@ cflags = []
+ 
+ # Add x86_64 optimization
+ if current_arch == 'x86_64'
+-    cflags += ['-msse','-msse2','-mfpmath=sse']
++    cflags += ['-ffast-math','-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+ # Add osx multiarch flags when appropriate
diff --git a/srcpkgs/noise-repellent/template b/srcpkgs/noise-repellent/template
index a682812b9d9b..c064532d6540 100644
--- a/srcpkgs/noise-repellent/template
+++ b/srcpkgs/noise-repellent/template
@@ -1,8 +1,8 @@
 # Template file for 'noise-repellent'
 pkgname=noise-repellent
-version=0.1.4
+version=0.1.5
 revision=1
-build_style=gnu-makefile
+build_style=meson
 hostmakedepends="pkg-config"
 makedepends="lv2 fftw-devel"
 short_desc="LV2 plug-in for broadband noise reduction"
@@ -10,4 +10,4 @@ maintainer="Colin Gillespie <colin@breavyn.com>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/lucianodato/noise-repellent"
 distfiles="$homepage/archive/$version.tar.gz"
-checksum=19a2a899b740dd81775f09e03bc09b010725b3366219296f488425beb632c243
+checksum=5f83a1ac4ddb7f92934041f0b5576ad37932bb81e3eb767f2aea78c9f8cfcaae

  parent reply	other threads:[~2021-08-08 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  9:07 [PR PATCH] " UsernameRandomlyGenerated
2021-06-21 12:06 ` ericonr
2021-06-21 13:07 ` ericonr
2021-08-06 18:16 ` UsernameRandomlyGenerated
2021-08-06 18:48 ` ericonr
2021-08-08 12:13 ` UsernameRandomlyGenerated [this message]
2021-08-08 12:14 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-08-08 21:25 ` ericonr
2021-08-09  8:54 ` UsernameRandomlyGenerated
2021-08-09 11:26 ` ericonr
2021-08-09 15:17 ` ericonr
2021-08-10 14:21 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-08-10 14:21 ` UsernameRandomlyGenerated
2021-08-10 14:32 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210808121330.aZkhXVgQ8ksE_XuhcUuritnoil7Pgj7gcyI_oSg5sqM@z \
    --to=usernamerandomlygenerated@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).