Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: libXft-bgra
@ 2021-08-06 18:31 tjk918
  2021-08-08 17:26 ` travankor
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: tjk918 @ 2021-08-06 18:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2150 bytes --]

There is a new pull request by tjk918 against master on the void-packages repository

https://github.com/tjk918/tjk-void-packages master
https://github.com/void-linux/void-packages/pull/32371

New package: libXft-bgra
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

This is just a patched version of libXft that supports BGRA color glyphs and scaling (patch available from [here](https://gitlab.freedesktop.org/xorg/lib/libxft/-/merge_requests/1.patch)). I use st as my terminal emulator, and without this patched version of libXft, st will crash when displaying colored glyphs or emojis. I believe this also applies to dwm and possibly other software as well. 

Back when I used Arch, a similar package was available in the AUR; I've been unable to utilize emojis in my terminal on Void up until now, so having this is extremely nice.

A patch file from https://github.com/void-linux/void-packages/pull/32371.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32371.patch --]
[-- Type: text/x-diff, Size: 2257 bytes --]

From bb87c1a1eaa6c0ff4c3df797892a86c1b288c45b Mon Sep 17 00:00:00 2001
From: Timmy Keller <tjk@tjkeller.xyz>
Date: Fri, 6 Aug 2021 13:10:24 -0500
Subject: [PATCH] New package: libXft-bgra (libXft built with BGRA for color
 glyphs and scaling)

---
 srcpkgs/libXft-bgra/template | 49 ++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 srcpkgs/libXft-bgra/template

diff --git a/srcpkgs/libXft-bgra/template b/srcpkgs/libXft-bgra/template
new file mode 100644
index 000000000000..03b3cb138c8f
--- /dev/null
+++ b/srcpkgs/libXft-bgra/template
@@ -0,0 +1,49 @@
+# Template file for 'libXft-bgra'
+pkgname=libXft-bgra
+version=2.3.4
+revision=1
+build_style=gnu-configure
+hostmakedepends="wget pkg-config"
+makedepends="xorgproto libXrender-devel freetype-devel fontconfig-devel"
+short_desc="Library for configuring and customizing font access"
+maintainer="Timmy Keller <tjk@tjkeller.xyz>"
+license="MIT"
+homepage="$XORG_SITE"
+archive="libXft-${version}.tar.bz2"
+distfiles="${XORG_SITE}/lib/${archive}"
+patchfile="https://gitlab.freedesktop.org/xorg/lib/libxft/-/merge_requests/1.patch"
+checksum=57dedaab20914002146bdae0cb0c769ba3f75214c4c91bd2613d6ef79fc9abdd
+
+pre_extract() {
+	mv "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${archive}" "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}.tar.bz2" || echo "File exists already.. moving on"
+	archive="${pkgname}-${version}.tar.bz2"
+	distfiles="${XORG_SITE}/lib/${archive}" # Trick do_extract into extracting this file
+}
+
+post_extract() {
+	mv "${XBPS_BUILDDIR}/libXft-${version}" "${XBPS_BUILDDIR}/${pkgname}-${version}" || echo "builddir already moved..."
+}
+
+do_patch() {
+	wget -p "${patchfile}" --output-document "${XBPS_SRCDISTDIR}/${pkgname}-${version}/libXft-bgra.patch"
+	echo "Patching..."
+	pwd
+	patch -p1 < "${XBPS_SRCDISTDIR}/${pkgname}-${version}/libXft-bgra.patch"
+}
+
+post_install() {
+	vlicense COPYING
+}
+
+# Does not install libXft-devel
+#libXft-devel_package() {
+#	depends="${makedepends} ${pkgname}>=${version}_${revision}"
+#	short_desc+=" - development files"
+#	pkg_install() {
+#		vmove usr/include
+#		vmove "usr/lib/*.a"
+#		vmove "usr/lib/*.so"
+#		vmove usr/lib/pkgconfig
+#		vmove usr/share/man/man3
+#	}
+#}

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: libXft-bgra
  2021-08-06 18:31 [PR PATCH] New package: libXft-bgra tjk918
@ 2021-08-08 17:26 ` travankor
  2021-08-08 17:27 ` travankor
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: travankor @ 2021-08-08 17:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/32371#issuecomment-894829069

Comment:
Why not add this to the existing libXft package? Void doesn't usually keep custom patched packages that are separate from already-existing packages.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: libXft-bgra
  2021-08-06 18:31 [PR PATCH] New package: libXft-bgra tjk918
  2021-08-08 17:26 ` travankor
@ 2021-08-08 17:27 ` travankor
  2021-08-08 19:32 ` [PR REVIEW] " ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: travankor @ 2021-08-08 17:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/32371#issuecomment-894829069

Comment:
Why not add this to the existing libXft package? Void doesn't usually keep custom patched packages that are separate from already existing packages.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] New package: libXft-bgra
  2021-08-06 18:31 [PR PATCH] New package: libXft-bgra tjk918
                   ` (2 preceding siblings ...)
  2021-08-08 19:32 ` [PR REVIEW] " ericonr
@ 2021-08-08 19:32 ` ericonr
  2021-08-08 19:32 ` [PR PATCH] [Closed]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-08 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32371#discussion_r684818354

Comment:
No reason to leave this block of code in.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] New package: libXft-bgra
  2021-08-06 18:31 [PR PATCH] New package: libXft-bgra tjk918
  2021-08-08 17:26 ` travankor
  2021-08-08 17:27 ` travankor
@ 2021-08-08 19:32 ` ericonr
  2021-08-08 19:32 ` ericonr
  2021-08-08 19:32 ` [PR PATCH] [Closed]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-08 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32371#discussion_r684818298

Comment:
This is not acceptable for templates. Make it a distfile and `no_extract` it, though that will still break if someone pushes new commits into the PR.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: New package: libXft-bgra
  2021-08-06 18:31 [PR PATCH] New package: libXft-bgra tjk918
                   ` (3 preceding siblings ...)
  2021-08-08 19:32 ` ericonr
@ 2021-08-08 19:32 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-08 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]

There's a closed pull request on the void-packages repository

New package: libXft-bgra
https://github.com/void-linux/void-packages/pull/32371

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (amd64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

This is just a patched version of libXft that supports BGRA color glyphs and scaling (patch available from [here](https://gitlab.freedesktop.org/xorg/lib/libxft/-/merge_requests/1.patch)). I use st as my terminal emulator, and without this patched version of libXft, st will crash when displaying colored glyphs or emojis. I believe this also applies to dwm and possibly other software as well. 

Back when I used Arch, a similar package was available in the AUR; I've been unable to utilize emojis in my terminal on Void up until now, so having this is extremely nice.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-08 19:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 18:31 [PR PATCH] New package: libXft-bgra tjk918
2021-08-08 17:26 ` travankor
2021-08-08 17:27 ` travankor
2021-08-08 19:32 ` [PR REVIEW] " ericonr
2021-08-08 19:32 ` ericonr
2021-08-08 19:32 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).