Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] noise-repellent: update to 0.1.5.
@ 2021-06-17  9:07 UsernameRandomlyGenerated
  2021-06-21 12:06 ` ericonr
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-06-17  9:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

There is a new pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages nre015
https://github.com/void-linux/void-packages/pull/31538

noise-repellent: update to 0.1.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nre015-31538.patch --]
[-- Type: text/x-diff, Size: 1151 bytes --]

From 40a2980b321b7f6148d90c9b37c3ebc430a92d3b Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 17 Jun 2021 11:06:52 +0200
Subject: [PATCH] noise-repellent: update to 0.1.5.

---
 srcpkgs/noise-repellent/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/noise-repellent/template b/srcpkgs/noise-repellent/template
index a682812b9d9b..c064532d6540 100644
--- a/srcpkgs/noise-repellent/template
+++ b/srcpkgs/noise-repellent/template
@@ -1,8 +1,8 @@
 # Template file for 'noise-repellent'
 pkgname=noise-repellent
-version=0.1.4
+version=0.1.5
 revision=1
-build_style=gnu-makefile
+build_style=meson
 hostmakedepends="pkg-config"
 makedepends="lv2 fftw-devel"
 short_desc="LV2 plug-in for broadband noise reduction"
@@ -10,4 +10,4 @@ maintainer="Colin Gillespie <colin@breavyn.com>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/lucianodato/noise-repellent"
 distfiles="$homepage/archive/$version.tar.gz"
-checksum=19a2a899b740dd81775f09e03bc09b010725b3366219296f488425beb632c243
+checksum=5f83a1ac4ddb7f92934041f0b5576ad37932bb81e3eb767f2aea78c9f8cfcaae

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
@ 2021-06-21 12:06 ` ericonr
  2021-06-21 13:07 ` ericonr
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-06-21 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-864979727

Comment:
They need to fix their build:

```
 aarch64-linux-gnu-gcc: error: unrecognized command-line option '-msse'
aarch64-linux-gnu-gcc: error: unrecognized command-line option '-msse2'
aarch64-linux-gnu-gcc: error: unrecognized command-line option '-mfpmath=sse'
```

Specifically, https://github.com/lucianodato/noise-repellent/blob/master/meson.build#L23 is just wrong.

It's not build machine that matters, it's the `host_machine`, and checking if `arch` isn't `aarch64` to enable x86_64 only optimization is also wrong, since they should be checking if arch is `x86_64`. I might make a PR their way later to fix this.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
  2021-06-21 12:06 ` ericonr
@ 2021-06-21 13:07 ` ericonr
  2021-08-06 18:16 ` UsernameRandomlyGenerated
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-06-21 13:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-865017608

Comment:
https://github.com/lucianodato/noise-repellent/pull/77

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
  2021-06-21 12:06 ` ericonr
  2021-06-21 13:07 ` ericonr
@ 2021-08-06 18:16 ` UsernameRandomlyGenerated
  2021-08-06 18:48 ` ericonr
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-08-06 18:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-894435160

Comment:
Should I just add your commits as patches in this PR as developer doesn't seem very active?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (2 preceding siblings ...)
  2021-08-06 18:16 ` UsernameRandomlyGenerated
@ 2021-08-06 18:48 ` ericonr
  2021-08-08 12:13 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-06 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-894452536

Comment:
Yeah probably. https://patch-diff.githubusercontent.com/raw/lucianodato/noise-repellent/pull/77.patch

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (3 preceding siblings ...)
  2021-08-06 18:48 ` ericonr
@ 2021-08-08 12:13 ` UsernameRandomlyGenerated
  2021-08-08 12:14 ` UsernameRandomlyGenerated
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-08-08 12:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages nre015
https://github.com/void-linux/void-packages/pull/31538

noise-repellent: update to 0.1.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nre015-31538.patch --]
[-- Type: text/x-diff, Size: 4670 bytes --]

From 4bb2c4de14cf38ea7daa0b8913de2c0132e15239 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 17 Jun 2021 11:06:52 +0200
Subject: [PATCH] noise-repellent: update to 0.1.5.

Add patch made by ericonr to fix cross compilation.
---
 .../noise-repellent/patches/fix-cross.patch   | 78 +++++++++++++++++++
 srcpkgs/noise-repellent/template              |  6 +-
 2 files changed, 81 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/noise-repellent/patches/fix-cross.patch

diff --git a/srcpkgs/noise-repellent/patches/fix-cross.patch b/srcpkgs/noise-repellent/patches/fix-cross.patch
new file mode 100644
index 000000000000..183ea572748f
--- /dev/null
+++ b/srcpkgs/noise-repellent/patches/fix-cross.patch
@@ -0,0 +1,78 @@
+From c37f95aa74bc7a4d20548d6475a66190b28fc1ec Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
+Date: Mon, 21 Jun 2021 10:02:12 -0300
+Subject: [PATCH 1/2] Fix cross building and archs other than x86_64/aarch64
+
+- for defining compilation flags and any other information, it's the
+  host machine (where the resulting binary will run) that matters, not
+  the build machine
+- x86_64 optimizations should be enabled only for x86_64; there are many
+  archs other than x86_64 and aarch64
+---
+ meson.build | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 7203bfe..bbf0e67 100755
+--- a/meson.build
++++ b/meson.build
+@@ -20,13 +20,13 @@ add_global_arguments('-ffast-math','-fomit-frame-pointer','-fno-finite-math-only
+ #install folder
+ install_folder = join_paths(get_option('libdir'), 'lv2', meson.project_name())
+ 
+-#get the build operating system and configure install path and shared object extension
+-current_os = build_machine.system()
+-current_arch = build_machine.cpu_family()
++#get the host operating system and configure install path and shared object extension
++current_os = host_machine.system()
++current_arch = host_machine.cpu_family()
+ cflags = []
+ 
+-# Add x86_64 optimization where appropriate (not for ARM)
+-if current_arch != 'aarch64'
++# Add x86_64 optimization
++if current_arch == 'x86_64'
+     cflags += ['-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+@@ -82,4 +82,4 @@ nrepel_ttl = custom_target('nrepel_ttl',
+ if sord_validate.found()
+ 	test('LV2 validation', sord_validate,
+ 		args : [run_command('find','./lv2 -name "*.ttl"').stdout(), run_command('find','. -name "*.ttl"').stdout()])
+-endif
+\ No newline at end of file
++endif
+
+From d0c2939de244a0b9912be02b43ad8d09d6b392bd Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
+Date: Mon, 21 Jun 2021 10:09:49 -0300
+Subject: [PATCH 2/2] Only use -ffast-math for x86_64
+
+This compiler optimization is heavily tested only on x86_64 and can lead
+to issues on other archs, including hangs or wrong behavior.
+---
+ meson.build | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index bbf0e67..4022997 100755
+--- a/meson.build
++++ b/meson.build
+@@ -15,7 +15,7 @@ lv2_dep = dependency('lv2', required : true)
+ nr_dep = [m_dep,fftw_dep,lv2_dep]
+ 
+ #compiler default flags
+-add_global_arguments('-ffast-math','-fomit-frame-pointer','-fno-finite-math-only','-Wno-unused-function',language : 'c')
++add_global_arguments('-fomit-frame-pointer','-fno-finite-math-only','-Wno-unused-function',language : 'c')
+ 
+ #install folder
+ install_folder = join_paths(get_option('libdir'), 'lv2', meson.project_name())
+@@ -27,7 +27,7 @@ cflags = []
+ 
+ # Add x86_64 optimization
+ if current_arch == 'x86_64'
+-    cflags += ['-msse','-msse2','-mfpmath=sse']
++    cflags += ['-ffast-math','-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+ # Add osx multiarch flags when appropriate
diff --git a/srcpkgs/noise-repellent/template b/srcpkgs/noise-repellent/template
index a682812b9d9b..c064532d6540 100644
--- a/srcpkgs/noise-repellent/template
+++ b/srcpkgs/noise-repellent/template
@@ -1,8 +1,8 @@
 # Template file for 'noise-repellent'
 pkgname=noise-repellent
-version=0.1.4
+version=0.1.5
 revision=1
-build_style=gnu-makefile
+build_style=meson
 hostmakedepends="pkg-config"
 makedepends="lv2 fftw-devel"
 short_desc="LV2 plug-in for broadband noise reduction"
@@ -10,4 +10,4 @@ maintainer="Colin Gillespie <colin@breavyn.com>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/lucianodato/noise-repellent"
 distfiles="$homepage/archive/$version.tar.gz"
-checksum=19a2a899b740dd81775f09e03bc09b010725b3366219296f488425beb632c243
+checksum=5f83a1ac4ddb7f92934041f0b5576ad37932bb81e3eb767f2aea78c9f8cfcaae

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (4 preceding siblings ...)
  2021-08-08 12:13 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
@ 2021-08-08 12:14 ` UsernameRandomlyGenerated
  2021-08-08 21:25 ` ericonr
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-08-08 12:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages nre015
https://github.com/void-linux/void-packages/pull/31538

noise-repellent: update to 0.1.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nre015-31538.patch --]
[-- Type: text/x-diff, Size: 4670 bytes --]

From 81fd8f341c663934383ed2ca7cf3ea482ba5efd0 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 17 Jun 2021 11:06:52 +0200
Subject: [PATCH] noise-repellent: update to 0.1.5.

Add patch made by ericonr to fix cross compilation.
---
 .../noise-repellent/patches/fix-cross.patch   | 78 +++++++++++++++++++
 srcpkgs/noise-repellent/template              |  6 +-
 2 files changed, 81 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/noise-repellent/patches/fix-cross.patch

diff --git a/srcpkgs/noise-repellent/patches/fix-cross.patch b/srcpkgs/noise-repellent/patches/fix-cross.patch
new file mode 100644
index 000000000000..183ea572748f
--- /dev/null
+++ b/srcpkgs/noise-repellent/patches/fix-cross.patch
@@ -0,0 +1,78 @@
+From c37f95aa74bc7a4d20548d6475a66190b28fc1ec Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
+Date: Mon, 21 Jun 2021 10:02:12 -0300
+Subject: [PATCH 1/2] Fix cross building and archs other than x86_64/aarch64
+
+- for defining compilation flags and any other information, it's the
+  host machine (where the resulting binary will run) that matters, not
+  the build machine
+- x86_64 optimizations should be enabled only for x86_64; there are many
+  archs other than x86_64 and aarch64
+---
+ meson.build | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 7203bfe..bbf0e67 100755
+--- a/meson.build
++++ b/meson.build
+@@ -20,13 +20,13 @@ add_global_arguments('-ffast-math','-fomit-frame-pointer','-fno-finite-math-only
+ #install folder
+ install_folder = join_paths(get_option('libdir'), 'lv2', meson.project_name())
+ 
+-#get the build operating system and configure install path and shared object extension
+-current_os = build_machine.system()
+-current_arch = build_machine.cpu_family()
++#get the host operating system and configure install path and shared object extension
++current_os = host_machine.system()
++current_arch = host_machine.cpu_family()
+ cflags = []
+ 
+-# Add x86_64 optimization where appropriate (not for ARM)
+-if current_arch != 'aarch64'
++# Add x86_64 optimization
++if current_arch == 'x86_64'
+     cflags += ['-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+@@ -82,4 +82,4 @@ nrepel_ttl = custom_target('nrepel_ttl',
+ if sord_validate.found()
+ 	test('LV2 validation', sord_validate,
+ 		args : [run_command('find','./lv2 -name "*.ttl"').stdout(), run_command('find','. -name "*.ttl"').stdout()])
+-endif
+\ No newline at end of file
++endif
+
+From d0c2939de244a0b9912be02b43ad8d09d6b392bd Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
+Date: Mon, 21 Jun 2021 10:09:49 -0300
+Subject: [PATCH 2/2] Only use -ffast-math for x86_64
+
+This compiler optimization is heavily tested only on x86_64 and can lead
+to issues on other archs, including hangs or wrong behavior.
+---
+ meson.build | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index bbf0e67..4022997 100755
+--- a/meson.build
++++ b/meson.build
+@@ -15,7 +15,7 @@ lv2_dep = dependency('lv2', required : true)
+ nr_dep = [m_dep,fftw_dep,lv2_dep]
+ 
+ #compiler default flags
+-add_global_arguments('-ffast-math','-fomit-frame-pointer','-fno-finite-math-only','-Wno-unused-function',language : 'c')
++add_global_arguments('-fomit-frame-pointer','-fno-finite-math-only','-Wno-unused-function',language : 'c')
+ 
+ #install folder
+ install_folder = join_paths(get_option('libdir'), 'lv2', meson.project_name())
+@@ -27,7 +27,7 @@ cflags = []
+ 
+ # Add x86_64 optimization
+ if current_arch == 'x86_64'
+-    cflags += ['-msse','-msse2','-mfpmath=sse']
++    cflags += ['-ffast-math','-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+ # Add osx multiarch flags when appropriate
diff --git a/srcpkgs/noise-repellent/template b/srcpkgs/noise-repellent/template
index a682812b9d9b..c064532d6540 100644
--- a/srcpkgs/noise-repellent/template
+++ b/srcpkgs/noise-repellent/template
@@ -1,8 +1,8 @@
 # Template file for 'noise-repellent'
 pkgname=noise-repellent
-version=0.1.4
+version=0.1.5
 revision=1
-build_style=gnu-makefile
+build_style=meson
 hostmakedepends="pkg-config"
 makedepends="lv2 fftw-devel"
 short_desc="LV2 plug-in for broadband noise reduction"
@@ -10,4 +10,4 @@ maintainer="Colin Gillespie <colin@breavyn.com>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/lucianodato/noise-repellent"
 distfiles="$homepage/archive/$version.tar.gz"
-checksum=19a2a899b740dd81775f09e03bc09b010725b3366219296f488425beb632c243
+checksum=5f83a1ac4ddb7f92934041f0b5576ad37932bb81e3eb767f2aea78c9f8cfcaae

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (5 preceding siblings ...)
  2021-08-08 12:14 ` UsernameRandomlyGenerated
@ 2021-08-08 21:25 ` ericonr
  2021-08-09  8:54 ` UsernameRandomlyGenerated
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-08 21:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-894857878

Comment:
Hm, you might have to fold that PR into a single diff, or I guess just import two separate patches (and add ordering to them, so `01-foo.patch` and `02-bar.patch`)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (6 preceding siblings ...)
  2021-08-08 21:25 ` ericonr
@ 2021-08-09  8:54 ` UsernameRandomlyGenerated
  2021-08-09 11:26 ` ericonr
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-08-09  8:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-895056066

Comment:
It's weird, even if I add only the first commit as patch the result is the same error. 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (7 preceding siblings ...)
  2021-08-09  8:54 ` UsernameRandomlyGenerated
@ 2021-08-09 11:26 ` ericonr
  2021-08-09 15:17 ` ericonr
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-09 11:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-895146953

Comment:
I can try to provide you a proper diff. I guess there must have been a big change in the file between the release and my PR.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (8 preceding siblings ...)
  2021-08-09 11:26 ` ericonr
@ 2021-08-09 15:17 ` ericonr
  2021-08-10 14:21 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-09 15:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-895312324

Comment:
Can you make a patch based on mine for the 0.1.5 release? It seems they changed the file a bunch.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (9 preceding siblings ...)
  2021-08-09 15:17 ` ericonr
@ 2021-08-10 14:21 ` UsernameRandomlyGenerated
  2021-08-10 14:21 ` UsernameRandomlyGenerated
  2021-08-10 14:32 ` [PR PATCH] [Merged]: " ericonr
  12 siblings, 0 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-08-10 14:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages nre015
https://github.com/void-linux/void-packages/pull/31538

noise-repellent: update to 0.1.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nre015-31538.patch --]
[-- Type: text/x-diff, Size: 2707 bytes --]

From 527c110f3bb9a2764050e268c904d0c9a86f88d4 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 17 Jun 2021 11:06:52 +0200
Subject: [PATCH] noise-repellent: update to 0.1.5.

Add patch made by ericonr to fix cross compilation.
---
 .../noise-repellent/patches/fix-cross.patch   | 28 +++++++++++++++++++
 srcpkgs/noise-repellent/template              |  6 ++--
 2 files changed, 31 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/noise-repellent/patches/fix-cross.patch

diff --git a/srcpkgs/noise-repellent/patches/fix-cross.patch b/srcpkgs/noise-repellent/patches/fix-cross.patch
new file mode 100644
index 000000000000..5818349fb9b0
--- /dev/null
+++ b/srcpkgs/noise-repellent/patches/fix-cross.patch
@@ -0,0 +1,28 @@
+--- a/meson.build	2020-01-04 02:27:45.000000000 +0100
++++ b/meson.build	2021-08-10 16:17:03.828663592 +0200
+@@ -17,19 +17,19 @@
+ if meson.get_compiler('c').get_id() == 'clang'
+   add_global_arguments('-mrecip', language : 'c')
+ endif
+-cflags = ['-ffast-math','-fomit-frame-pointer','-fno-finite-math-only']
++cflags = ['-fomit-frame-pointer','-fno-finite-math-only']
+ cflags += ['-Wno-unused-function']
+ 
+ #install folder
+ install_folder = 'nrepel.lv2'
+ 
+-#get the build operating system and configure install path and shared object extension
+-current_os = build_machine.system()
+-current_arch = build_machine.cpu_family()
++#get the host operating system and configure install path and shared object extension
++current_os = host_machine.system()
++current_arch = host_machine.cpu_family()
+ 
+ # Add x86_64 optimization where appropriate (not for ARM)
+-if current_arch != 'aarch64'
+-    cflags += ['-msse','-msse2','-mfpmath=sse']
++if current_arch == 'x86_64'
++    cflags += ['-ffast-math','-msse','-msse2','-mfpmath=sse']
+ endif
+ 
+ # Add osx multiarch flags when appropriate
diff --git a/srcpkgs/noise-repellent/template b/srcpkgs/noise-repellent/template
index a682812b9d9b..c064532d6540 100644
--- a/srcpkgs/noise-repellent/template
+++ b/srcpkgs/noise-repellent/template
@@ -1,8 +1,8 @@
 # Template file for 'noise-repellent'
 pkgname=noise-repellent
-version=0.1.4
+version=0.1.5
 revision=1
-build_style=gnu-makefile
+build_style=meson
 hostmakedepends="pkg-config"
 makedepends="lv2 fftw-devel"
 short_desc="LV2 plug-in for broadband noise reduction"
@@ -10,4 +10,4 @@ maintainer="Colin Gillespie <colin@breavyn.com>"
 license="LGPL-3.0-or-later"
 homepage="https://github.com/lucianodato/noise-repellent"
 distfiles="$homepage/archive/$version.tar.gz"
-checksum=19a2a899b740dd81775f09e03bc09b010725b3366219296f488425beb632c243
+checksum=5f83a1ac4ddb7f92934041f0b5576ad37932bb81e3eb767f2aea78c9f8cfcaae

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (10 preceding siblings ...)
  2021-08-10 14:21 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
@ 2021-08-10 14:21 ` UsernameRandomlyGenerated
  2021-08-10 14:32 ` [PR PATCH] [Merged]: " ericonr
  12 siblings, 0 replies; 14+ messages in thread
From: UsernameRandomlyGenerated @ 2021-08-10 14:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/31538#issuecomment-896072580

Comment:
Done, it should work now.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Merged]: noise-repellent: update to 0.1.5.
  2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
                   ` (11 preceding siblings ...)
  2021-08-10 14:21 ` UsernameRandomlyGenerated
@ 2021-08-10 14:32 ` ericonr
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-08-10 14:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

There's a merged pull request on the void-packages repository

noise-repellent: update to 0.1.5.
https://github.com/void-linux/void-packages/pull/31538

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-08-10 14:32 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17  9:07 [PR PATCH] noise-repellent: update to 0.1.5 UsernameRandomlyGenerated
2021-06-21 12:06 ` ericonr
2021-06-21 13:07 ` ericonr
2021-08-06 18:16 ` UsernameRandomlyGenerated
2021-08-06 18:48 ` ericonr
2021-08-08 12:13 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-08-08 12:14 ` UsernameRandomlyGenerated
2021-08-08 21:25 ` ericonr
2021-08-09  8:54 ` UsernameRandomlyGenerated
2021-08-09 11:26 ` ericonr
2021-08-09 15:17 ` ericonr
2021-08-10 14:21 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-08-10 14:21 ` UsernameRandomlyGenerated
2021-08-10 14:32 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).