Github messages for voidlinux
 help / color / mirror / Atom feed
From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: ngx_headers_more-0.33
Date: Sat, 14 Aug 2021 22:31:34 +0200	[thread overview]
Message-ID: <20210814203134.2ibdUe-DQh1x9xpYMG7w-c9vbRRkccSq-xhhh1C6xZo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30257@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/30257#discussion_r688988853

Comment:
I feel like something is pretty wrong here regarding cross builds, this just copied the nginx template with removing all the actual cross platform setup required.
Wouldn't be surprised if the cross compiled binaries use wrong sizes etc.

  parent reply	other threads:[~2021-08-14 20:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  2:06 [PR PATCH] " AluminumTank
2021-04-16 21:15 ` [PR PATCH] [Updated] " AluminumTank
2021-04-16 21:16 ` AluminumTank
2021-04-16 21:28 ` AluminumTank
2021-08-11 20:59 ` [PR REVIEW] " paper42
2021-08-11 20:59 ` paper42
2021-08-11 20:59 ` paper42
2021-08-11 20:59 ` paper42
2021-08-11 20:59 ` paper42
2021-08-11 20:59 ` paper42
2021-08-11 21:23 ` paper42
2021-08-14 19:05 ` AluminumTank
2021-08-14 19:05 ` AluminumTank
2021-08-14 19:14 ` [PR PATCH] [Updated] " AluminumTank
2021-08-14 19:18 ` [PR REVIEW] " AluminumTank
2021-08-14 19:19 ` AluminumTank
2021-08-14 19:27 ` [PR PATCH] [Updated] " AluminumTank
2021-08-14 19:27 ` [PR REVIEW] " AluminumTank
2021-08-14 19:29 ` Duncaen
2021-08-14 19:29 ` Duncaen
2021-08-14 19:29 ` Duncaen
2021-08-14 19:30 ` Duncaen
2021-08-14 19:30 ` Duncaen
2021-08-14 19:31 ` Duncaen
2021-08-14 20:13 ` paper42
2021-08-14 20:15 ` paper42
2021-08-14 20:21 ` Duncaen
2021-08-14 20:24 ` paper42
2021-08-14 20:31 ` Duncaen [this message]
2021-08-14 20:36 ` Duncaen
2021-08-16 12:39 ` [PR PATCH] [Updated] " AluminumTank
2021-09-10 14:32 ` New package: nginx-mod-headers-more-0.33 TinfoilSubmarine
2021-09-10 15:44 ` [PR PATCH] [Updated] " TinfoilSubmarine
2021-09-10 15:47 ` TinfoilSubmarine
2021-09-10 15:52 ` TinfoilSubmarine
2021-09-10 16:18 ` TinfoilSubmarine
2021-09-17 14:43 ` [PR PATCH] [Updated] " TinfoilSubmarine
2021-09-17 14:47 ` TinfoilSubmarine
2021-09-17 14:48 ` TinfoilSubmarine
2021-09-17 15:59 ` [PR PATCH] [Updated] " TinfoilSubmarine
2021-09-17 16:02 ` TinfoilSubmarine
2021-11-16 13:40 ` TinfoilSubmarine
2021-11-16 13:40 ` [PR PATCH] [Closed]: " TinfoilSubmarine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210814203134.2ibdUe-DQh1x9xpYMG7w-c9vbRRkccSq-xhhh1C6xZo@z \
    --to=duncaen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).