Github messages for voidlinux
 help / color / mirror / Atom feed
From: 4ricci <4ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [WIP] speed-dreams: update to 2.2.3.
Date: Sat, 14 Aug 2021 23:26:31 +0200	[thread overview]
Message-ID: <20210814212631.YpfLucI2vFdvD82Lw-vpJINGzlsbV9PHUxM8bZJWyoo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32474@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/32474#discussion_r688993710

Comment:
When cmake policy [CMP0072](https://cmake.org/cmake/help/v3.21/policy/CMP0072.html) is set to `NEW`, linking with `--as-needed` fails. Should I patch `CMakeLists.txt` to use the legacy library or just use `--no-as-needed`?

  parent reply	other threads:[~2021-08-14 21:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 22:39 [PR PATCH] " 4ricci
2021-08-13 11:29 ` [PR PATCH] [Updated] " 4ricci
2021-08-13 11:32 ` 4ricci
2021-08-13 12:44 ` [PR REVIEW] " ericonr
2021-08-13 12:45 ` ericonr
2021-08-13 14:15 ` [PR REVIEW] " 4ricci
2021-08-13 15:50 ` [PR PATCH] [Updated] [WIP] " 4ricci
2021-08-13 15:55 ` 4ricci
2021-08-13 17:48 ` [PR REVIEW] " paper42
2021-08-13 18:23 ` 4ricci
2021-08-14  0:54 ` ericonr
2021-08-14  0:54 ` ericonr
2021-08-14 21:26 ` 4ricci [this message]
2021-08-14 21:28 ` [PR PATCH] [Updated] " 4ricci
2021-08-15  3:53 ` [PR REVIEW] " ericonr
2021-08-15 16:51 ` 4ricci
2021-08-17 15:03 ` [PR PATCH] [Updated] " 4ricci
2021-08-30  3:10 ` ericonr
2021-08-30  3:23 ` ericonr
2021-08-30  3:32 ` [PR PATCH] [Updated] " ericonr
2021-08-30  3:32 ` ericonr
2021-08-30  3:33 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210814212631.YpfLucI2vFdvD82Lw-vpJINGzlsbV9PHUxM8bZJWyoo@z \
    --to=4ricci@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).