From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ffmpeg: remove ffplay subpackage
Date: Mon, 16 Aug 2021 23:02:56 +0200 [thread overview]
Message-ID: <20210816210256.M-DKX6fngdklgaEeYTgXUjqmLHNVGVar5jI4F_uNA4Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32519@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32519#discussion_r689857486
Comment:
This feels somewhat fragile, since we could miss any defines added by configure scripts and what not. I'd almost say building the entire thing and just taking the binary afterwards is safer.
next prev parent reply other threads:[~2021-08-16 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 20:58 [PR PATCH] " paper42
2021-08-16 21:02 ` ericonr [this message]
2021-08-16 22:45 ` paper42
2021-08-16 22:45 ` [PR PATCH] [Closed]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816210256.M-DKX6fngdklgaEeYTgXUjqmLHNVGVar5jI4F_uNA4Q@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).