[PR PATCH] kopia: add bash and zsh completions.

[PR PATCH] kopia: add bash and zsh completions.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages kopia-add-completions
https://github.com/void-linux/void-packages/pull/32525

kopia: add bash and zsh completions.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/32525.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kopia-add-completions-32525.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From 040ae8603c22db0c9004a0e9031cc0d07a009fdd Mon Sep 17 00:00:00 2001
From: Abigail G <dev@kb6.ee>
Date: Mon, 16 Aug 2021 21:29:00 -0400
Subject: [PATCH] kopia: add bash and zsh completions.

---
 srcpkgs/kopia/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kopia/template b/srcpkgs/kopia/template
index 9dac954fb965..79d213171066 100644
--- a/srcpkgs/kopia/template
+++ b/srcpkgs/kopia/template
@@ -1,7 +1,7 @@
 # Template file for 'kopia'
 pkgname=kopia
 version=0.8.4
-revision=1
+revision=2
 build_style=go
 go_import_path=github.com/kopia/kopia
 go_ldflags="-X ${go_import_path}/repo.BuildVersion=${version}
@@ -12,3 +12,10 @@ license="Apache-2.0"
 homepage="https://kopia.io/"
 distfiles="https://github.com/kopia/kopia/archive/v${version}.tar.gz"
 checksum=8e2663546fb426faacb4dd9425cdbba4fa2e8ca5df0aac0545d216c8e57d40ef
+
+post_install() {
+	${DESTDIR}/usr/bin/${pkgname} --completion-script-bash > completions.bash
+	${DESTDIR}/usr/bin/${pkgname} --completion-script-zsh > completions.zsh
+	vcompletion completions.bash bash
+	vcompletion completions.zsh zsh
+}

Re: kopia: add bash and zsh completions.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/32525#issuecomment-899928026

Comment:
It seems my change was naïve, and doesn't work on the cross-compile builds.

Kopia doesn't provide completions in the build output, but instead requires running the binary itself with a flag as [shown here](https://github.com/alecthomas/kingpin/tree/v2.2.6#bashzsh-shell-completion) in the README of the library it uses for CLI arg parsing.

Can this be done somehow within xbps or should it be fixed upstream?

Re: kopia: add bash and zsh completions.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/32525#issuecomment-899928026

Comment:
It seems my change was naïve, and doesn't work on the cross-compile builds.

Kopia doesn't provide completions in the build output, but instead requires running the binary itself with a flag as [shown here](https://github.com/alecthomas/kingpin/tree/v2.2.6#bashzsh-shell-completion) in the README of the library it uses for CLI arg parsing.

Can this be done somehow within xbps on all archs or should it be fixed upstream?

Re: kopia: add bash and zsh completions.

[ram02z]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/32525#issuecomment-899929350

Comment:
@classabbyamp I used [this](https://github.com/void-linux/void-packages/pull/29316) as a template when I needed to run the binary in order to generate shell completions. You need `qemu` as the build helper.

Re: [PR PATCH] [Updated] kopia: add bash and zsh completions.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages kopia-add-completions
https://github.com/void-linux/void-packages/pull/32525

kopia: add bash and zsh completions.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/32525.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kopia-add-completions-32525.patch --]
[-- Type: text/x-diff, Size: 1150 bytes --]

From e86a91322185312489b8996b6ce3f4c0c176d34a Mon Sep 17 00:00:00 2001
From: Abigail G <dev@kb6.ee>
Date: Mon, 16 Aug 2021 21:29:00 -0400
Subject: [PATCH] kopia: add bash and zsh completions.

---
 srcpkgs/kopia/template | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kopia/template b/srcpkgs/kopia/template
index 9dac954fb965..709f34e80bd8 100644
--- a/srcpkgs/kopia/template
+++ b/srcpkgs/kopia/template
@@ -1,8 +1,9 @@
 # Template file for 'kopia'
 pkgname=kopia
 version=0.8.4
-revision=1
+revision=2
 build_style=go
+build_helper="qemu"
 go_import_path=github.com/kopia/kopia
 go_ldflags="-X ${go_import_path}/repo.BuildVersion=${version}
  -X '${go_import_path}/repo.BuildInfo=Void Linux'"
@@ -12,3 +13,10 @@ license="Apache-2.0"
 homepage="https://kopia.io/"
 distfiles="https://github.com/kopia/kopia/archive/v${version}.tar.gz"
 checksum=8e2663546fb426faacb4dd9425cdbba4fa2e8ca5df0aac0545d216c8e57d40ef
+
+post_install() {
+	for shell in bash zsh; do
+		vtargetrun ${DESTDIR}/usr/bin/${pkgname} --completion-script-${shell} > completions.${shell}
+		vcompletion completions.${shell} ${shell}
+	done
+}

Re: kopia: add bash and zsh completions.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/32525#issuecomment-899943508

Comment:
thanks @ram02z, should be all working now

Re: [PR PATCH] [Merged]: kopia: add bash and zsh completions.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

There's a merged pull request on the void-packages repository

kopia: add bash and zsh completions.
https://github.com/void-linux/void-packages/pull/32525

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl