From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] giac: update to 1.7.0.25.
Date: Wed, 18 Aug 2021 16:39:50 +0200 [thread overview]
Message-ID: <20210818143950.1Ie_q2gHjIQqRCuJ89Y2BHH5pOxjJp0avRRodijhXYM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32558@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/32558#discussion_r691304177
Comment:
This means adding `AC_CHECK_FUNCS(mallinfo)` in `configure.ac` and replacing the test by `#ifdef HAVE_MALLINFO` or something like that?
I think the few cases where they check `HAVE_MALLOC_H` is just to use`mallinfo()`.
Is it worth doing that for us, or proposing it to upstream? It seems a chore having to deal with autoconf since the patch above works ok for us.
next prev parent reply other threads:[~2021-08-18 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 21:22 [PR PATCH] " tornaria
2021-08-17 21:40 ` tornaria
2021-08-18 2:37 ` [PR REVIEW] " ericonr
2021-08-18 2:37 ` ericonr
2021-08-18 8:58 ` dkwo
2021-08-18 14:39 ` tornaria [this message]
2021-08-18 14:53 ` [PR REVIEW] " ericonr
2021-08-18 18:48 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818143950.1Ie_q2gHjIQqRCuJ89Y2BHH5pOxjJp0avRRodijhXYM@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).