Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: notcurses: update to 2.3.15.
Date: Wed, 18 Aug 2021 20:46:28 +0200	[thread overview]
Message-ID: <20210818184628.h_--n-4mS1UJjK7NEIyxxfXvBB2TgsLFhr1jucij7oU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32563@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32563#issuecomment-901346788

Comment:
```
[263/392] Building CXX object CMakeFiles/ncls.dir/src/ls/main.cpp.o
FAILED: CMakeFiles/ncls.dir/src/ls/main.cpp.o 
/builddir/.xbps-notcurses/wrappers/arm-linux-musleabihf-c++ -D_DEFAULT_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_XOPEN_SOURCE=700 -I/builddir/notcurses-2.3.15/include -I/builddir/notcurses-2.3.15/src -I/builddir/notcurses-2.3.15 -I/builddir/notcurses-2.3.15/build/include -DNDEBUG -fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -march=armv6 -mfpu=vfp -mfloat-abi=hard   -I/usr/arm-linux-musleabihf/usr/include -fvisibility=hidden -Wall -Wextra -W -Wshadow -Wformat -Wformat-security -fexceptions -fstrict-aliasing -std=c++17 -MD -MT CMakeFiles/ncls.dir/src/ls/main.cpp.o -MF CMakeFiles/ncls.dir/src/ls/main.cpp.o.d -o CMakeFiles/ncls.dir/src/ls/main.cpp.o -c /builddir/notcurses-2.3.15/src/ls/main.cpp
In file included from /builddir/notcurses-2.3.15/include/notcurses/notcurses.h:11,
                 from /builddir/notcurses-2.3.15/include/notcurses/direct.h:4,
                 from /builddir/notcurses-2.3.15/include/ncpp/Direct.hh:5,
                 from /builddir/notcurses-2.3.15/src/ls/main.cpp:16:
/usr/arm-linux-musleabihf/usr/include/string.h:69:7: error: declaration of 'char* strndup(const char*, size_t)' has a different exception specifier
   69 | char *strndup (const char *, size_t);
      |       ^~~~~~~
In file included from /builddir/notcurses-2.3.15/src/ls/main.cpp:15:
/builddir/notcurses-2.3.15/src/compat/compat.h:82:7: note: from previous declaration 'char* strndup(const char*, size_t) noexcept'
   82 | char* strndup(const char* str, size_t size) NOEXCEPT;
      |       ^~~~~~~
[264/392] Building CXX object CMakeFiles/ncplayer.dir/src/player/play.cpp.o
ninja: build stopped: subcommand failed.
=> ERROR: notcurses-2.3.15_1: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 1
```

it's triggering compatibility function for `strndup` on musl, which then conflicts with the libc declaration. This is probably happening because it tests for `strndup` without defining `_GNU_SOURCE` or `_POSIX_C_SOURCE=200809L`. Should be simple to fix in the build system

  reply	other threads:[~2021-08-18 18:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 16:47 [PR PATCH] " mobinmob
2021-08-18 18:46 ` ericonr [this message]
2021-08-18 18:58 ` mobinmob
2021-08-18 19:10 ` [PR PATCH] [Updated] " mobinmob
2021-08-18 19:12 ` mobinmob
2021-08-18 22:21 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818184628.h_--n-4mS1UJjK7NEIyxxfXvBB2TgsLFhr1jucij7oU@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).