From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: rundird-0.2.0, Add zig-build build style
Date: Thu, 19 Aug 2021 00:18:27 +0200 [thread overview]
Message-ID: <20210818221827.PfN5X6pHUXx5n96Ko-oEf-LmAiH9HuW7P6rZ1oumeuU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-29288@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29288#discussion_r691642455
Comment:
What do you think about an `environment/build-style/` file that sets `archs` for the supported archs? This way you don't have to detect if these are set before `do_build` in order to trigger `broken` (or maybe it's the best way, since it avoids duplicating the information?).
Overall looks really good, just want to be sure of the best way of signaling when zig is unsupported.
next prev parent reply other threads:[~2021-08-18 22:18 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 10:59 [PR PATCH] New package: rundird-0.1.0 ifreund
2021-03-07 11:01 ` [PR PATCH] [Updated] " ifreund
2021-03-08 6:34 ` ericonr
2021-03-11 9:15 ` travankor
2021-03-11 9:16 ` travankor
2021-03-11 13:10 ` ericonr
2021-03-11 13:39 ` travankor
2021-03-11 13:45 ` travankor
2021-03-11 13:45 ` travankor
2021-05-24 19:07 ` [PR PATCH] [Updated] " ifreund
2021-06-07 20:39 ` ifreund
2021-06-10 2:19 ` ifreund
2021-06-10 3:10 ` ifreund
2021-06-10 4:26 ` ifreund
2021-06-10 4:31 ` ifreund
2021-06-17 1:40 ` ifreund
2021-06-17 1:49 ` ifreund
2021-06-17 3:07 ` [PR REVIEW] " ericonr
2021-06-17 3:07 ` ericonr
2021-06-17 3:07 ` ericonr
2021-06-17 3:07 ` ericonr
2021-06-17 3:07 ` ericonr
2021-06-17 3:07 ` ericonr
2021-06-17 17:41 ` [PR PATCH] [Updated] " ifreund
2021-06-17 17:43 ` [PR REVIEW] " ifreund
2021-06-17 17:43 ` ifreund
2021-06-17 19:23 ` ericonr
2021-06-17 20:16 ` [PR PATCH] [Updated] " ifreund
2021-06-17 20:22 ` ifreund
2021-06-18 0:21 ` ifreund
2021-06-21 21:08 ` ifreund
2021-06-21 21:09 ` ifreund
2021-06-21 21:10 ` [PR PATCH] [Updated] " ifreund
2021-06-21 21:12 ` ifreund
2021-06-26 11:06 ` ifreund
2021-07-25 20:55 ` [PR REVIEW] New package: rundird-0.1.1, Add zig-build build style ericonr
2021-07-25 20:55 ` ericonr
2021-07-25 20:59 ` ericonr
2021-07-25 22:30 ` [PR REVIEW] " ifreund
2021-07-27 1:02 ` [PR PATCH] [Updated] " ifreund
2021-07-27 1:07 ` ifreund
2021-07-27 1:11 ` ifreund
2021-08-18 22:18 ` ericonr [this message]
2021-08-18 22:38 ` [PR REVIEW] New package: rundird-0.2.0, " ifreund
2021-08-18 22:41 ` [PR PATCH] [Updated] " ifreund
2021-08-18 22:41 ` ifreund
2021-09-07 17:23 ` [PR PATCH] [Updated] " ifreund
2021-09-07 17:25 ` ifreund
2021-09-15 14:50 ` [PR PATCH] [Updated] " ifreund
2021-11-03 13:49 ` ifreund
2021-11-03 16:46 ` [PR PATCH] [Updated] Add zig-build build style, river 0.1.0, rundird 0.2.0 ifreund
2021-11-08 15:56 ` ifreund
2021-11-08 15:58 ` ifreund
2021-11-10 23:48 ` subsetpark
2021-11-11 0:31 ` [PR REVIEW] " ericonr
2021-11-11 0:31 ` ericonr
2021-11-11 0:31 ` ericonr
2021-11-11 0:31 ` ericonr
2021-11-11 10:19 ` ifreund
2021-11-11 10:22 ` ifreund
2021-11-11 10:24 ` [PR PATCH] [Updated] " ifreund
2021-11-11 11:25 ` ifreund
2021-11-11 11:25 ` [PR REVIEW] " ifreund
2021-11-11 11:26 ` ifreund
2021-11-13 3:15 ` [PR REVIEW] " ericonr
2021-11-13 3:15 ` ericonr
2021-11-13 3:49 ` ericonr
2021-11-13 11:43 ` [PR PATCH] [Updated] " ifreund
2021-11-13 11:44 ` [PR REVIEW] " ifreund
2021-11-13 11:47 ` ifreund
2021-11-13 14:46 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818221827.PfN5X6pHUXx5n96Ko-oEf-LmAiH9HuW7P6rZ1oumeuU@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).