[PR PATCH] rust: Enable Rust builtin_profiler, some cargo crates fail to build w…

[PR PATCH] rust: Enable Rust builtin_profiler, some cargo crates fail to build w…

[DottoDev]

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

There is a new pull request by DottoDev against master on the void-packages repository

https://github.com/DottoDev/void-packages master
https://github.com/void-linux/void-packages/pull/32362

rust: Enable Rust builtin_profiler, some cargo crates fail to build w…
…ithout it

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (x86_64-GLIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/32362.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32362.patch --]
[-- Type: text/x-diff, Size: 624 bytes --]

From 501276d2300e06c756b2503a5996878eda4a7f6a Mon Sep 17 00:00:00 2001
From: DottoDev <t.schoenauer@hgs-wt.at>
Date: Fri, 6 Aug 2021 15:29:33 +0200
Subject: [PATCH] rust: Enable Rust builtin_profiler, some cargo crates fail to
 build without it

---
 srcpkgs/rust/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/rust/template b/srcpkgs/rust/template
index f31ea7b87b81..1488791ef33b 100644
--- a/srcpkgs/rust/template
+++ b/srcpkgs/rust/template
@@ -250,6 +250,7 @@ do_configure() {
 		extended = false
 		docs = ${_use_docs}
 		tools = []
+    profiler = true
 		[install]
 		prefix = "/usr"
 		[rust]

Re: [PR REVIEW] rust: Enable Rust builtin_profiler, some cargo crates fail to build w…

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32362#discussion_r684277541

Comment:
Please indent properly.

Re: [PR PATCH] [Updated] rust: Enable Rust builtin_profiler

[DottoDev]

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

There is an updated pull request by DottoDev against master on the void-packages repository

https://github.com/DottoDev/void-packages master
https://github.com/void-linux/void-packages/pull/32362

rust: Enable Rust builtin_profiler
…ithout it

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (x86_64-GLIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

[ci skip]


A patch file from https://github.com/void-linux/void-packages/pull/32362.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32362.patch --]
[-- Type: text/x-diff, Size: 1253 bytes --]

From 501276d2300e06c756b2503a5996878eda4a7f6a Mon Sep 17 00:00:00 2001
From: DottoDev <t.schoenauer@hgs-wt.at>
Date: Fri, 6 Aug 2021 15:29:33 +0200
Subject: [PATCH 1/2] rust: Enable Rust builtin_profiler, some cargo crates
 fail to build without it

---
 srcpkgs/rust/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/rust/template b/srcpkgs/rust/template
index f31ea7b87b81..1488791ef33b 100644
--- a/srcpkgs/rust/template
+++ b/srcpkgs/rust/template
@@ -250,6 +250,7 @@ do_configure() {
 		extended = false
 		docs = ${_use_docs}
 		tools = []
+    profiler = true
 		[install]
 		prefix = "/usr"
 		[rust]

From 9794cb68fe8546b7974ace21d75ec53111c549f4 Mon Sep 17 00:00:00 2001
From: DottoDev <37108907+DottoDev@users.noreply.github.com>
Date: Fri, 6 Aug 2021 16:58:37 +0200
Subject: [PATCH 2/2] Corrected Indent

---
 srcpkgs/rust/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/rust/template b/srcpkgs/rust/template
index 1488791ef33b..6481a1d0fac4 100644
--- a/srcpkgs/rust/template
+++ b/srcpkgs/rust/template
@@ -250,7 +250,7 @@ do_configure() {
 		extended = false
 		docs = ${_use_docs}
 		tools = []
-    profiler = true
+    		profiler = true
 		[install]
 		prefix = "/usr"
 		[rust]

Re: rust: Enable Rust builtin_profiler

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32362#issuecomment-894473019

Comment:
You only fixed the PR title, not the commit itself.

Re: rust: Enable Rust builtin_profiler

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32362#issuecomment-901569133

Comment:
Per https://github.com/rust-lang/rust/issues/79121, this is still an unstable feature, and I don't think we should enable it in our distro toolchain. You probably want to use the `rustup` package and download nightly toolchains instead.

Re: [PR PATCH] [Closed]: rust: Enable Rust builtin_profiler

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]

There's a closed pull request on the void-packages repository

rust: Enable Rust builtin_profiler
https://github.com/void-linux/void-packages/pull/32362

Description:
…ithout it

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x ] I built this PR locally for my native architecture, (x86_64-GLIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

[ci skip]