From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] common/environment/setup/install.sh: add vdesktop
Date: Thu, 19 Aug 2021 22:01:12 +0200 [thread overview]
Message-ID: <20210819200112.rOQfW9PCGb17R0mrrK-Ixzj_ZpHTTCtP_y159le3A4g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32575@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32575#discussion_r692444254
Comment:
.desktop files go directly into `usr/share/applications`, not per package subdirs...
If `$pkgname` fits here, it's for the target file, but I don't think it's a good default either.
Also you'd want to use unquoted `$targetfile`, otherwise it will be passing an empty string as last arg and that's entirely wrong.
next prev parent reply other threads:[~2021-08-19 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 6:18 [PR PATCH] " maybe-one-day-ubermensch
2021-08-19 20:01 ` ericonr [this message]
2021-08-19 20:34 ` [PR REVIEW] " maybe-one-day-ubermensch
2021-08-19 20:34 ` maybe-one-day-ubermensch
2021-08-19 20:35 ` maybe-one-day-ubermensch
2021-08-19 20:35 ` maybe-one-day-ubermensch
2021-08-19 21:30 ` [PR PATCH] [Updated] " maybe-one-day-ubermensch
2021-08-19 21:33 ` maybe-one-day-ubermensch
2021-08-19 23:26 ` ericonr
2021-08-20 0:19 ` [PR PATCH] [Updated] " maybe-one-day-ubermensch
2021-08-20 0:19 ` maybe-one-day-ubermensch
2022-06-02 2:14 ` github-actions
2022-06-17 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819200112.rOQfW9PCGb17R0mrrK-Ixzj_ZpHTTCtP_y159le3A4g@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).