From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-txtorcon: update to 21.1.0.
Date: Sun, 22 Aug 2021 20:08:48 +0200 [thread overview]
Message-ID: <20210822180848.C49LR6rYK7B-_5c-VmHb3DVsEdBZZTqHld09E9nV0pk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32624@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32624#discussion_r693536930
Comment:
* lsof is a runtime dependency: https://github.com/meejah/txtorcon/search?q=lsof
* then `checkdepends="$depends python3-mox tox"` will be more readable
* you can replace tox with python3-pytest
next prev parent reply other threads:[~2021-08-22 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 5:00 [PR PATCH] " travankor
2021-08-22 5:11 ` [PR PATCH] [Updated] " travankor
2021-08-22 7:28 ` [PR REVIEW] " paper42
2021-08-22 10:34 ` travankor
2021-08-22 18:08 ` paper42 [this message]
2021-08-22 18:08 ` paper42
2021-08-22 18:09 ` paper42
2021-08-22 18:25 ` paper42
2021-08-22 20:34 ` travankor
2021-08-22 20:35 ` [PR PATCH] [Updated] " travankor
2021-08-22 20:38 ` travankor
2021-08-22 21:15 ` [PR REVIEW] " paper42
2021-08-24 23:09 ` travankor
2021-08-24 23:17 ` travankor
2021-08-24 23:21 ` [PR PATCH] [Updated] " travankor
2021-08-25 21:12 ` [PR REVIEW] " paper42
2021-08-25 21:14 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210822180848.C49LR6rYK7B-_5c-VmHb3DVsEdBZZTqHld09E9nV0pk@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).