From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: libcgroup: update to 2.0
Date: Sun, 22 Aug 2021 20:17:17 +0200 [thread overview]
Message-ID: <20210822181717.enU8G5pUkOWkDA-JkE6TMz_JQWfgYcPA_aRe1iBBipQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32623@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32623#issuecomment-903309272
Comment:
> > No, run git commit --amend and fix the commit message there.
>
> git commit --amend is what i run
but for some reason you are not editing the commit message
* did an editor open for you?
* did you edit the message in it?
* did you save the file in the editor?
`git show` will tell you the commit message.
If you are not able to edit the commit message interactively, this command should work:
```
git commit --amend --no-edit -m "message"
```
> i have adjusted the patches to be compatible with git patches
:+1:
> The build is failing now, did you test it on your machine? I think we removed the failing patch in the previous PR, didn't we?
CVE-2018-14348 affects only versions up to (and including) 0.41, so we don't need the patch for 2.0. Didn't we already discuss this? Could you build it on your machine before pushing here to make sure simple mistakes like this don't happen?
next prev parent reply other threads:[~2021-08-22 18:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 4:29 [PR PATCH] libcgroup upgrade " wibed
2021-08-22 7:38 ` paper42
2021-08-22 9:09 ` [PR PATCH] [Updated] libcgroup: update " wibed
2021-08-22 9:11 ` wibed
2021-08-22 9:20 ` paper42
2021-08-22 9:23 ` [PR PATCH] [Updated] " wibed
2021-08-22 9:26 ` wibed
2021-08-22 18:17 ` paper42 [this message]
2021-08-23 9:01 ` [PR PATCH] [Updated] " wibed
2021-08-23 16:20 ` paper42
2021-08-23 18:26 ` [PR PATCH] [Updated] " wibed
2021-08-24 7:02 ` wibed
2021-08-24 19:25 ` paper42
2021-08-24 19:38 ` paper42
2021-08-28 10:59 ` wibed
2022-06-02 2:15 ` github-actions
2022-06-17 2:13 ` [PR PATCH] [Closed]: " github-actions
-- strict thread matches above, loose matches on Subject: below --
2021-07-28 15:54 [PR PATCH] " wibed
2021-07-28 16:01 ` paper42
2021-07-28 16:49 ` wibed
2021-07-28 16:59 ` paper42
2021-07-28 17:03 ` wibed
2021-07-28 20:29 ` paper42
2021-08-12 17:11 ` paper42
2021-08-13 7:36 ` wibed
2021-08-18 3:40 ` wibed
2021-08-18 8:45 ` wibed
2021-08-18 16:13 ` paper42
2021-08-20 1:07 ` wibed
2021-08-20 1:09 ` wibed
2021-08-20 1:09 ` wibed
2021-08-20 1:57 ` wibed
2021-08-20 15:56 ` ericonr
2021-08-21 1:33 ` wibed
2021-08-21 3:07 ` wibed
2021-08-22 4:07 ` wibed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210822181717.enU8G5pUkOWkDA-JkE6TMz_JQWfgYcPA_aRe1iBBipQ@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).