* [PR PATCH] Update template
@ 2021-08-20 7:16 d33vliter
2021-08-20 15:54 ` Discord: update dependencies ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: d33vliter @ 2021-08-20 7:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]
There is a new pull request by d33vliter against master on the void-packages repository
https://github.com/d33vliter/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32596
Update template
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32596.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32596.patch --]
[-- Type: text/x-diff, Size: 823 bytes --]
From d18858229e0284143501c62d2473e1b6ebb32ee4 Mon Sep 17 00:00:00 2001
From: d33vliter <iandupuy1998@gmail.com>
Date: Fri, 20 Aug 2021 02:15:52 -0500
Subject: [PATCH] Update template
---
srcpkgs/discord/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/discord/template b/srcpkgs/discord/template
index fc6a70079d8b..247b8b7fa8b6 100644
--- a/srcpkgs/discord/template
+++ b/srcpkgs/discord/template
@@ -4,7 +4,7 @@ version=0.0.15
revision=1
archs="x86_64"
wrksrc="Discord"
-depends="alsa-lib dbus-glib gtk+3 libnotify nss libXtst libcxx libatomic"
+depends="alsa-lib dbus-glib gtk+3 libnotify nss libXtst libcxx libatomic xdg-utils webrtc-audio-processing"
short_desc="Chat and VOIP application"
maintainer="Ryan Conwell <ryanconwell@protonmail.com>"
license="custom:Proprietary"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Discord: update dependencies
2021-08-20 7:16 [PR PATCH] Update template d33vliter
@ 2021-08-20 15:54 ` ericonr
2021-08-20 16:08 ` d33vliter
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-08-20 15:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32596#issuecomment-902791114
Comment:
Commit message is wrong, package revision should be increased, the depends list should be broken into another line, at around 80 columns.
Commit should be `discord: update dependencies" and you could include what each one does in the commit body, like you did in the PR description.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Discord: update dependencies
2021-08-20 7:16 [PR PATCH] Update template d33vliter
2021-08-20 15:54 ` Discord: update dependencies ericonr
@ 2021-08-20 16:08 ` d33vliter
2021-08-20 17:46 ` ericonr
2021-08-25 17:12 ` [PR PATCH] [Closed]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: d33vliter @ 2021-08-20 16:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
New comment by d33vliter on void-packages repository
https://github.com/void-linux/void-packages/pull/32596#issuecomment-902800058
Comment:
> Commit message is wrong, package revision should be increased, the depends list should be broken into another line, at around 80 columns.
>
> Commit should be `discord: update dependencies" and you could include what each one does in the commit body, like you did in the PR description.
this? 🤔
General
This is a new package and it conforms to the quality requirements
Have the results of the proposed changes been tested?
I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
I generally don't use the affected packages but briefly tested this PR
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Discord: update dependencies
2021-08-20 7:16 [PR PATCH] Update template d33vliter
2021-08-20 15:54 ` Discord: update dependencies ericonr
2021-08-20 16:08 ` d33vliter
@ 2021-08-20 17:46 ` ericonr
2021-08-25 17:12 ` [PR PATCH] [Closed]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-08-20 17:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32596#issuecomment-902855360
Comment:
No, your own PR description:
```
xdg-utils to open links in discord
webrtc-audio-processing to avoid discord error that closes after 1 hour or less into a call
```
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: Discord: update dependencies
2021-08-20 7:16 [PR PATCH] Update template d33vliter
` (2 preceding siblings ...)
2021-08-20 17:46 ` ericonr
@ 2021-08-25 17:12 ` ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-08-25 17:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
There's a closed pull request on the void-packages repository
Discord: update dependencies
https://github.com/void-linux/void-packages/pull/32596
Description:
**xdg-utils** to open links in discord
**webrtc-audio-processing** to avoid discord error that closes after 1 hour or less into a call
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-25 17:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 7:16 [PR PATCH] Update template d33vliter
2021-08-20 15:54 ` Discord: update dependencies ericonr
2021-08-20 16:08 ` d33vliter
2021-08-20 17:46 ` ericonr
2021-08-25 17:12 ` [PR PATCH] [Closed]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).