Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: gtk-chtheme-0.3.1
@ 2021-08-26 10:11 meator
  2021-08-26 17:23 ` paper42
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: meator @ 2021-08-26 10:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages gtk-chtheme
https://github.com/void-linux/void-packages/pull/32682

New package: gtk-chtheme-0.3.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures:
  - [x] x86_64-musl
  - [x] aarch64-musl (cross)
  - [x] armv7l (cross)
  - [x] armv6l-musl (cross)

A patch file from https://github.com/void-linux/void-packages/pull/32682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk-chtheme-32682.patch --]
[-- Type: text/x-diff, Size: 3289 bytes --]

From 065f2b7a54c102a17dcaa406865cfa68d67fea5c Mon Sep 17 00:00:00 2001
From: meator <coder64@protonmail.com>
Date: Thu, 26 Aug 2021 10:10:17 +0200
Subject: [PATCH] New package: gtk-chtheme-0.3.1

---
 srcpkgs/gtk-chtheme/patches/Makeflie.patch    | 22 +++++++++++++++++++
 .../gtk-chtheme/patches/fixthemepath.patch    | 12 ++++++++++
 srcpkgs/gtk-chtheme/template                  | 14 ++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 srcpkgs/gtk-chtheme/patches/Makeflie.patch
 create mode 100644 srcpkgs/gtk-chtheme/patches/fixthemepath.patch
 create mode 100644 srcpkgs/gtk-chtheme/template

diff --git a/srcpkgs/gtk-chtheme/patches/Makeflie.patch b/srcpkgs/gtk-chtheme/patches/Makeflie.patch
new file mode 100644
index 000000000000..b10f68111a96
--- /dev/null
+++ b/srcpkgs/gtk-chtheme/patches/Makeflie.patch
@@ -0,0 +1,22 @@
+Fix build. Some parts of this patch are borrowed from ArchLinux gtk-chtheme
+package:
+https://github.com/archlinux/svntogit-community/blob/packages/gtk-chtheme/trunk/PKGBUILD#L20
+--- gtk-chtheme-0.3.1/Makefile  2004-02-09 18:08:41.000000000 +0100
++++ gtk-chtheme-0.3.1-patch/Makefile    2021-08-26 09:24:10.832781503 +0200
+@@ -4,7 +4,7 @@
+
+ LDFLAGS = $(shell pkg-config --libs gtk+-2.0)
+ CFLAGS += -Wall
+-CFLAGS += $(shell pkg-config --cflags gtk+-2.0) -DGTK_DISABLE_BROKEN -DGTK_DISABLE_DEPRECATED
++CFLAGS += $(shell pkg-config --cflags gtk+-2.0)
+ CFLAGS += -DPROJNAME='"$(PROJNAME)"' -DVERSION='"$(VERSION)"'
+ CPPFLAGS =
+ CXXFLAGS =
+@@ -38,7 +38,6 @@
+    -rm -f $(EXENAME).spec $(EXENAME).1 Makefile.bak
+
+ install: all
+-   strip      $(EXENAME)
+    install -d              $(DESTDIR)/$(BINDIR)
+    install -c $(EXENAME)   $(DESTDIR)/$(BINDIR)
+    install -d              $(DESTDIR)/$(MANDIR)/man1
diff --git a/srcpkgs/gtk-chtheme/patches/fixthemepath.patch b/srcpkgs/gtk-chtheme/patches/fixthemepath.patch
new file mode 100644
index 000000000000..3e934a4b78a4
--- /dev/null
+++ b/srcpkgs/gtk-chtheme/patches/fixthemepath.patch
@@ -0,0 +1,12 @@
+This patch is borrowed from ArchLinux gtk-chtheme package:
+https://github.com/archlinux/svntogit-community/blob/packages/gtk-chtheme/trunk/PKGBUILD#L20
+--- gtk-chtheme-0.3.1/main.c	2004-02-09 05:33:28.000000000 +0100
++++ gtk-chtheme-0.3.1-patch/main.c	2021-08-26 09:42:56.387416081 +0200
+@@ -222,6 +222,7 @@
+ 	init_new_stock_items();
+ 
+ 	read_theme_list(g_strconcat(getenv("HOME"), "/.themes", NULL));
++	read_theme_list(g_strconcat(g_get_user_data_dir(), "/themes", NULL));
+ 	read_theme_list(gtk_rc_get_theme_dir());
+ 
+ 	parse_gtkrc();
diff --git a/srcpkgs/gtk-chtheme/template b/srcpkgs/gtk-chtheme/template
new file mode 100644
index 000000000000..b2b72e2b02a8
--- /dev/null
+++ b/srcpkgs/gtk-chtheme/template
@@ -0,0 +1,14 @@
+# Template file for 'gtk-chtheme'
+pkgname=gtk-chtheme
+version=0.3.1
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+hostmakedepends="pkg-config"
+makedepends="gtk+-devel"
+short_desc="Gtk+ 2.0 theme preview and selection made slick"
+maintainer="meator <coder64@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="http://plasmasturm.org/code/gtk-chtheme/"
+distfiles="http://plasmasturm.org/code/gtk-chtheme/gtk-chtheme-${version}.tar.bz2"
+checksum=26f4b6dd60c220d20d612ca840b6beb18b59d139078be72c7b1efefc447df844

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: gtk-chtheme-0.3.1
  2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
@ 2021-08-26 17:23 ` paper42
  2021-08-26 17:30 ` paper42
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2021-08-26 17:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32682#issuecomment-906599325

Comment:
GTK2 is unmaintained and we should be slowly removing packages which still need it, not adding new ones. So unless you have a very good reason why this package should be included in the repositories, it will be NACK from me.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: gtk-chtheme-0.3.1
  2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
  2021-08-26 17:23 ` paper42
@ 2021-08-26 17:30 ` paper42
  2021-08-26 17:31 ` paper42
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2021-08-26 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32682#issuecomment-906599325

Comment:
GTK2 is unmaintained and we should be slowly removing packages which still need it, not adding new ones. So unless you have a very good reason why this package should be included in the repositories, it will be NAK from me.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: gtk-chtheme-0.3.1
  2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
  2021-08-26 17:23 ` paper42
  2021-08-26 17:30 ` paper42
@ 2021-08-26 17:31 ` paper42
  2021-08-26 18:41 ` ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2021-08-26 17:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32682#issuecomment-906599325

Comment:
GTK2 is unmaintained and we should be slowly removing packages which still need it, not adding new ones. So unless you have a very good reason why this package should be included in the repositories, it will be NACK from me.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: gtk-chtheme-0.3.1
  2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
                   ` (2 preceding siblings ...)
  2021-08-26 17:31 ` paper42
@ 2021-08-26 18:41 ` ericonr
  2021-08-26 18:41 ` [PR PATCH] [Closed]: " ericonr
  2021-08-26 18:41 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-08-26 18:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32682#issuecomment-906651160

Comment:
Upstream has been mostly dead since the 2009 release and we don't want new gtk2 dependencies (since they will only crease repository maintenance costs with time). Sorry, but closing this.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: New package: gtk-chtheme-0.3.1
  2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
                   ` (3 preceding siblings ...)
  2021-08-26 18:41 ` ericonr
@ 2021-08-26 18:41 ` ericonr
  2021-08-26 18:41 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-08-26 18:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

There's a closed pull request on the void-packages repository

New package: gtk-chtheme-0.3.1
https://github.com/void-linux/void-packages/pull/32682

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures:
  - [x] x86_64-musl
  - [x] aarch64-musl (cross)
  - [x] armv7l (cross)
  - [x] armv6l-musl (cross)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: gtk-chtheme-0.3.1
  2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
                   ` (4 preceding siblings ...)
  2021-08-26 18:41 ` [PR PATCH] [Closed]: " ericonr
@ 2021-08-26 18:41 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-08-26 18:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32682#issuecomment-906651160

Comment:
Upstream has been mostly dead since the 2009 release and we don't want new gtk2 dependencies (since they will only increase repository maintenance costs with time). Sorry, but closing this.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-08-26 18:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 10:11 [PR PATCH] New package: gtk-chtheme-0.3.1 meator
2021-08-26 17:23 ` paper42
2021-08-26 17:30 ` paper42
2021-08-26 17:31 ` paper42
2021-08-26 18:41 ` ericonr
2021-08-26 18:41 ` [PR PATCH] [Closed]: " ericonr
2021-08-26 18:41 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).