* [PR PATCH] intellij-idea-ultimate-edition: fix missing fsnotifier binary
@ 2021-08-27 6:32 mithodin
2021-08-27 17:23 ` ericonr
2021-08-27 17:23 ` [PR PATCH] [Merged]: " ericonr
0 siblings, 2 replies; 3+ messages in thread
From: mithodin @ 2021-08-27 6:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
There is a new pull request by mithodin against master on the void-packages repository
https://github.com/mithodin/void-packages intelli-ultimate-2021-2-revision-2
https://github.com/void-linux/void-packages/pull/32698
intellij-idea-ultimate-edition: fix missing fsnotifier binary
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Quite a few of the removed files were no longer actually present, and a few new ones have been added which are useless on linux and/or the target architecture. I would love some feedback from someone using i686 whether the fsnotifier binary (which to me looks like an x86_64 binary and works on x86_64) works on that architecture or could be removed.
A patch file from https://github.com/void-linux/void-packages/pull/32698.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-intelli-ultimate-2021-2-revision-2-32698.patch --]
[-- Type: text/x-diff, Size: 2750 bytes --]
From 62471fe828c8732311b1dd831bce89318ae2a90d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Treffenst=C3=A4dt?=
<lucas.treffenstaedt@tngtech.com>
Date: Fri, 27 Aug 2021 08:28:46 +0200
Subject: [PATCH] intellij-idea-ultimate-edition: fix missing fsnotifier binary
---
.../intellij-idea-ultimate-edition/template | 31 +++++++++++--------
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/srcpkgs/intellij-idea-ultimate-edition/template b/srcpkgs/intellij-idea-ultimate-edition/template
index 4332867a7afc..a2775d899e25 100644
--- a/srcpkgs/intellij-idea-ultimate-edition/template
+++ b/srcpkgs/intellij-idea-ultimate-edition/template
@@ -1,7 +1,7 @@
# Template file for 'intellij-idea-ultimate-edition'
pkgname=intellij-idea-ultimate-edition
version=2021.2
-revision=1
+revision=2
archs="i686 x86_64"
wrksrc="idea-IU-212.4746.92"
depends="giflib libXtst jetbrains-jdk-bin"
@@ -20,13 +20,20 @@ python_version=3
post_extract() {
# Remove files for other OSes
- rm -rf plugins/android/lib/libwebp/win
- rm -rf plugins/android/lib/libwebp/mac
+ rm -rf plugins/webp/lib/libwebp/win
+ rm -rf plugins/webp/lib/libwebp/mac
rm -rf plugins/maven/lib/maven3/lib/jansi-native/freebsd64
rm -rf plugins/maven/lib/maven3/lib/jansi-native/freebsd32
+ rm -rf plugins/maven/lib/maven3/lib/jansi-native/osx
+ rm -rf plugins/maven/lib/maven3/lib/jansi-native/windows32
+ rm -rf plugins/maven/lib/maven3/lib/jansi-native/windows64
+ rm -rf plugins/cwm-plugin/quiche-native/win32-x86-64
+ rm -rf plugins/cwm-plugin/quiche-native/darwin-aarch64
+ rm -rf plugins/cwm-plugin/quiche-native/darwin-x86-64
+ rm -rf **/*.dll
+ rm -rf **/*.dylib
# Remove files for other CPU architectures
- rm -rf bin/fsnotifier-arm
rm -rf lib/pty4j-native/linux/ppc64le
rm -rf lib/pty4j-native/linux/aarch64
rm -rf lib/pty4j-native/linux/mips64el
@@ -34,18 +41,16 @@ post_extract() {
case "$XBPS_TARGET_MACHINE" in
x86_64)
- rm -rf bin/fsnotifier
- rm -rf bin/idea.vmoptions
- rm -rf bin/libyjpagent-linux.so
- rm -rf plugins/android/lib/libwebp/linux/libwebp_jni.so
+ rm -rf plugins/webp/lib/libwebp/linux/libwebp_jni.so
rm -rf lib/pty4j-native/linux/x86
+ rm -rf plugins/maven/lib/maven3/lib/jansi-native/linux32
+ rm -rf plugins/performanceTesting/bin/libyjpagent.so
;;
i686)
- rm -rf bin/fsnotifier64
- rm -rf bin/idea64.vmoptions
- rm -rf bin/libyjpagent-linux64.so
- rm -rf plugins/android/lib/libwebp/linux/libwebp_jni64.so
- rm -rf lib/pty4j-native/linux/x86_64
+ rm -rf plugins/webp/lib/libwebp/linux/libwebp_jni64.so
+ rm -rf lib/pty4j-native/linux/x86-64
+ rm -rf plugins/maven/lib/maven3/lib/jansi-native/linux64
+ rm -rf plugins/performanceTesting/bin/libyjpagent64.so
;;
esac
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: intellij-idea-ultimate-edition: fix missing fsnotifier binary
2021-08-27 6:32 [PR PATCH] intellij-idea-ultimate-edition: fix missing fsnotifier binary mithodin
@ 2021-08-27 17:23 ` ericonr
2021-08-27 17:23 ` [PR PATCH] [Merged]: " ericonr
1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-08-27 17:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32698#issuecomment-907356831
Comment:
I will leave it to them to complain if it's broken. I find it unlikely people can develop java stuff on any i686 machines.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Merged]: intellij-idea-ultimate-edition: fix missing fsnotifier binary
2021-08-27 6:32 [PR PATCH] intellij-idea-ultimate-edition: fix missing fsnotifier binary mithodin
2021-08-27 17:23 ` ericonr
@ 2021-08-27 17:23 ` ericonr
1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-08-27 17:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
There's a merged pull request on the void-packages repository
intellij-idea-ultimate-edition: fix missing fsnotifier binary
https://github.com/void-linux/void-packages/pull/32698
Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Quite a few of the removed files were no longer actually present, and a few new ones have been added which are useless on linux and/or the target architecture. I would love some feedback from someone using i686 whether the fsnotifier binary (which to me looks like an x86_64 binary and works on x86_64) works on that architecture or could be removed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-27 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 6:32 [PR PATCH] intellij-idea-ultimate-edition: fix missing fsnotifier binary mithodin
2021-08-27 17:23 ` ericonr
2021-08-27 17:23 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).