Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] j: add devel package
@ 2021-08-23 10:32 subsetpark
  2021-08-23 11:50 ` [PR REVIEW] " Duncaen
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: subsetpark @ 2021-08-23 10:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

There is a new pull request by subsetpark against master on the void-packages repository

https://github.com/subsetpark/void-packages master
https://github.com/void-linux/void-packages/pull/32644

j: add devel package
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

A patch file from https://github.com/void-linux/void-packages/pull/32644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32644.patch --]
[-- Type: text/x-diff, Size: 1236 bytes --]

From ff01a35fb4d4b847a7f1375fcde18d5dfe9c66f4 Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 06:24:43 -0400
Subject: [PATCH] j: add devel package

---
 srcpkgs/j-devel/template |  1 +
 srcpkgs/j/template       | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
new file mode 120000
index 000000000000..13dc84296084
--- /dev/null
+++ b/srcpkgs/j-devel/template
@@ -0,0 +1 @@
+../j/template
\ No newline at end of file
diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index b6ce41a36077..cc8ac07710b0 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -1,7 +1,7 @@
 # Template file for 'j'
 pkgname=j
 version=901.f
-revision=1
+revision=2
 _vmaj="${version%.*}"
 _vmin="${version#${_vmaj}}"
 _vrel=${_vmaj}-release${_vmin:+-}${_vmin#.}
@@ -139,3 +139,14 @@ do_install() {
 	_jconsole_wrapper_script >bin/jc.sh
 	vbin "bin/jc.sh" jc
 }
+
+j-devel_package() {
+	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/*.a
+		vmove usr/lib/*.so
+		vmove usr/lib/pkgconfig
+	}
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
@ 2021-08-23 11:50 ` Duncaen
  2021-08-23 13:34 ` [PR PATCH] [Updated] " subsetpark
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Duncaen @ 2021-08-23 11:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r693901665

Comment:
This should just link to the main packages directory, `ln -s j srcpkgs/j-devel`

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
  2021-08-23 11:50 ` [PR REVIEW] " Duncaen
@ 2021-08-23 13:34 ` subsetpark
  2021-08-23 13:35 ` [PR REVIEW] " subsetpark
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-08-23 13:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is an updated pull request by subsetpark against master on the void-packages repository

https://github.com/subsetpark/void-packages master
https://github.com/void-linux/void-packages/pull/32644

j: add devel package
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

A patch file from https://github.com/void-linux/void-packages/pull/32644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32644.patch --]
[-- Type: text/x-diff, Size: 2043 bytes --]

From ff01a35fb4d4b847a7f1375fcde18d5dfe9c66f4 Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 06:24:43 -0400
Subject: [PATCH 1/2] j: add devel package

---
 srcpkgs/j-devel/template |  1 +
 srcpkgs/j/template       | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
new file mode 120000
index 000000000000..13dc84296084
--- /dev/null
+++ b/srcpkgs/j-devel/template
@@ -0,0 +1 @@
+../j/template
\ No newline at end of file
diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index b6ce41a36077..cc8ac07710b0 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -1,7 +1,7 @@
 # Template file for 'j'
 pkgname=j
 version=901.f
-revision=1
+revision=2
 _vmaj="${version%.*}"
 _vmin="${version#${_vmaj}}"
 _vrel=${_vmaj}-release${_vmin:+-}${_vmin#.}
@@ -139,3 +139,14 @@ do_install() {
 	_jconsole_wrapper_script >bin/jc.sh
 	vbin "bin/jc.sh" jc
 }
+
+j-devel_package() {
+	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/*.a
+		vmove usr/lib/*.so
+		vmove usr/lib/pkgconfig
+	}
+}

From 5a2179b7efa57048a22f34134817a367676ebcfe Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 09:34:21 -0400
Subject: [PATCH 2/2] CR: @Duncaen - change symlink

---
 srcpkgs/j-devel          | 1 +
 srcpkgs/j-devel/template | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel
 delete mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
new file mode 120000
index 000000000000..568066327219
--- /dev/null
+++ b/srcpkgs/j-devel
@@ -0,0 +1 @@
+./j
\ No newline at end of file
diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
deleted file mode 120000
index 13dc84296084..000000000000
--- a/srcpkgs/j-devel/template
+++ /dev/null
@@ -1 +0,0 @@
-../j/template
\ No newline at end of file

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
  2021-08-23 11:50 ` [PR REVIEW] " Duncaen
  2021-08-23 13:34 ` [PR PATCH] [Updated] " subsetpark
@ 2021-08-23 13:35 ` subsetpark
  2021-08-23 13:40 ` Duncaen
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-08-23 13:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by subsetpark on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r693977153

Comment:
Hi @Duncaen, I interpreted your comment as `ln -s ./j j-devel` - but please correct me if I've misunderstood. Thanks for your help!

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (2 preceding siblings ...)
  2021-08-23 13:35 ` [PR REVIEW] " subsetpark
@ 2021-08-23 13:40 ` Duncaen
  2021-08-23 15:13 ` [PR PATCH] [Updated] " subsetpark
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Duncaen @ 2021-08-23 13:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r693981402

Comment:
We generally just use the package name, i.e. `ln -s j j-devel` if you do it form the srcpkgs directory.
This makes it easier to just read the source package without having to resolve or parse any paths.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (3 preceding siblings ...)
  2021-08-23 13:40 ` Duncaen
@ 2021-08-23 15:13 ` subsetpark
  2021-08-23 15:13 ` [PR REVIEW] " subsetpark
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-08-23 15:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is an updated pull request by subsetpark against master on the void-packages repository

https://github.com/subsetpark/void-packages master
https://github.com/void-linux/void-packages/pull/32644

j: add devel package
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

A patch file from https://github.com/void-linux/void-packages/pull/32644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32644.patch --]
[-- Type: text/x-diff, Size: 2520 bytes --]

From ff01a35fb4d4b847a7f1375fcde18d5dfe9c66f4 Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 06:24:43 -0400
Subject: [PATCH 1/3] j: add devel package

---
 srcpkgs/j-devel/template |  1 +
 srcpkgs/j/template       | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
new file mode 120000
index 000000000000..13dc84296084
--- /dev/null
+++ b/srcpkgs/j-devel/template
@@ -0,0 +1 @@
+../j/template
\ No newline at end of file
diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index b6ce41a36077..cc8ac07710b0 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -1,7 +1,7 @@
 # Template file for 'j'
 pkgname=j
 version=901.f
-revision=1
+revision=2
 _vmaj="${version%.*}"
 _vmin="${version#${_vmaj}}"
 _vrel=${_vmaj}-release${_vmin:+-}${_vmin#.}
@@ -139,3 +139,14 @@ do_install() {
 	_jconsole_wrapper_script >bin/jc.sh
 	vbin "bin/jc.sh" jc
 }
+
+j-devel_package() {
+	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/*.a
+		vmove usr/lib/*.so
+		vmove usr/lib/pkgconfig
+	}
+}

From 5a2179b7efa57048a22f34134817a367676ebcfe Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 09:34:21 -0400
Subject: [PATCH 2/3] CR: @Duncaen - change symlink

---
 srcpkgs/j-devel          | 1 +
 srcpkgs/j-devel/template | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel
 delete mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
new file mode 120000
index 000000000000..568066327219
--- /dev/null
+++ b/srcpkgs/j-devel
@@ -0,0 +1 @@
+./j
\ No newline at end of file
diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
deleted file mode 120000
index 13dc84296084..000000000000
--- a/srcpkgs/j-devel/template
+++ /dev/null
@@ -1 +0,0 @@
-../j/template
\ No newline at end of file

From b21ec2b19eac48c95527e8e10bdad32b146be6fb Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 11:12:54 -0400
Subject: [PATCH 3/3] CR @Duncaen - tweak symlink

---
 srcpkgs/j-devel | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
index 568066327219..0fe2fa50e8e7 120000
--- a/srcpkgs/j-devel
+++ b/srcpkgs/j-devel
@@ -1 +1 @@
-./j
\ No newline at end of file
+j
\ No newline at end of file

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (4 preceding siblings ...)
  2021-08-23 15:13 ` [PR PATCH] [Updated] " subsetpark
@ 2021-08-23 15:13 ` subsetpark
  2021-08-27 17:40 ` ericonr
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-08-23 15:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by subsetpark on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r694064628

Comment:
Got it - made the change. Thanks again.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (5 preceding siblings ...)
  2021-08-23 15:13 ` [PR REVIEW] " subsetpark
@ 2021-08-27 17:40 ` ericonr
  2021-09-01  0:58 ` [PR PATCH] [Updated] " subsetpark
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-08-27 17:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r697613758

Comment:
```suggestion
		vmove "usr/lib/*.a"
		vmove "usr/lib/*.so"
```

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (6 preceding siblings ...)
  2021-08-27 17:40 ` ericonr
@ 2021-09-01  0:58 ` subsetpark
  2021-09-01  1:00 ` subsetpark
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-09-01  0:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is an updated pull request by subsetpark against master on the void-packages repository

https://github.com/subsetpark/void-packages master
https://github.com/void-linux/void-packages/pull/32644

j: add devel package
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

A patch file from https://github.com/void-linux/void-packages/pull/32644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32644.patch --]
[-- Type: text/x-diff, Size: 3362 bytes --]

From ff01a35fb4d4b847a7f1375fcde18d5dfe9c66f4 Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 06:24:43 -0400
Subject: [PATCH 1/4] j: add devel package

---
 srcpkgs/j-devel/template |  1 +
 srcpkgs/j/template       | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
new file mode 120000
index 000000000000..13dc84296084
--- /dev/null
+++ b/srcpkgs/j-devel/template
@@ -0,0 +1 @@
+../j/template
\ No newline at end of file
diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index b6ce41a36077..cc8ac07710b0 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -1,7 +1,7 @@
 # Template file for 'j'
 pkgname=j
 version=901.f
-revision=1
+revision=2
 _vmaj="${version%.*}"
 _vmin="${version#${_vmaj}}"
 _vrel=${_vmaj}-release${_vmin:+-}${_vmin#.}
@@ -139,3 +139,14 @@ do_install() {
 	_jconsole_wrapper_script >bin/jc.sh
 	vbin "bin/jc.sh" jc
 }
+
+j-devel_package() {
+	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/*.a
+		vmove usr/lib/*.so
+		vmove usr/lib/pkgconfig
+	}
+}

From 5a2179b7efa57048a22f34134817a367676ebcfe Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 09:34:21 -0400
Subject: [PATCH 2/4] CR: @Duncaen - change symlink

---
 srcpkgs/j-devel          | 1 +
 srcpkgs/j-devel/template | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel
 delete mode 120000 srcpkgs/j-devel/template

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
new file mode 120000
index 000000000000..568066327219
--- /dev/null
+++ b/srcpkgs/j-devel
@@ -0,0 +1 @@
+./j
\ No newline at end of file
diff --git a/srcpkgs/j-devel/template b/srcpkgs/j-devel/template
deleted file mode 120000
index 13dc84296084..000000000000
--- a/srcpkgs/j-devel/template
+++ /dev/null
@@ -1 +0,0 @@
-../j/template
\ No newline at end of file

From b21ec2b19eac48c95527e8e10bdad32b146be6fb Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 11:12:54 -0400
Subject: [PATCH 3/4] CR @Duncaen - tweak symlink

---
 srcpkgs/j-devel | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
index 568066327219..0fe2fa50e8e7 120000
--- a/srcpkgs/j-devel
+++ b/srcpkgs/j-devel
@@ -1 +1 @@
-./j
\ No newline at end of file
+j
\ No newline at end of file

From 16f59b5262fd639e7f7003daabac117272285bcf Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Tue, 31 Aug 2021 20:58:41 -0400
Subject: [PATCH 4/4] Update srcpkgs/j/template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Érico Nogueira Rolim <34201958+ericonr@users.noreply.github.com>
---
 srcpkgs/j/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index cc8ac07710b0..4372c3470f71 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -145,8 +145,8 @@ j-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
-		vmove usr/lib/*.a
-		vmove usr/lib/*.so
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
 		vmove usr/lib/pkgconfig
 	}
 }

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (7 preceding siblings ...)
  2021-09-01  0:58 ` [PR PATCH] [Updated] " subsetpark
@ 2021-09-01  1:00 ` subsetpark
  2021-09-01  1:00 ` subsetpark
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-09-01  1:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is an updated pull request by subsetpark against master on the void-packages repository

https://github.com/subsetpark/void-packages master
https://github.com/void-linux/void-packages/pull/32644

j: add devel package
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

A patch file from https://github.com/void-linux/void-packages/pull/32644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32644.patch --]
[-- Type: text/x-diff, Size: 1180 bytes --]

From de06b80136327d2f3d1799da3da35fc42fe79e84 Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 06:24:43 -0400
Subject: [PATCH] j: add devel package

---
 srcpkgs/j-devel    |  1 +
 srcpkgs/j/template | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
new file mode 120000
index 000000000000..0fe2fa50e8e7
--- /dev/null
+++ b/srcpkgs/j-devel
@@ -0,0 +1 @@
+j
\ No newline at end of file
diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index b6ce41a36077..4372c3470f71 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -1,7 +1,7 @@
 # Template file for 'j'
 pkgname=j
 version=901.f
-revision=1
+revision=2
 _vmaj="${version%.*}"
 _vmin="${version#${_vmaj}}"
 _vrel=${_vmaj}-release${_vmin:+-}${_vmin#.}
@@ -139,3 +139,14 @@ do_install() {
 	_jconsole_wrapper_script >bin/jc.sh
 	vbin "bin/jc.sh" jc
 }
+
+j-devel_package() {
+	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove usr/lib/pkgconfig
+	}
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (8 preceding siblings ...)
  2021-09-01  1:00 ` subsetpark
@ 2021-09-01  1:00 ` subsetpark
  2021-09-01 12:08 ` ericonr
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-09-01  1:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by subsetpark on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#issuecomment-909772949

Comment:
@ericonr done!

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (9 preceding siblings ...)
  2021-09-01  1:00 ` subsetpark
@ 2021-09-01 12:08 ` ericonr
  2021-09-01 13:10 ` [PR PATCH] [Updated] " subsetpark
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-09-01 12:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#issuecomment-910221449

Comment:
Hi, can you rebase the PR so CI can run?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (10 preceding siblings ...)
  2021-09-01 12:08 ` ericonr
@ 2021-09-01 13:10 ` subsetpark
  2021-09-01 13:11 ` subsetpark
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-09-01 13:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is an updated pull request by subsetpark against master on the void-packages repository

https://github.com/subsetpark/void-packages master
https://github.com/void-linux/void-packages/pull/32644

j: add devel package
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

A patch file from https://github.com/void-linux/void-packages/pull/32644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32644.patch --]
[-- Type: text/x-diff, Size: 1180 bytes --]

From 9b299b6d82de7e5c56baacaacc3f0cb86ab1e56b Mon Sep 17 00:00:00 2001
From: Zach Smith <zd@zdsmith.com>
Date: Mon, 23 Aug 2021 06:24:43 -0400
Subject: [PATCH] j: add devel package

---
 srcpkgs/j-devel    |  1 +
 srcpkgs/j/template | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/j-devel

diff --git a/srcpkgs/j-devel b/srcpkgs/j-devel
new file mode 120000
index 000000000000..0fe2fa50e8e7
--- /dev/null
+++ b/srcpkgs/j-devel
@@ -0,0 +1 @@
+j
\ No newline at end of file
diff --git a/srcpkgs/j/template b/srcpkgs/j/template
index b6ce41a36077..4372c3470f71 100644
--- a/srcpkgs/j/template
+++ b/srcpkgs/j/template
@@ -1,7 +1,7 @@
 # Template file for 'j'
 pkgname=j
 version=901.f
-revision=1
+revision=2
 _vmaj="${version%.*}"
 _vmin="${version#${_vmaj}}"
 _vrel=${_vmaj}-release${_vmin:+-}${_vmin#.}
@@ -139,3 +139,14 @@ do_install() {
 	_jconsole_wrapper_script >bin/jc.sh
 	vbin "bin/jc.sh" jc
 }
+
+j-devel_package() {
+	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove usr/lib/pkgconfig
+	}
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (11 preceding siblings ...)
  2021-09-01 13:10 ` [PR PATCH] [Updated] " subsetpark
@ 2021-09-01 13:11 ` subsetpark
  2021-09-01 18:18 ` ericonr
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-09-01 13:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by subsetpark on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#issuecomment-910270939

Comment:
@ericonr done.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (12 preceding siblings ...)
  2021-09-01 13:11 ` subsetpark
@ 2021-09-01 18:18 ` ericonr
  2021-09-01 20:16 ` subsetpark
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-09-01 18:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#issuecomment-910539206

Comment:
And now apparently the build errors out >.<

Can you try adding `CFLAGS=-Wno-error` to the template? Otherwise it might be necessary to patch `-Werror` out from their stuff.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (13 preceding siblings ...)
  2021-09-01 18:18 ` ericonr
@ 2021-09-01 20:16 ` subsetpark
  2021-09-02 18:55 ` [PR REVIEW] " paper42
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: subsetpark @ 2021-09-01 20:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by subsetpark on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#issuecomment-910698278

Comment:
@ericonr unfortunately, I couldn't find a way to add that to CFLAGS in the makefile. I think I've reached the end of my abilities on this one; it gets into specifics of the build script. Hopefully the maintainer of the template understands better how to get this over the finish line.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (14 preceding siblings ...)
  2021-09-01 20:16 ` subsetpark
@ 2021-09-02 18:55 ` paper42
  2021-09-10 21:21 ` paper42
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2021-09-02 18:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r701343215

Comment:
None of these regexes will match, did you test this PR?
The only libraries in j are:
```
/usr/lib/j/j64/jconsole
/usr/lib/j/j64/libj.so
/usr/lib/j/j64avx/jconsole
/usr/lib/j/j64avx/libj.so
/usr/lib/j/j64avx2/jconsole
/usr/lib/j/j64avx2/libj.so
```
and they are required in the main package or jc won't work. What exactly do you want to split to -devel?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Closed]: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (16 preceding siblings ...)
  2021-09-10 21:21 ` paper42
@ 2021-09-10 21:21 ` paper42
  2021-09-10 21:22 ` [PR REVIEW] " paper42
  18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2021-09-10 21:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

There's a closed pull request on the void-packages repository

j: add devel package
https://github.com/void-linux/void-packages/pull/32644

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

fixes #32640.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (15 preceding siblings ...)
  2021-09-02 18:55 ` [PR REVIEW] " paper42
@ 2021-09-10 21:21 ` paper42
  2021-09-10 21:21 ` [PR PATCH] [Closed]: " paper42
  2021-09-10 21:22 ` [PR REVIEW] " paper42
  18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2021-09-10 21:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#issuecomment-917219969

Comment:
As mentioned in https://github.com/void-linux/void-packages/pull/32644#discussion_r701343215, this approach is wrong. The files that are supposed to be split to a -devel subpackage do not exist, so there is no need to do the split.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR REVIEW] j: add devel package
  2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
                   ` (17 preceding siblings ...)
  2021-09-10 21:21 ` [PR PATCH] [Closed]: " paper42
@ 2021-09-10 21:22 ` paper42
  18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2021-09-10 21:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32644#discussion_r701343215

Comment:
None of these regexes will match, did you test this PR?
The only libraries in j are in `/usr/lib/j`:
```
/usr/lib/j/j64/jconsole
/usr/lib/j/j64/libj.so
/usr/lib/j/j64avx/jconsole
/usr/lib/j/j64avx/libj.so
/usr/lib/j/j64avx2/jconsole
/usr/lib/j/j64avx2/libj.so
```
and they are required in the main package or `/usr/bin/jc` won't work. What exactly do you want to split to -devel?

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2021-09-10 21:22 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 10:32 [PR PATCH] j: add devel package subsetpark
2021-08-23 11:50 ` [PR REVIEW] " Duncaen
2021-08-23 13:34 ` [PR PATCH] [Updated] " subsetpark
2021-08-23 13:35 ` [PR REVIEW] " subsetpark
2021-08-23 13:40 ` Duncaen
2021-08-23 15:13 ` [PR PATCH] [Updated] " subsetpark
2021-08-23 15:13 ` [PR REVIEW] " subsetpark
2021-08-27 17:40 ` ericonr
2021-09-01  0:58 ` [PR PATCH] [Updated] " subsetpark
2021-09-01  1:00 ` subsetpark
2021-09-01  1:00 ` subsetpark
2021-09-01 12:08 ` ericonr
2021-09-01 13:10 ` [PR PATCH] [Updated] " subsetpark
2021-09-01 13:11 ` subsetpark
2021-09-01 18:18 ` ericonr
2021-09-01 20:16 ` subsetpark
2021-09-02 18:55 ` [PR REVIEW] " paper42
2021-09-10 21:21 ` paper42
2021-09-10 21:21 ` [PR PATCH] [Closed]: " paper42
2021-09-10 21:22 ` [PR REVIEW] " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).