Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New packages: xcolor-0.5
@ 2021-06-22  7:04 shubham-cpp
  2021-06-22  7:21 ` biopsin
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22  7:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

There is a new pull request by shubham-cpp against master on the void-packages repository

https://github.com/shubham-cpp/void-packages support_xcolor
https://github.com/void-linux/void-packages/pull/31605

New packages: xcolor-0.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/31605.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-support_xcolor-31605.patch --]
[-- Type: text/x-diff, Size: 1322 bytes --]

From 4378939c469889a684182061845fe24d23ca5f83 Mon Sep 17 00:00:00 2001
From: Shubham Pawar <shubhampawar3007@gmail.com>
Date: Tue, 22 Jun 2021 12:24:24 +0530
Subject: [PATCH] Minimalistic X11 color picker written is Rust

---
 srcpkgs/xcolor/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/xcolor/template

diff --git a/srcpkgs/xcolor/template b/srcpkgs/xcolor/template
new file mode 100644
index 000000000000..8ff7421e540f
--- /dev/null
+++ b/srcpkgs/xcolor/template
@@ -0,0 +1,25 @@
+# Template file for 'xcolor'
+pkgname=xcolor
+version=0.5.0
+revision=1
+archs="x86_64"
+wrksrc=${pkgname}
+build_style=cargo
+makedepends="libxcb-devel libX11-devel libXcursor-devel libXrender-devel"
+hostmakedepends="rust python3 git pkg-config"
+short_desc="Lightweight color picker for X11 written in Rust"
+maintainer="Shubham Pawar <shubhampawar3007@gmail.com>"
+license="MIT"
+homepage="https://github.com/Soft/xcolor"
+# distfiles="https://github.com/Soft/xcolor/archive/${version}.tar.gz"
+checksum=35e8eaadeb53d77f90869af4e97bd2253a73f438624c7ce6ee7156d12bb83fce
+
+do_fetch() {
+    git clone https://github.com/Soft/xcolor.git ${wrksrc}
+}
+
+post_install() {
+    vman man/xcolor.1
+    vinstall extra/xcolor.desktop 644 usr/share/applications
+    vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
@ 2021-06-22  7:21 ` biopsin
  2021-06-22  7:32 ` shubham-cpp
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: biopsin @ 2021-06-22  7:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-865665550

Comment:
PS:
> ..templates using tip of development branch taken at build time and releases created by the package maintainer won't be accepted.
2 choices : Make upstream release 0.5 or package the one from 2018

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
  2021-06-22  7:21 ` biopsin
@ 2021-06-22  7:32 ` shubham-cpp
  2021-06-22 14:09 ` ericonr
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22  7:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-865672485

Comment:
So i would need to fork, create a release then update the template, right?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
  2021-06-22  7:21 ` biopsin
  2021-06-22  7:32 ` shubham-cpp
@ 2021-06-22 14:09 ` ericonr
  2021-06-22 14:09 ` ericonr
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-06-22 14:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-866017293

Comment:
No, forking a project just to make a release isn't really acceptable.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (2 preceding siblings ...)
  2021-06-22 14:09 ` ericonr
@ 2021-06-22 14:09 ` ericonr
  2021-06-22 14:22 ` [PR REVIEW] " q66
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-06-22 14:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-866017293

Comment:
No, forking a project just to make a release isn't really acceptable

Asking upstream for a proper release is the way to go.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (3 preceding siblings ...)
  2021-06-22 14:09 ` ericonr
@ 2021-06-22 14:22 ` q66
  2021-06-22 14:50 ` shubham-cpp
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: q66 @ 2021-06-22 14:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#discussion_r656271545

Comment:
no

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (4 preceding siblings ...)
  2021-06-22 14:22 ` [PR REVIEW] " q66
@ 2021-06-22 14:50 ` shubham-cpp
  2021-06-22 14:50 ` shubham-cpp
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-866051420

Comment:
> Asking upstream for a proper release is the way to go.
An [issue](https://github.com/Soft/xcolor/issues/21) was created on 1 May 2021 but the author has not replied

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (5 preceding siblings ...)
  2021-06-22 14:50 ` shubham-cpp
@ 2021-06-22 14:50 ` shubham-cpp
  2021-06-22 14:53 ` [PR REVIEW] " shubham-cpp
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-866051420

Comment:
> Asking upstream for a proper release is the way to go.

An [issue](https://github.com/Soft/xcolor/issues/21) was created on 1 May 2021 but the author has not replied

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (6 preceding siblings ...)
  2021-06-22 14:50 ` shubham-cpp
@ 2021-06-22 14:53 ` shubham-cpp
  2021-06-22 15:09 ` paper42
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22 14:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#discussion_r656301576

Comment:
what is the issue?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (7 preceding siblings ...)
  2021-06-22 14:53 ` [PR REVIEW] " shubham-cpp
@ 2021-06-22 15:09 ` paper42
  2021-06-22 15:09 ` [PR PATCH] [Closed]: " shubham-cpp
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: paper42 @ 2021-06-22 15:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#discussion_r656317215

Comment:
What's the issue with other architectures that made you restrict the package only to glibc x86_64?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (9 preceding siblings ...)
  2021-06-22 15:09 ` [PR PATCH] [Closed]: " shubham-cpp
@ 2021-06-22 15:09 ` shubham-cpp
  2021-06-22 15:14 ` [PR REVIEW] " shubham-cpp
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22 15:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-866067661

Comment:
I dont think the original author of this software will create a next release so I'll close this PR. If he does a release I'll make a PR

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Closed]: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (8 preceding siblings ...)
  2021-06-22 15:09 ` paper42
@ 2021-06-22 15:09 ` shubham-cpp
  2021-06-22 15:09 ` shubham-cpp
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22 15:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

There's a closed pull request on the void-packages repository

New packages: xcolor-0.5
https://github.com/void-linux/void-packages/pull/31605

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (10 preceding siblings ...)
  2021-06-22 15:09 ` shubham-cpp
@ 2021-06-22 15:14 ` shubham-cpp
  2021-08-27 23:04 ` Barbarossa93
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-06-22 15:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New review comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#discussion_r656321789

Comment:
The [PKGBUILD](https://aur.archlinux.org/packages/xcolor) for archlinux only mentions x86_64. I do admit I didn't look that deep into it, since I don't have a 32-bit machine

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (11 preceding siblings ...)
  2021-06-22 15:14 ` [PR REVIEW] " shubham-cpp
@ 2021-08-27 23:04 ` Barbarossa93
  2021-08-28  6:36 ` shubham-cpp
  2021-08-28 13:26 ` Barbarossa93
  14 siblings, 0 replies; 16+ messages in thread
From: Barbarossa93 @ 2021-08-27 23:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by Barbarossa93 on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-907517568

Comment:
Looks like he made a new release! https://github.com/Soft/xcolor/releases/tag/0.5.0
Would you consider adding another PR? I'd love to have this on my void setup :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (12 preceding siblings ...)
  2021-08-27 23:04 ` Barbarossa93
@ 2021-08-28  6:36 ` shubham-cpp
  2021-08-28 13:26 ` Barbarossa93
  14 siblings, 0 replies; 16+ messages in thread
From: shubham-cpp @ 2021-08-28  6:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by shubham-cpp on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-907581691

Comment:
Unfortunately I switched to ubuntu for company reasons ;(

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New packages: xcolor-0.5
  2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
                   ` (13 preceding siblings ...)
  2021-08-28  6:36 ` shubham-cpp
@ 2021-08-28 13:26 ` Barbarossa93
  14 siblings, 0 replies; 16+ messages in thread
From: Barbarossa93 @ 2021-08-28 13:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by Barbarossa93 on void-packages repository

https://github.com/void-linux/void-packages/pull/31605#issuecomment-907626251

Comment:
Oof, I'm so sorry :(

I could probably do it, but I have yet to make a template for a rust project, so it may take me a bit.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-08-28 13:26 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22  7:04 [PR PATCH] New packages: xcolor-0.5 shubham-cpp
2021-06-22  7:21 ` biopsin
2021-06-22  7:32 ` shubham-cpp
2021-06-22 14:09 ` ericonr
2021-06-22 14:09 ` ericonr
2021-06-22 14:22 ` [PR REVIEW] " q66
2021-06-22 14:50 ` shubham-cpp
2021-06-22 14:50 ` shubham-cpp
2021-06-22 14:53 ` [PR REVIEW] " shubham-cpp
2021-06-22 15:09 ` paper42
2021-06-22 15:09 ` [PR PATCH] [Closed]: " shubham-cpp
2021-06-22 15:09 ` shubham-cpp
2021-06-22 15:14 ` [PR REVIEW] " shubham-cpp
2021-08-27 23:04 ` Barbarossa93
2021-08-28  6:36 ` shubham-cpp
2021-08-28 13:26 ` Barbarossa93

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).