Re: [PR PATCH] [Updated] New package: lightdm-slick-greeter-1.5.4

[sernkut <sernkut@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

There is an updated pull request by sernkut against master on the void-packages repository

https://github.com/sernkut/void-packages master
https://github.com/void-linux/void-packages/pull/32747

New package: lightdm-slick-greeter-1.5.4
This PR is an updated version of #24933 as the original seems to have stalled. The requested changes have also been added.  
There's also an associated package request for this PR: #32267  
  
The PR is split into multiple commits so that the original author has attribution.  
  
I've tested this package on `x86_64`, `x86_64-musl`, `aarch64 (RPI3)` and `aarch64-musl (RPI3)`  
  
EDIT: I've also tested the package on `i686`

A patch file from https://github.com/void-linux/void-packages/pull/32747.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32747.patch --]
[-- Type: text/x-diff, Size: 8085 bytes --]

From 4c5f32715c78efb036266801bc5250188ba791ba Mon Sep 17 00:00:00 2001
From: chgt <christian.gimbatti@gmail.com>
Date: Wed, 16 Sep 2020 01:45:26 +0200
Subject: [PATCH 1/4] New package: lightdm-slick-greeter-1.4.1

---
 srcpkgs/lightdm-slick-greeter/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/lightdm-slick-greeter/template

diff --git a/srcpkgs/lightdm-slick-greeter/template b/srcpkgs/lightdm-slick-greeter/template
new file mode 100644
index 000000000000..2b17f9f627e7
--- /dev/null
+++ b/srcpkgs/lightdm-slick-greeter/template
@@ -0,0 +1,20 @@
+# Template file for 'lightdm-slick-greeter'
+pkgname=lightdm-slick-greeter
+version=1.4.1
+revision=1
+wrksrc="slick-greeter-${version}"
+build_style=gnu-configure
+hostmakedepends="automake pkg-config intltool gettext-devel glib-devel vala-devel"
+makedepends="lightdm-devel libxklavier-devel gtk+3-devel libcanberra-devel"
+short_desc="Lightdm Slick Greeter"
+maintainer="chgt <christian.gimbatti@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/linuxmint/slick-greeter"
+distfiles="https://github.com/linuxmint/slick-greeter/archive/${version}.tar.gz"
+checksum=55750c9ed3967812a05c918faa65c9dbd686b72bc565a290cb903a2f027f3b4d
+
+pre_configure() {
+	aclocal --install
+	autoreconf -vfi
+	intltoolize -f
+}

From 34b1dec7b7a4f018d33007d7404739d15282e435 Mon Sep 17 00:00:00 2001
From: sernkut <sernkut@disroot.org>
Date: Sun, 29 Aug 2021 20:07:25 +0300
Subject: [PATCH 2/4] lightdm-slick-greeter: Add config file

---
 .../files/slick-greeter.conf                  | 74 +++++++++++++++++++
 srcpkgs/lightdm-slick-greeter/template        |  7 +-
 2 files changed, 80 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/lightdm-slick-greeter/files/slick-greeter.conf

diff --git a/srcpkgs/lightdm-slick-greeter/files/slick-greeter.conf b/srcpkgs/lightdm-slick-greeter/files/slick-greeter.conf
new file mode 100644
index 000000000000..333c7c745d47
--- /dev/null
+++ b/srcpkgs/lightdm-slick-greeter/files/slick-greeter.conf
@@ -0,0 +1,74 @@
+# LightDM slick-greeter Configuration
+#
+# Behavior:
+#  activate-numlock = Whether to activate numlock. This features requires the installation of numlockx. (true or false)
+#  play-ready-sound = A sound file to play when the greeter is ready
+#  hidden-users = List of usernames that are hidden until a special key combination is hit
+#  group-filter = List of groups that users must be part of to be shown (empty list shows all users)
+#  only-on-monitor = Sets the monitor on which to show the login window, -1 means "follow the mouse"
+#
+# Appearance:
+#  background = Background file to use, either an image path or a color (e.g. #772953)
+#  background-color = Background color (e.g. #772953), set before wallpaper is seen
+#  draw-user-backgrounds = Whether to draw user backgrounds (true or false)
+#  stretch-background-across-monitors = Whether to stretch the background across multiple monitors (false by default)
+#
+#  draw-grid = Whether to draw an overlay grid (true or false)
+#  onscreen-keyboard = Whether to enable the onscreen keyboard (true or false)
+#  show-hostname = Whether to show the hostname in the menubar (true or false)
+#  show-power = Whether to show the power indicator in the menubar (true or false)
+#  show-a11y = Whether to show the accessibility options in the menubar (true or false)
+#  show-keyboard = Whether to show the keyboard indicator in the menubar (true or false)
+#  show-clock = Whether to show the clock in the menubar (true or false)
+#  show-quit = Whether to show the quit menu in the menubar (true or false)
+#
+#  clock-format = What clock format to use (e.g., %H:%M or %l:%M %p)
+#
+#  logo = Logo file to use
+#  other-monitors-logo = Logo file to use for other monitors
+#
+#  theme-name = GTK+ theme to use
+#  icon-theme-name = Icon theme to use
+#
+#  font-name = Font to use
+#  xft-antialias = Whether to antialias Xft fonts (true or false)
+#  xft-dpi = Resolution for Xft in dots per inch
+#  xft-hintstyle = What degree of hinting to use (hintnone/hintslight/hintmedium/hintfull)
+#  xft-rgba = Type of subpixel antialiasing (none/rgb/bgr/vrgb/vbgr)
+#
+# Accessibility:
+#  high-contrast = Whether to use a high contrast theme (true or false)
+#  screen-reader = Whether to enable the screen reader (true or false)
+#  enable-hidpi = Whether to enable HiDPI support (on/off/auto)
+
+[Greeter]
+#activate-numlock=
+#background=
+#background-color=
+#draw-user-backgrounds=
+#draw-grid=
+#show-hostname=
+#show-power=
+#show-a11y=
+#show-keyboard=
+#show-clock=
+#show-quit=
+#logo=
+#other-monitors-logo=
+#theme-name=
+#icon-theme-name=
+#font-name=
+#xft-antialias=
+#xft-dpi=
+#xft-hintstyle=
+#xft-rgba=
+#onscreen-keyboard=
+#high-contrast=
+#screen-reader=
+#play-ready-sound=
+#hidden-users=
+#group-filter=
+#enable-hidpi=
+#only-on-monitor=
+#stretch-background-across-monitors=
+#clock-format=
diff --git a/srcpkgs/lightdm-slick-greeter/template b/srcpkgs/lightdm-slick-greeter/template
index 2b17f9f627e7..aec9d088dc24 100644
--- a/srcpkgs/lightdm-slick-greeter/template
+++ b/srcpkgs/lightdm-slick-greeter/template
@@ -1,11 +1,12 @@
 # Template file for 'lightdm-slick-greeter'
 pkgname=lightdm-slick-greeter
 version=1.4.1
-revision=1
+revision=2
 wrksrc="slick-greeter-${version}"
 build_style=gnu-configure
 hostmakedepends="automake pkg-config intltool gettext-devel glib-devel vala-devel"
 makedepends="lightdm-devel libxklavier-devel gtk+3-devel libcanberra-devel"
+conf_files="/etc/lightdm/slick-greeter.conf"
 short_desc="Lightdm Slick Greeter"
 maintainer="chgt <christian.gimbatti@gmail.com>"
 license="GPL-3.0-or-later"
@@ -18,3 +19,7 @@ pre_configure() {
 	autoreconf -vfi
 	intltoolize -f
 }
+
+post_install() {
+	vinstall "${FILESDIR}/slick-greeter.conf" 644 etc/lightdm
+}

From d88a4876b8ccdf0ce660ba5465b1af586af13ca3 Mon Sep 17 00:00:00 2001
From: sernkut <sernkut@disroot.org>
Date: Sun, 29 Aug 2021 20:08:12 +0300
Subject: [PATCH 3/4] lightdm-slick-greeter: update to 1.5.4

---
 srcpkgs/lightdm-slick-greeter/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/lightdm-slick-greeter/template b/srcpkgs/lightdm-slick-greeter/template
index aec9d088dc24..8c6e4949a39a 100644
--- a/srcpkgs/lightdm-slick-greeter/template
+++ b/srcpkgs/lightdm-slick-greeter/template
@@ -1,7 +1,7 @@
 # Template file for 'lightdm-slick-greeter'
 pkgname=lightdm-slick-greeter
-version=1.4.1
-revision=2
+version=1.5.4
+revision=1
 wrksrc="slick-greeter-${version}"
 build_style=gnu-configure
 hostmakedepends="automake pkg-config intltool gettext-devel glib-devel vala-devel"
@@ -12,7 +12,7 @@ maintainer="chgt <christian.gimbatti@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/linuxmint/slick-greeter"
 distfiles="https://github.com/linuxmint/slick-greeter/archive/${version}.tar.gz"
-checksum=55750c9ed3967812a05c918faa65c9dbd686b72bc565a290cb903a2f027f3b4d
+checksum=387d5a9e2882d56173324025878a747f729d933d0d8d8e6fbc1f2ce0118c0df5
 
 pre_configure() {
 	aclocal --install

From eed0b980e69bd5c118cbbd762623dc59f908e702 Mon Sep 17 00:00:00 2001
From: sernkut <sernkut@disroot.org>
Date: Mon, 30 Aug 2021 08:26:18 +0300
Subject: [PATCH 4/4] lightdm-slick-greeter: Disable tests as they have not
 been updated

---
 srcpkgs/lightdm-slick-greeter/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/lightdm-slick-greeter/template b/srcpkgs/lightdm-slick-greeter/template
index 8c6e4949a39a..4b08b7c37d1c 100644
--- a/srcpkgs/lightdm-slick-greeter/template
+++ b/srcpkgs/lightdm-slick-greeter/template
@@ -13,6 +13,8 @@ license="GPL-3.0-or-later"
 homepage="https://github.com/linuxmint/slick-greeter"
 distfiles="https://github.com/linuxmint/slick-greeter/archive/${version}.tar.gz"
 checksum=387d5a9e2882d56173324025878a747f729d933d0d8d8e6fbc1f2ce0118c0df5
+# tests provided have not been updated in many years and don't even compile as the code base has changed since the writing of the tests
+make_check=no
 
 pre_configure() {
 	aclocal --install